coreboot-gerrit January 2015

coreboot-gerrit@coreboot.org

1 participants
1236 discussions

Patch set updated for coreboot: 557448e intel/cpu/model_2065x|nehalem: remove unsupported MSR_PP0/MSR_PP1
by Alexander Couzens 31 Jan '15

31 Jan '15

Alexander Couzens (lynxis(a)fe80.eu) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8295 -gerrit commit 557448e85dba0f8a9291df59d6cf9bddb949d720 Author: Alexander Couzens <lynxis(a)fe80.eu> Date: Wed Jan 28 03:00:42 2015 +0100 intel/cpu/model_2065x|nehalem: remove unsupported MSR_PP0/MSR_PP1 It seems to be a relict when this cpu support was backported from sandybridge. Change-Id: I2277bb90e6da2676b31eb2665b7c15f074e3d4bf Signed-off-by: Alexander Couzens <lynxis(a)fe80.eu> --- src/cpu/intel/model_2065x/finalize.c | 17 ----------------- src/cpu/intel/model_2065x/model_2065x.h | 10 ---------- 2 files changed, 27 deletions(-) diff --git a/src/cpu/intel/model_2065x/finalize.c b/src/cpu/intel/model_2065x/finalize.c index 3c494e4..451ebf2 100644 --- a/src/cpu/intel/model_2065x/finalize.c +++ b/src/cpu/intel/model_2065x/finalize.c @@ -52,23 +52,6 @@ void intel_model_2065x_finalize_smm(void) if (cpuid_ecx(1) & (1 << 25)) msr_set_bit(MSR_FEATURE_CONFIG, 0); -#ifdef LOCK_POWER_CONTROL_REGISTERS - /* - * Lock the power control registers. - * - * These registers can be left unlocked if modifying power - * limits from the OS is desirable. Modifying power limits - * from the OS can be especially useful for experimentation - * during early phases of system bringup while the thermal - * power envelope is being proven. - */ - - msr_set_bit(MSR_PP0_CURRENT_CONFIG, 31); - msr_set_bit(MSR_PP1_CURRENT_CONFIG, 31); - msr_set_bit(MSR_PKG_POWER_LIMIT, 63); - msr_set_bit(MSR_PP0_POWER_LIMIT, 31); - msr_set_bit(MSR_PP1_POWER_LIMIT, 31); -#endif /* Lock TM interupts - route thermal events to all processors */ msr_set_bit(MSR_MISC_PWR_MGMT, 22); diff --git a/src/cpu/intel/model_2065x/model_2065x.h b/src/cpu/intel/model_2065x/model_2065x.h index f9dc7e8..454f7be 100644 --- a/src/cpu/intel/model_2065x/model_2065x.h +++ b/src/cpu/intel/model_2065x/model_2065x.h @@ -74,16 +74,6 @@ #define PKG_POWER_LIMIT_TIME_SHIFT 17 #define PKG_POWER_LIMIT_TIME_MASK 0x7f -#define MSR_PP0_CURRENT_CONFIG 0x601 -#define PP0_CURRENT_LIMIT (112 << 3) /* 112 A */ -#define MSR_PP1_CURRENT_CONFIG 0x602 -#define PP1_CURRENT_LIMIT_SNB (35 << 3) /* 35 A */ -#define PP1_CURRENT_LIMIT_IVB (50 << 3) /* 50 A */ -#define MSR_PKG_POWER_SKU_UNIT 0x606 -#define MSR_PKG_POWER_SKU 0x614 -#define MSR_PP0_POWER_LIMIT 0x638 -#define MSR_PP1_POWER_LIMIT 0x640 - #define IVB_CONFIG_TDP_MIN_CPUID 0x306a2 #define MSR_CONFIG_TDP_NOMINAL 0x648 #define MSR_CONFIG_TDP_LEVEL1 0x649

1 0

Patch merged into coreboot/master: 86393bb vendorcode/amd/agesa/f14: update microcode
by gerrit＠coreboot.org 31 Jan '15

31 Jan '15

the following patch was just integrated into master: commit 86393bb64bfb190713eb96c83c856d286b8ec32a Author: Nicolas Reinecke <nr(a)das-labor.org> Date: Mon Jan 26 14:14:19 2015 +0100 vendorcode/amd/agesa/f14: update microcode 05000028 -> 05000029 tested on asrock E350M1 05000101 -> 05000119 Change-Id: Iccb096eb55a4a789c1e810f68c8c8eacfd5f8a0b Signed-off-by: Nicolas Reinecke <nr(a)das-labor.org> Reviewed-on: http://review.coreboot.org/8296 Tested-by: build bot (Jenkins) Reviewed-by: Philipp Deppenwiese <zaolin(a)das-labor.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> See http://review.coreboot.org/8296 for details. -gerrit

1 0

Patch merged into coreboot/master: cb6cfbd mainboard/lenovo/t420s/Kconfig: select NO_UART_ON_SUPERIO
by gerrit＠coreboot.org 31 Jan '15

31 Jan '15

the following patch was just integrated into master: commit cb6cfbdc06b5faee3c11468e35d6310268ab4901 Author: Nicolas Reinecke <nr(a)das-labor.org> Date: Tue Jan 13 13:42:04 2015 +0100 mainboard/lenovo/t420s/Kconfig: select NO_UART_ON_SUPERIO same as 37130ebdabe44989787aadeafbe79524970dec75 Change-Id: I73feed3a077dfcc61634147775df1e05fdb97e8b Signed-off-by: Nicolas Reinecke <nr(a)das-labor.org> Reviewed-on: http://review.coreboot.org/8278 Tested-by: build bot (Jenkins) Reviewed-by: Philipp Deppenwiese <zaolin(a)das-labor.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> See http://review.coreboot.org/8278 for details. -gerrit

1 0

Patch merged into coreboot/master: 5e03170 intel/model_2065x: update microcode
by gerrit＠coreboot.org 31 Jan '15

31 Jan '15

the following patch was just integrated into master: commit 5e031705417e9de9f5304703dd17dacca091e2cc Author: Nicolas Reinecke <nr(a)das-labor.org> Date: Sat Jan 3 20:28:08 2015 +0100 intel/model_2065x: update microcode Change-Id: I6c13518d2217bc823d409ab800bca011e76e9f25 Signed-off-by: Nicolas Reinecke <nr(a)das-labor.org> Reviewed-on: http://review.coreboot.org/8277 Tested-by: build bot (Jenkins) Reviewed-by: Philipp Deppenwiese <zaolin(a)das-labor.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> See http://review.coreboot.org/8277 for details. -gerrit

1 0

Patch merged into coreboot/master: 6d1158f southbridge/intel/bd82x6x native usb init: replace some magic values
by gerrit＠coreboot.org 31 Jan '15

31 Jan '15

the following patch was just integrated into master: commit 6d1158f3a91c172a216ab88ea426844f8cc8233e Author: Nicolas Reinecke <nr(a)das-labor.org> Date: Thu Jan 29 15:48:27 2015 +0100 southbridge/intel/bd82x6x native usb init: replace some magic values Some magic numbers are documented in the PCH datasheet so use them. Change-Id: I15b58ff99b3bc11ac437e5ea74f4f01b7c02032a Signed-off-by: Nicolas Reinecke <nr(a)das-labor.org> Reviewed-on: http://review.coreboot.org/8307 Tested-by: build bot (Jenkins) Reviewed-by: Philipp Deppenwiese <zaolin(a)das-labor.org> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> See http://review.coreboot.org/8307 for details. -gerrit

1 0

Patch merged into coreboot/master: 266971c lenovo/t530/romstage.c: add usb port description and missing oc config
by gerrit＠coreboot.org 31 Jan '15

31 Jan '15

the following patch was just integrated into master: commit 266971c1cd1891a41bcca6c25e95530c41c703fb Author: Nicolas Reinecke <nr(a)das-labor.org> Date: Thu Jan 29 10:07:53 2015 +0100 lenovo/t530/romstage.c: add usb port description and missing oc config OC2 at port 4 was missing. Verified with RCBA dump. Change-Id: Ide5701d53aeee28619204c7ac408662626aa11e4 Signed-off-by: Nicolas Reinecke <nr(a)das-labor.org> Reviewed-on: http://review.coreboot.org/8304 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Philipp Deppenwiese <zaolin(a)das-labor.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> See http://review.coreboot.org/8304 for details. -gerrit

1 0

Patch merged into coreboot/master: 5ecc6bc lenovo/t5x0: Make version look like something thinkpad_acpi would accept
by gerrit＠coreboot.org 31 Jan '15

31 Jan '15

the following patch was just integrated into master: commit 5ecc6bc7d696ddcc3c3f440f7bb20edfb9316b03 Author: Nicolas Reinecke <nr(a)das-labor.org> Date: Wed Jan 28 11:38:44 2015 +0100 lenovo/t5x0: Make version look like something thinkpad_acpi would accept thinkpad_acpi checks that BIOS version matches some pattern. Report version in this form. same as http://review.coreboot.org/4650 / 63acd22dc5366c72a7165138f5030df9523824dc Change-Id: I82d7a2b9f2ec56557b3a9c26d1af57ed39e31850 Signed-off-by: Nicolas Reinecke <nr(a)das-labor.org> Reviewed-on: http://review.coreboot.org/8302 Tested-by: build bot (Jenkins) Reviewed-by: Philipp Deppenwiese <zaolin(a)das-labor.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> See http://review.coreboot.org/8302 for details. -gerrit

1 0

Patch set updated for coreboot: 2699f13 amd/amdfam10: Fix AP crash during microcode version lookup
by Timothy Pearson 31 Jan '15

31 Jan '15

Timothy Pearson (tpearson(a)raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8310 -gerrit commit 2699f13a377f8a502356c9ea342c3a26b4cfd469 Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Fri Jan 30 23:47:45 2015 -0600 amd/amdfam10: Fix AP crash during microcode version lookup This resolves a failure to initialize APs on Istanbul devices While the table was a bit more elegant, the BSP needed a static table while the APs needed non-static tables due to simultaneous execution. If a static table was used each AP would crash in the for loop, while a non-static table would crash the BSP in the same for loop during cold boot. This solution keeps the logic in ROM. TEST: Booted Opteron 8356 and Opteron 2419 into Linux. Verified that, unlike before, FIDVID code ran on startup and that all APs were initialized and presented to Linux. Change-Id: I9e2554b50ad60a8d02ef4bd3fbee6fddb238d83f Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> --- src/cpu/amd/model_10xxx/update_microcode.c | 49 +++++++++++------------------- 1 file changed, 18 insertions(+), 31 deletions(-) diff --git a/src/cpu/amd/model_10xxx/update_microcode.c b/src/cpu/amd/model_10xxx/update_microcode.c index 95624e9..6a919b2 100644 --- a/src/cpu/amd/model_10xxx/update_microcode.c +++ b/src/cpu/amd/model_10xxx/update_microcode.c @@ -1,6 +1,7 @@ /* * This file is part of the coreboot project. * + * Copyright (C) 2015 Timothy Pearson <tpearson(a)raptorengineeringinc.com>, Raptor Engineering * Copyright (C) 2007 Advanced Micro Devices, Inc. * * This program is free software; you can redistribute it and/or modify @@ -56,38 +57,24 @@ static const u8 microcode_updates[] __attribute__ ((aligned(16))) = { 0x0, 0x0, 0x0, 0x0, }; -static u32 get_equivalent_processor_rev_id(u32 orig_id) { - static unsigned id_mapping_table[] = { - 0x100f00, 0x1000, - 0x100f01, 0x1000, - 0x100f02, 0x1000, - 0x100f20, 0x1020, - 0x100f21, 0x1020, - 0x100f2A, 0x1020, - 0x100f22, 0x1022, - 0x100f23, 0x1022, - 0x100f42, 0x1041, - 0x100f43, 0x1043, - 0x100f62, 0x1062, - 0x100f63, 0x1043, - 0x100f81, 0x1081, - 0x100fa0, 0x10A0, - }; - - u32 new_id; - int i; - - new_id = 0; - - for (i = 0; i < sizeof(id_mapping_table); i += 2 ) { - if(id_mapping_table[i]==orig_id) { - new_id = id_mapping_table[i + 1]; - break; - } - } - - return new_id; +u32 get_equivalent_processor_rev_id(u32 orig_id); +u32 get_equivalent_processor_rev_id(u32 orig_id) { + if (orig_id == 0x100f00) return 0x1000; + else if (orig_id == 0x100f01) return 0x1000; + else if (orig_id == 0x100f02) return 0x1000; + else if (orig_id == 0x100f20) return 0x1020; + else if (orig_id == 0x100f21) return 0x1020; + else if (orig_id == 0x100f2A) return 0x1020; + else if (orig_id == 0x100f22) return 0x1022; + else if (orig_id == 0x100f23) return 0x1022; + else if (orig_id == 0x100f42) return 0x1041; + else if (orig_id == 0x100f43) return 0x1043; + else if (orig_id == 0x100f62) return 0x1062; + else if (orig_id == 0x100f63) return 0x1043; + else if (orig_id == 0x100f81) return 0x1081; + else if (orig_id == 0x100fa0) return 0x10A0; + return 0; } void update_microcode(u32 cpu_deviceid)

1 0

Patch set updated for coreboot: 215647e asus/kfsn4-dre: Increase maximum logical CPUs for Istanbul devices
by Timothy Pearson 31 Jan '15

31 Jan '15

Timothy Pearson (tpearson(a)raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8311 -gerrit commit 215647eef0e360df538537ff50cd30a92e40885c Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Fri Jan 30 23:48:52 2015 -0600 asus/kfsn4-dre: Increase maximum logical CPUs for Istanbul devices Test: Single Opteron 2419 with 1GB RAM in slot A1 Booted Ubuntu Linux 14.04 and verified all 6 cores were visible Brief stress test of all 6 cores simultaneously Verified proper ACPI power states for all 6 cores Change-Id: I1e598e36f9eaed5ba8a18b9c62ceedee16870f15 Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> --- src/mainboard/asus/kfsn4-dre/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mainboard/asus/kfsn4-dre/Kconfig b/src/mainboard/asus/kfsn4-dre/Kconfig index 245fecf..5779418 100644 --- a/src/mainboard/asus/kfsn4-dre/Kconfig +++ b/src/mainboard/asus/kfsn4-dre/Kconfig @@ -54,7 +54,7 @@ config PCI_64BIT_PREF_MEM config MAX_CPUS int - default 8 + default 12 config MAX_PHYSICAL_CPUS int

1 0

New patch to review for coreboot: 98b1348 asus/kfsn4-dre: Increase maximum logical CPUs for Istanbul devices
by Timothy Pearson 31 Jan '15

31 Jan '15

Timothy Pearson (tpearson(a)raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8311 -gerrit commit 98b13481bafe104254397542e5b9c0f4e7c22bc5 Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Fri Jan 30 23:48:52 2015 -0600 asus/kfsn4-dre: Increase maximum logical CPUs for Istanbul devices Test: Single Opteron 2419 with 1GB RAM in slot A1 Booted Ubuntu Linux 14.04 and verified all 6 cores were visible Brief stress test of all 6 cores simultaneously Verified proper ACPI power states for all 6 cores Change-Id: I1e598e36f9eaed5ba8a18b9c62ceedee16870f15 Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> --- src/mainboard/asus/kfsn4-dre/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mainboard/asus/kfsn4-dre/Kconfig b/src/mainboard/asus/kfsn4-dre/Kconfig index 245fecf..5779418 100644 --- a/src/mainboard/asus/kfsn4-dre/Kconfig +++ b/src/mainboard/asus/kfsn4-dre/Kconfig @@ -54,7 +54,7 @@ config PCI_64BIT_PREF_MEM config MAX_CPUS int - default 8 + default 12 config MAX_PHYSICAL_CPUS int

1 0

← Newer
1
2
3
4
5
6
7
...
124
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2015