coreboot-gerrit January 2015

coreboot-gerrit@coreboot.org

1 participants
1236 discussions

Patch merged into coreboot/master: 0d7f8d0 amd/amdfam10: Update name table with Opteron 2400/8400 series codes
by gerrit＠coreboot.org 31 Jan '15

31 Jan '15

the following patch was just integrated into master: commit 0d7f8d0b790446cd7f2f806c37ecdc2b9c8ed741 Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Fri Jan 30 23:47:12 2015 -0600 amd/amdfam10: Update name table with Opteron 2400/8400 series codes Change-Id: I52587c0c0dffd814d39087475b8f14c500a68933 Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Reviewed-on: http://review.coreboot.org/8309 Reviewed-by: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Tested-by: build bot (Jenkins) See http://review.coreboot.org/8309 for details. -gerrit

1 0

New patch to review for coreboot: 2d5b038 winent/mb6047: switch to CAR version of ck804 early_setup.c
by Jonathan A. Kollasch 31 Jan '15

31 Jan '15

Jonathan A. Kollasch (jakllsch(a)kollasch.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8319 -gerrit commit 2d5b038bd5fa168d187d0c8e105be6da872348a0 Author: Jonathan A. Kollasch <jakllsch(a)kollasch.net> Date: Sat Jan 31 14:26:14 2015 -0600 winent/mb6047: switch to CAR version of ck804 early_setup.c Change-Id: I9b45b7fbd862a5600ead7ad4e623a8a87ae364aa Signed-off-by: Jonathan A. Kollasch <jakllsch(a)kollasch.net> --- src/mainboard/winent/mb6047/romstage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mainboard/winent/mb6047/romstage.c b/src/mainboard/winent/mb6047/romstage.c index 905248e..20eb92e 100644 --- a/src/mainboard/winent/mb6047/romstage.c +++ b/src/mainboard/winent/mb6047/romstage.c @@ -37,7 +37,7 @@ static inline int spd_read_byte(unsigned device, unsigned address) #include "lib/generic_sdram.c" #include "cpu/amd/dualcore/dualcore.c" #include <southbridge/nvidia/ck804/early_setup_ss.h> -#include "southbridge/nvidia/ck804/early_setup.c" +#include "southbridge/nvidia/ck804/early_setup_car.c" #include "cpu/amd/model_fxx/init_cpus.c" #if CONFIG_SET_FIDVID #include "cpu/amd/model_fxx/fidvid.c"

1 0

New patch to review for coreboot: 858458b winent/mb6047: no need to generate pstates twice
by Jonathan A. Kollasch 31 Jan '15

31 Jan '15

Jonathan A. Kollasch (jakllsch(a)kollasch.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8318 -gerrit commit 858458b107ad1db3681ba60fe47e80fa3ec9375c Author: Jonathan A. Kollasch <jakllsch(a)kollasch.net> Date: Sat Jan 31 14:23:36 2015 -0600 winent/mb6047: no need to generate pstates twice Recently ck804/lpc.c started generating pstates for us. Change-Id: Ie47fff0516e0e838fdcd5084074ce2cabfe7e290 Signed-off-by: Jonathan A. Kollasch <jakllsch(a)kollasch.net> --- src/mainboard/winent/mb6047/mainboard.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/mainboard/winent/mb6047/mainboard.c b/src/mainboard/winent/mb6047/mainboard.c index 9a8dd90..1783c1b 100644 --- a/src/mainboard/winent/mb6047/mainboard.c +++ b/src/mainboard/winent/mb6047/mainboard.c @@ -6,13 +6,8 @@ #include <arch/acpigen.h> #include <cpu/amd/amdk8_sysconf.h> -static void mainboard_acpi_fill_ssdt_generator(void) { - amd_generate_powernow(0, 0, 0); -} - static void mainboard_enable(device_t dev) { - dev->ops->acpi_fill_ssdt_generator = mainboard_acpi_fill_ssdt_generator; } struct chip_operations mainboard_ops = {

1 0

New patch to review for coreboot: 70786de winent/mb6047: use symbolic constant arguments for acpi_create_madt_lapic_nmis()
by Jonathan A. Kollasch 31 Jan '15

31 Jan '15

Jonathan A. Kollasch (jakllsch(a)kollasch.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8317 -gerrit commit 70786deb4cb1e9476eb33104730ce45f4d70342c Author: Jonathan A. Kollasch <jakllsch(a)kollasch.net> Date: Sat Jan 31 14:18:55 2015 -0600 winent/mb6047: use symbolic constant arguments for acpi_create_madt_lapic_nmis() Change-Id: I19af5f36a55d6c2906d603e940b3aadd2ca97140 Signed-off-by: Jonathan A. Kollasch <jakllsch(a)kollasch.net> --- src/mainboard/winent/mb6047/acpi_tables.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/mainboard/winent/mb6047/acpi_tables.c b/src/mainboard/winent/mb6047/acpi_tables.c index fdf2d80..63b41f0 100644 --- a/src/mainboard/winent/mb6047/acpi_tables.c +++ b/src/mainboard/winent/mb6047/acpi_tables.c @@ -47,14 +47,10 @@ unsigned long acpi_fill_madt(unsigned long current) current += acpi_create_madt_irqoverride((acpi_madt_irqoverride_t *) current, 0, 9, 9, MP_IRQ_TRIGGER_LEVEL | MP_IRQ_POLARITY_LOW); - /* 0: mean bus 0--->ISA */ - /* 0: PIC 0 */ - /* 2: APIC 2 */ - /* 5 mean: 0101 --> Edge-triggered, Active high */ - /* create all subtables for processors */ /* acpi_create_madt_lapic_nmis returns current, not size. */ - current = acpi_create_madt_lapic_nmis(current, 5, 1); + current = acpi_create_madt_lapic_nmis(current, + MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_HIGH, 1); return current; }

1 0

New patch to review for coreboot: b92fcbe winent/mb6047: clean up includes in acpi_tables.c
by Jonathan A. Kollasch 31 Jan '15

31 Jan '15

Jonathan A. Kollasch (jakllsch(a)kollasch.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8316 -gerrit commit b92fcbe41c05dd1603729af64ce62d327213f3b8 Author: Jonathan A. Kollasch <jakllsch(a)kollasch.net> Date: Sat Jan 31 14:17:43 2015 -0600 winent/mb6047: clean up includes in acpi_tables.c Change-Id: I63bdc856fa4232cd66ff2e48e39c2cdb97bb88d3 Signed-off-by: Jonathan A. Kollasch <jakllsch(a)kollasch.net> --- src/mainboard/winent/mb6047/acpi_tables.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/mainboard/winent/mb6047/acpi_tables.c b/src/mainboard/winent/mb6047/acpi_tables.c index 2b1084c..fdf2d80 100644 --- a/src/mainboard/winent/mb6047/acpi_tables.c +++ b/src/mainboard/winent/mb6047/acpi_tables.c @@ -13,12 +13,8 @@ #include <arch/acpi.h> #include <arch/smp/mpspec.h> #include <device/pci.h> -#include <device/pci_ids.h> -#include <cpu/x86/msr.h> -#include <cpu/amd/mtrr.h> #include <cpu/amd/amdk8_sysconf.h> -#include "northbridge/amd/amdk8/acpi.h" -#include <cpu/amd/powernow.h> +#include <assert.h> /* APIC */ unsigned long acpi_fill_madt(unsigned long current)

1 0

New patch to review for coreboot: 2d20f50 winent/mb6047: use correct ACPI SCI interupt trigger
by Jonathan A. Kollasch 31 Jan '15

31 Jan '15

Jonathan A. Kollasch (jakllsch(a)kollasch.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8315 -gerrit commit 2d20f504174f76722485c69d958b9a187438d2a8 Author: Jonathan A. Kollasch <jakllsch(a)kollasch.net> Date: Sat Jan 31 14:13:27 2015 -0600 winent/mb6047: use correct ACPI SCI interupt trigger Change-Id: I245c0afb66f3a29b5acb40e8d949d8b1aa08cd73 Signed-off-by: Jonathan A. Kollasch <jakllsch(a)kollasch.net> --- src/mainboard/winent/mb6047/acpi_tables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mainboard/winent/mb6047/acpi_tables.c b/src/mainboard/winent/mb6047/acpi_tables.c index 0c7c3a5..2b1084c 100644 --- a/src/mainboard/winent/mb6047/acpi_tables.c +++ b/src/mainboard/winent/mb6047/acpi_tables.c @@ -49,7 +49,7 @@ unsigned long acpi_fill_madt(unsigned long current) /* IRQ9 */ current += acpi_create_madt_irqoverride((acpi_madt_irqoverride_t *) - current, 0, 9, 9, MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_LOW); + current, 0, 9, 9, MP_IRQ_TRIGGER_LEVEL | MP_IRQ_POLARITY_LOW); /* 0: mean bus 0--->ISA */ /* 0: PIC 0 */

1 0

New patch to review for coreboot: 96d87ad winent/mb6047: drop inaccurate comment in acpi_tables.c
by Jonathan A. Kollasch 31 Jan '15

31 Jan '15

Jonathan A. Kollasch (jakllsch(a)kollasch.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8314 -gerrit commit 96d87ade8d54a5539eed364c73f3302ed8df9fbf Author: Jonathan A. Kollasch <jakllsch(a)kollasch.net> Date: Sat Jan 31 14:10:32 2015 -0600 winent/mb6047: drop inaccurate comment in acpi_tables.c Change-Id: Ib0bb8bed32b96a5f7fd48407bd111972f89e7907 Signed-off-by: Jonathan A. Kollasch <jakllsch(a)kollasch.net> --- src/mainboard/winent/mb6047/acpi_tables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mainboard/winent/mb6047/acpi_tables.c b/src/mainboard/winent/mb6047/acpi_tables.c index 15443ee..0c7c3a5 100644 --- a/src/mainboard/winent/mb6047/acpi_tables.c +++ b/src/mainboard/winent/mb6047/acpi_tables.c @@ -1,5 +1,5 @@ /* - * Island Aruma ACPI support + * ACPI support * written by Stefan Reinauer <stepan(a)openbios.org> * (C) 2005 Stefan Reinauer *

1 0

Patch set updated for coreboot: 65e7086 cpu/amd (non-AGESA): Fix AP crash during microcode version lookup
by Timothy Pearson 31 Jan '15

31 Jan '15

Timothy Pearson (tpearson(a)raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8310 -gerrit commit 65e7086989375d5aba8aaa51a92d7959934fad49 Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Fri Jan 30 23:47:45 2015 -0600 cpu/amd (non-AGESA): Fix AP crash during microcode version lookup Move mapping tables to struct and prevent OOB array access that was crashing the APs during CAR initialization. Change-Id: I9e2554b50ad60a8d02ef4bd3fbee6fddb238d83f Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> --- src/cpu/amd/model_10xxx/update_microcode.c | 47 ++++++++++------- src/cpu/amd/model_fxx/model_fxx_update_microcode.c | 61 +++++++++++++--------- 2 files changed, 63 insertions(+), 45 deletions(-) diff --git a/src/cpu/amd/model_10xxx/update_microcode.c b/src/cpu/amd/model_10xxx/update_microcode.c index 95624e9..3cdf978 100644 --- a/src/cpu/amd/model_10xxx/update_microcode.c +++ b/src/cpu/amd/model_10xxx/update_microcode.c @@ -1,6 +1,7 @@ /* * This file is part of the coreboot project. * + * Copyright (C) 2015 Timothy Pearson <tpearson(a)raptorengineeringinc.com>, Raptor Engineering * Copyright (C) 2007 Advanced Micro Devices, Inc. * * This program is free software; you can redistribute it and/or modify @@ -56,22 +57,30 @@ static const u8 microcode_updates[] __attribute__ ((aligned(16))) = { 0x0, 0x0, 0x0, 0x0, }; -static u32 get_equivalent_processor_rev_id(u32 orig_id) { - static unsigned id_mapping_table[] = { - 0x100f00, 0x1000, - 0x100f01, 0x1000, - 0x100f02, 0x1000, - 0x100f20, 0x1020, - 0x100f21, 0x1020, - 0x100f2A, 0x1020, - 0x100f22, 0x1022, - 0x100f23, 0x1022, - 0x100f42, 0x1041, - 0x100f43, 0x1043, - 0x100f62, 0x1062, - 0x100f63, 0x1043, - 0x100f81, 0x1081, - 0x100fa0, 0x10A0, +struct id_mapping { + uint32_t orig_id; + uint16_t new_id; +}; + +static u16 get_equivalent_processor_rev_id(u32 orig_id) { + static const struct id_mapping id_mapping_table[] = { + { 0x100f00, 0x1000 }, + { 0x100f01, 0x1000 }, + { 0x100f02, 0x1000 }, + { 0x100f20, 0x1020 }, + { 0x100f21, 0x1020 }, + { 0x100f2A, 0x1020 }, + { 0x100f22, 0x1022 }, + { 0x100f23, 0x1022 }, + { 0x100f42, 0x1041 }, + { 0x100f43, 0x1043 }, + { 0x100f62, 0x1062 }, + { 0x100f63, 0x1043 }, + { 0x100f81, 0x1081 }, + { 0x100fa0, 0x10A0 }, + + /* Array terminator */ + { 0xffffff, 0x0000 }, }; u32 new_id; @@ -79,9 +88,9 @@ static u32 get_equivalent_processor_rev_id(u32 orig_id) { new_id = 0; - for (i = 0; i < sizeof(id_mapping_table); i += 2 ) { - if(id_mapping_table[i]==orig_id) { - new_id = id_mapping_table[i + 1]; + for (i = 0; id_mapping_table[i].orig_id != 0xffffff; i++ ) { + if (id_mapping_table[i].orig_id == orig_id) { + new_id = id_mapping_table[i].new_id; break; } } diff --git a/src/cpu/amd/model_fxx/model_fxx_update_microcode.c b/src/cpu/amd/model_fxx/model_fxx_update_microcode.c index 4a53fea..af10ce0 100644 --- a/src/cpu/amd/model_fxx/model_fxx_update_microcode.c +++ b/src/cpu/amd/model_fxx/model_fxx_update_microcode.c @@ -3,6 +3,7 @@ * * Copyright (C) 2005 Advanced Micro Devices, Inc. * Copyright (C) 2010 Advanced Micro Devices, Inc. + * Copyright (C) 2015 Timothy Pearson <tpearson(a)raptorengineeringinc.com>, Raptor Engineering * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -40,35 +41,43 @@ static uint8_t microcode_updates[] __attribute__ ((aligned(16))) = { 0x0, 0x0, 0x0, 0x0, }; -static unsigned get_equivalent_processor_rev_id(unsigned orig_id) { - static unsigned id_mapping_table[] = { +struct id_mapping { + uint32_t orig_id; + uint16_t new_id; +}; + +static u16 get_equivalent_processor_rev_id(u32 orig_id) { + static const struct id_mapping id_mapping_table[] = { #if !CONFIG_K8_REV_F_SUPPORT - 0x0f48, 0x0048, - 0x0f58, 0x0048, - - 0x0f4a, 0x004a, - 0x0f5a, 0x004a, - 0x0f7a, 0x004a, - 0x0f82, 0x004a, - 0x0fc0, 0x004a, - 0x0ff0, 0x004a, - - 0x10f50, 0x0150, - 0x10f70, 0x0150, - 0x10f80, 0x0150, - 0x10fc0, 0x0150, - 0x10ff0, 0x0150, - - 0x20f10, 0x0210, - 0x20f12, 0x0210, - 0x20f32, 0x0210, - 0x20fb1, 0x0210, + { 0x0f48, 0x0048 }, + { 0x0f58, 0x0048 }, + + { 0x0f4a, 0x004a }, + { 0x0f5a, 0x004a }, + { 0x0f7a, 0x004a }, + { 0x0f82, 0x004a }, + { 0x0fc0, 0x004a }, + { 0x0ff0, 0x004a }, + + { 0x10f50, 0x0150 }, + { 0x10f70, 0x0150 }, + { 0x10f80, 0x0150 }, + { 0x10fc0, 0x0150 }, + { 0x10ff0, 0x0150 }, + + { 0x20f10, 0x0210 }, + { 0x20f12, 0x0210 }, + { 0x20f32, 0x0210 }, + { 0x20fb1, 0x0210 }, #endif #if CONFIG_K8_REV_F_SUPPORT - + /* FIXME */ #endif + /* Array terminator */ + { 0xffffff, 0x0000 }, + }; unsigned new_id; @@ -76,9 +85,9 @@ static unsigned get_equivalent_processor_rev_id(unsigned orig_id) { new_id = 0; - for(i=0; i<sizeof(id_mapping_table); i+=2 ) { - if(id_mapping_table[i]==orig_id) { - new_id = id_mapping_table[i+1]; + for (i = 0; id_mapping_table[i].orig_id != 0xffffff; i++ ) { + if (id_mapping_table[i].orig_id == orig_id) { + new_id = id_mapping_table[i].new_id; break; } }

1 0

Patch set updated for coreboot: 3bf6b0a asus/kfsn4-dre: Increase maximum logical CPUs for Istanbul devices
by Timothy Pearson 31 Jan '15

31 Jan '15

Timothy Pearson (tpearson(a)raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8311 -gerrit commit 3bf6b0a3485f9b0f1d70d029ca89e7080877f66a Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Fri Jan 30 23:48:52 2015 -0600 asus/kfsn4-dre: Increase maximum logical CPUs for Istanbul devices Test: Single Opteron 2419 with 1GB RAM in slot A1 Booted Ubuntu Linux 14.04 and verified all 6 cores were visible Brief stress test of all 6 cores simultaneously Verified proper ACPI power states for all 6 cores Change-Id: I1e598e36f9eaed5ba8a18b9c62ceedee16870f15 Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> --- src/mainboard/asus/kfsn4-dre/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mainboard/asus/kfsn4-dre/Kconfig b/src/mainboard/asus/kfsn4-dre/Kconfig index 245fecf..5779418 100644 --- a/src/mainboard/asus/kfsn4-dre/Kconfig +++ b/src/mainboard/asus/kfsn4-dre/Kconfig @@ -54,7 +54,7 @@ config PCI_64BIT_PREF_MEM config MAX_CPUS int - default 8 + default 12 config MAX_PHYSICAL_CPUS int

1 0

Patch set updated for coreboot: 033e770 amd/amdfam10: Update name table with Opteron 2400/8400 series codes
by Timothy Pearson 31 Jan '15

31 Jan '15

Timothy Pearson (tpearson(a)raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8309 -gerrit commit 033e7704705099e378b70a862f0e2bf94d2b35f3 Author: Timothy Pearson <tpearson(a)raptorengineeringinc.com> Date: Fri Jan 30 23:47:12 2015 -0600 amd/amdfam10: Update name table with Opteron 2400/8400 series codes Change-Id: I52587c0c0dffd814d39087475b8f14c500a68933 Signed-off-by: Timothy Pearson <tpearson(a)raptorengineeringinc.com> --- src/cpu/amd/model_10xxx/processor_name.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/cpu/amd/model_10xxx/processor_name.c b/src/cpu/amd/model_10xxx/processor_name.c index 40b73b0..11f4f8b 100644 --- a/src/cpu/amd/model_10xxx/processor_name.c +++ b/src/cpu/amd/model_10xxx/processor_name.c @@ -4,6 +4,7 @@ * Copyright (C) 2007 Advanced Micro Devices, Inc. * Copyright (C) 2008 Peter Stuge * Copyright (C) 2010 Marc Jones <marcj303(a)gmail.com> + * Copyright (C) 2015 Timothy Pearson <tpearson(a)raptorengineeringinc.com>, Raptor Engineering * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -51,6 +52,8 @@ static const struct str_s String1_socket_F[] = { {0x00, 0x01, 0x01, "Dual-Core AMD Opteron(tm) Processor 23"}, {0x00, 0x03, 0x00, "Quad-Core AMD Opteron(tm) Processor 83"}, {0x00, 0x03, 0x01, "Quad-Core AMD Opteron(tm) Processor 23"}, + {0x00, 0x05, 0x00, "Six-Core AMD Opteron(tm) Processor 84"}, + {0x00, 0x05, 0x01, "Six-Core AMD Opteron(tm) Processor 24"}, {0x00, 0x03, 0x02, "Embedded AMD Opteron(tm) Processor 83"}, {0x00, 0x03, 0x03, "Embedded AMD Opteron(tm) Processor 23"}, {0x00, 0x03, 0x04, "Embedded AMD Opteron(tm) Processor 13"}, @@ -60,6 +63,7 @@ static const struct str_s String1_socket_F[] = { }; static const struct str_s String2_socket_F[] = { + {0x00, 0xFF, 0x02, " EE"}, {0x00, 0xFF, 0x0A, " SE"}, {0x00, 0xFF, 0x0B, " HE"}, {0x00, 0xFF, 0x0C, " EE"},

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2015