the following patch was just integrated into master:
commit 728ff392e7aa11260675721e87c31c9070c1903f
Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
Date: Sat Aug 9 15:48:51 2014 +1000
cpu/amd/geode_lx/cache_as_ram.inc: Trivial - Fix indent with tabs
Change-Id: Ic65f8d2cbb5bc459cf513c6b34a5f1846cb2b897
Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
Reviewed-on: http://review.coreboot.org/6549
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick(a)georgi-clan.de>
See http://review.coreboot.org/6549 for details.
-gerrit
Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6564
-gerrit
commit 83d4d9a4762be3bcff667500d26071ecd3ee3fcb
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Sat Aug 9 17:44:39 2014 +0200
cbfstool: fix option parsing
"cbfstool create -B bootblock -s size" (in this order)
would break bootblock selection.
Change-Id: I9a9f5660827c8bf60dae81b519c6f026f3aaa0f3
Found-by: Coverity Scan
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
---
util/cbfstool/cbfstool.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c
index 73b1cf0..f236d8b 100644
--- a/util/cbfstool/cbfstool.c
+++ b/util/cbfstool/cbfstool.c
@@ -671,6 +671,7 @@ int main(int argc, char **argv)
if (tolower(suffix[0])=='m') {
param.size *= 1024 * 1024;
}
+ break;
case 'B':
param.bootblock = optarg;
break;
the following patch was just integrated into master:
commit ff0df2bba5f29dc992c0ab59b44337b7277c231a
Author: Stefan Reinauer <reinauer(a)chromium.org>
Date: Tue Sep 17 14:08:29 2013 -0700
Exynos5420: clean up SPI driver
That extra struct is not needed, we already defined it earlier on.
Also fix coding style in the file.
Signed-off-by: Stefan Reinauer <reinauer(a)google.com>
Change-Id: I586d290f2f3ba2f44aca7fdee400b88547465599
Reviewed-on: https://chromium-review.googlesource.com/169780
Reviewed-by: Stefan Reinauer <reinauer(a)google.com>
Commit-Queue: Stefan Reinauer <reinauer(a)google.com>
Tested-by: Stefan Reinauer <reinauer(a)google.com>
(cherry picked from commit f7df9f05fb707cac7976cd8a0b36bcf30cef8e0f)
Signed-off-by: Isaac Christensen <isaac.christensen(a)se-eng.com>
Reviewed-on: http://review.coreboot.org/6532
Tested-by: build bot (Jenkins)
Reviewed-by: David Hendricks <dhendrix(a)chromium.org>
Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
See http://review.coreboot.org/6532 for details.
-gerrit
the following patch was just integrated into master:
commit 2f6b0a9a4b7dd7c6b04c6f17f024db8643afde5f
Author: Vadim Bendebury <vbendeb(a)chromium.org>
Date: Wed Oct 16 18:23:25 2013 -0700
Set check-lxdialog.sh mode properly
This script is used by 'make menuconfig', but being non executable it
fails to run, causing the make invocation failure.
Setting 'x' mode bits fixes the problem.
Change-Id: I925ca4ee056937b6c38ad34f5520fd621f9d9eb0
Signed-off-by: Vadim Bendebury <vbendeb(a)chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/173564
Reviewed-by: Stefan Reinauer <reinauer(a)google.com>
Commit-Queue: Stefan Reinauer <reinauer(a)google.com>
(cherry picked from commit 3ddb9d221ecc3df968853d765b566cf0648a7525)
Signed-off-by: Isaac Christensen <isaac.christensen(a)se-eng.com>
Reviewed-on: http://review.coreboot.org/6540
Tested-by: build bot (Jenkins)
See http://review.coreboot.org/6540 for details.
-gerrit
the following patch was just integrated into master:
commit 6ed2a242ee800201a98456cafce7f6232c30816c
Author: Daniele Forsi <dforsi(a)gmail.com>
Date: Wed Jul 30 14:16:07 2014 +0200
intel/eagleheights/Kconfig: Do not set twice MMCONF_BASE_ADDRESS
Remove the lines added in an apparently unrelated commit 53ad9f58 (Make CONFIG_HAVE_HIGH_TABLES consistent in where and how it is set.)
which touched the symbol HAVE_HIGH_TABLES in all files except this one and
keep those added the same day in commit 6842c029 (Remove MAINBOARD_OPTIONS, which is a relic from early kconfig development.)
Change-Id: Ib055c25a0a0795a50a36e65218c8f31e921f1502
Signed-off-by: Daniele Forsi <dforsi(a)gmail.com>
Reviewed-on: http://review.coreboot.org/6417
Tested-by: build bot (Jenkins)
Reviewed-by: Isaac Christensen <isaac.christensen(a)se-eng.com>
Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
See http://review.coreboot.org/6417 for details.
-gerrit
Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6563
-gerrit
commit 7126490e24846ccaefc2beab01f6fc453f5b3ff7
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Sat Aug 9 17:16:24 2014 +0200
src/lib/edid.c: missing break statement
While vendor specific extension blocks are mostly opaque to us,
they're not exactly "unknown".
Change-Id: I9136c04d12045ad13ef4f942c0814c4df88bdf6b
Found-by: Coverity Scan
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
---
src/lib/edid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/edid.c b/src/lib/edid.c
index 623081e..5c2d964 100644
--- a/src/lib/edid.c
+++ b/src/lib/edid.c
@@ -905,7 +905,7 @@ parse_extension(struct edid *out, unsigned char *x)
case 0x50: printk(BIOS_SPEW, "LS extension block\n"); break;
case 0x60: printk(BIOS_SPEW, "DPVL extension block\n"); break;
case 0xF0: printk(BIOS_SPEW, "Block map\n"); break;
- case 0xFF: printk(BIOS_SPEW, "Manufacturer-specific extension block\n");
+ case 0xFF: printk(BIOS_SPEW, "Manufacturer-specific extension block\n"); break;
default:
printk(BIOS_SPEW, "Unknown extension block\n");
break;
Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6562
-gerrit
commit 222a25bd891bd28c824b714b8a4f8239222a15a4
Author: Patrick Georgi <patrick(a)georgi-clan.de>
Date: Sat Aug 9 17:12:23 2014 +0200
ifdtool: Provide bounds on string parser
While the result will not be pretty (ie. ifdtool will
mis-parse string components longer than 255 characters),
at least it doesn't overflow stack variables anymore.
Change-Id: I263c5cf823a2d8a863dcece7c4ee0b26475f9fc4
Found-by: Coverity Scan
Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de>
---
util/ifdtool/ifdtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c
index c478550..625d650 100644
--- a/util/ifdtool/ifdtool.c
+++ b/util/ifdtool/ifdtool.c
@@ -761,7 +761,7 @@ void new_layout(char *filename, char *image, int size, char *layout_fname)
while (!feof(romlayout)) {
char *tstr1, *tstr2;
- if (2 != fscanf(romlayout, "%s %s\n", tempstr,
+ if (2 != fscanf(romlayout, "%255s %255s\n", tempstr,
layout_region_name))
continue;