coreboot-gerrit August 2014

coreboot-gerrit@coreboot.org

1 participants
1011 discussions

Patch merged into coreboot/master: e887ca5 cbfstool: fix option parsing
by gerrit＠coreboot.org 09 Aug '14

09 Aug '14

the following patch was just integrated into master: commit e887ca5a745720e3d35527e4fd4e21b8c0b3b3b9 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Sat Aug 9 17:44:39 2014 +0200 cbfstool: fix option parsing "cbfstool create -B bootblock -s size" (in this order) would break bootblock selection. Change-Id: I9a9f5660827c8bf60dae81b519c6f026f3aaa0f3 Found-by: Coverity Scan Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> Reviewed-on: http://review.coreboot.org/6564 Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> Tested-by: build bot (Jenkins) See http://review.coreboot.org/6564 for details. -gerrit

1 0

New patch to review for coreboot: 9b1adf6 intel/fsp_bd82x6x: Fix cycle error some more
by Patrick Georgi 09 Aug '14

09 Aug '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6569 -gerrit commit 9b1adf617c9fa45893b9231f9a52be7a066473cf Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Sat Aug 9 19:50:15 2014 +0200 intel/fsp_bd82x6x: Fix cycle error some more As a follow up to #6479 (63e1948643fcbd763c83b6baa6cd9a077d49f1fc), fix the remaining faulty loop. Change-Id: I2c77efe620c71e939f4d74e48f90a166c782e5f5 Found-by: Coverity Scan Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- src/southbridge/intel/fsp_bd82x6x/smi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/southbridge/intel/fsp_bd82x6x/smi.c b/src/southbridge/intel/fsp_bd82x6x/smi.c index 97d0ce4..d035c63 100644 --- a/src/southbridge/intel/fsp_bd82x6x/smi.c +++ b/src/southbridge/intel/fsp_bd82x6x/smi.c @@ -132,7 +132,7 @@ static void dump_gpe0_status(u32 gpe0_sts) { int i; printk(BIOS_DEBUG, "GPE0_STS: "); - for (i=31; i<= 16; i--) { + for (i=31; i>= 16; i--) { if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16)); } if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 ");

1 0

New patch to review for coreboot: b13685f romcc: properly check out-of-range unsigned longs
by Patrick Georgi 09 Aug '14

09 Aug '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6568 -gerrit commit b13685f07234b4452e0f62615b782a6dda3cf708 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Sat Aug 9 19:42:08 2014 +0200 romcc: properly check out-of-range unsigned longs Testing if an unsigned long is greater than ULONG_T_MAX isn't very useful. The second half of the test checked for too small values (ie. <= -ULONG_T_MAX). In both cases errno is set to ERANGE, so just check for that. Change-Id: I92bad9d1715673531bef5d5d5756feddeb7674b4 Found-by: Coverity Scan Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- util/romcc/romcc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/romcc/romcc.c b/util/romcc/romcc.c index 84270bb..49b4dd4 100644 --- a/util/romcc/romcc.c +++ b/util/romcc/romcc.c @@ -10797,8 +10797,8 @@ static struct triple *integer_constant(struct compile_state *state) errno = 0; decimal = (tk->val.str[0] != '0'); val = strtoul(tk->val.str, &end, 0); - if ((val > ULONG_T_MAX) || ((val == ULONG_MAX) && (errno == ERANGE))) { - error(state, 0, "Integer constant to large"); + if (errno == ERANGE) { + error(state, 0, "Integer constant out of range"); } u = l = 0; if ((*end == 'u') || (*end == 'U')) {

1 0

Patch merged into coreboot/master: a0a0196 cpu/amd/geode_lx: Trivial - remove useless comment
by gerrit＠coreboot.org 09 Aug '14

09 Aug '14

the following patch was just integrated into master: commit a0a019698d29a869eaf299cadcfda11e331f995f Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Sun Aug 10 02:09:13 2014 +1000 cpu/amd/geode_lx: Trivial - remove useless comment Change-Id: I4b04f84fb2be7da4b7ffab71bb2c41142f455440 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Reviewed-on: http://review.coreboot.org/6567 Reviewed-by: Patrick Georgi <patrick(a)georgi-clan.de> Tested-by: build bot (Jenkins) See http://review.coreboot.org/6567 for details. -gerrit

1 0

New patch to review for coreboot: 7ed849a cpu/amd/geode_lx: Trivial - remove useless comment
by Edward O'Callaghan 09 Aug '14

09 Aug '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6567 -gerrit commit 7ed849adb802e05f751733cadf85b0e0bbf9a9c8 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Sun Aug 10 02:09:13 2014 +1000 cpu/amd/geode_lx: Trivial - remove useless comment Change-Id: I4b04f84fb2be7da4b7ffab71bb2c41142f455440 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/cpu/amd/geode_lx/cpureginit.c | 1 - src/cpu/amd/geode_lx/syspreinit.c | 1 - 2 files changed, 2 deletions(-) diff --git a/src/cpu/amd/geode_lx/cpureginit.c b/src/cpu/amd/geode_lx/cpureginit.c index 79e0a70..282fa7e 100644 --- a/src/cpu/amd/geode_lx/cpureginit.c +++ b/src/cpu/amd/geode_lx/cpureginit.c @@ -163,7 +163,6 @@ static void SetDelayControl(u8 dimm0, u8 dimm1, int terminated) wrmsr(GLCP_DELAY_CONTROLS, msr); } -/* cpuRegInit */ void cpuRegInit(int debug_clock_disable, u8 dimm0, u8 dimm1, int terminated) { int msrnum; diff --git a/src/cpu/amd/geode_lx/syspreinit.c b/src/cpu/amd/geode_lx/syspreinit.c index 1dcaebb..dfdd67f 100644 --- a/src/cpu/amd/geode_lx/syspreinit.c +++ b/src/cpu/amd/geode_lx/syspreinit.c @@ -35,7 +35,6 @@ static void StartTimer1(void) void SystemPreInit(void) { - /* they want a jump ... */ #if !CONFIG_CACHE_AS_RAM __asm__ __volatile__("jmp .+2\ninvd\njmp .+2\n");

1 0

Patch merged into coreboot/master: 1882527 ivybridge: Don't propose to include systemagent on native boards.
by gerrit＠coreboot.org 09 Aug '14

09 Aug '14

the following patch was just integrated into master: commit 1882527399ab835bc24cb44b08774c3f101c4396 Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Sat Aug 9 18:07:42 2014 +0200 ivybridge: Don't propose to include systemagent on native boards. Change-Id: Ib70a6741b55609840b6fd2fca16bcf9883bf143c Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> Reviewed-on: http://review.coreboot.org/6566 Reviewed-by: Patrick Georgi <patrick(a)georgi-clan.de> Tested-by: build bot (Jenkins) See http://review.coreboot.org/6566 for details. -gerrit

1 0

Patch merged into coreboot/master: 8a57b39 lenovo/x201: Enable wake on LID and Fn key.
by gerrit＠coreboot.org 09 Aug '14

09 Aug '14

the following patch was just integrated into master: commit 8a57b3922342bbe4557a9efcd05125dd18c79e84 Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Fri Aug 8 00:10:28 2014 +0200 lenovo/x201: Enable wake on LID and Fn key. Change-Id: I485da5b8e9084c73f16b5df1c42879697fc0ac3d Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> Reviewed-on: http://review.coreboot.org/6528 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> See http://review.coreboot.org/6528 for details. -gerrit

1 0

New patch to review for coreboot: 064691a ivybridge: Don't propose to include systemagent on native boards.
by Vladimir Serbinenko 09 Aug '14

09 Aug '14

Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6566 -gerrit commit 064691a018e8f16b95fb9e4bfd5d0a4d39284fed Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Sat Aug 9 18:07:42 2014 +0200 ivybridge: Don't propose to include systemagent on native boards. Change-Id: Ib70a6741b55609840b6fd2fca16bcf9883bf143c Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> --- src/northbridge/intel/sandybridge/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/src/northbridge/intel/sandybridge/Kconfig b/src/northbridge/intel/sandybridge/Kconfig index 883d36f..cccc09e 100644 --- a/src/northbridge/intel/sandybridge/Kconfig +++ b/src/northbridge/intel/sandybridge/Kconfig @@ -79,6 +79,7 @@ config DCACHE_RAM_MRC_VAR_SIZE config HAVE_MRC bool "Add a System Agent binary" + depends on !NORTHBRIDGE_INTEL_IVYBRIDGE_NATIVE help Select this option to add a System Agent binary to the resulting coreboot image.

1 0

Patch merged into coreboot/master: 309a7ff southbridge/amd/cs5536: Trivial style fix for trailing comment
by gerrit＠coreboot.org 09 Aug '14

09 Aug '14

the following patch was just integrated into master: commit 309a7ffc6624f4fad4d7904c78c1a4d35a84bbcf Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Sat Aug 9 21:38:56 2014 +1000 southbridge/amd/cs5536: Trivial style fix for trailing comment Change-Id: Ia3a846497c220866e950a4b0bb53cb05c0e0cee2 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Reviewed-on: http://review.coreboot.org/6557 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <patrick(a)georgi-clan.de> See http://review.coreboot.org/6557 for details. -gerrit

1 0

Patch merged into coreboot/master: cd2c124 cpu/amd/geode_lx: Reduce fancy ASCII art with embedded comments
by gerrit＠coreboot.org 09 Aug '14

09 Aug '14

the following patch was just integrated into master: commit cd2c1245f03c9f23192b499a3995cf794663dc02 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Sat Aug 9 15:51:19 2014 +1000 cpu/amd/geode_lx: Reduce fancy ASCII art with embedded comments Lets try not to play games with the Lexer with fancy ASCII art. Doxygen has a more well defined and useful syntax for annotations. Change-Id: I6f6c58971f509064ae1e28a1740e50e2ae721513 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Reviewed-on: http://review.coreboot.org/6550 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <patrick(a)georgi-clan.de> See http://review.coreboot.org/6550 for details. -gerrit

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2014