coreboot-gerrit May 2014

coreboot-gerrit@coreboot.org

1 participants
1066 discussions

Patch merged into coreboot/master: 58d6e18 rambi: disable SERIRQ native functionality
by gerrit＠coreboot.org 15 May '14

15 May '14

the following patch was just integrated into master: commit 58d6e18f0c963832ebfc3ad1aad48cfe1d65fd8a Author: Aaron Durbin <adurbin(a)chromium.org> Date: Fri Jan 10 11:48:45 2014 -0600 rambi: disable SERIRQ native functionality Nothing can actually use this as the EC cannot speak using baytrail's SERIRQ protocol. Also, the voltage bridge is going away so nothing will be hooked up to it. Therefore disable this it. BUG=chrome-os-partner:24693 BRANCH=rambi TEST=Built and booted. Change-Id: I406bb9c227578ec0a75eaf67143b3b27cb7880ae Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: https://chromium-review.googlesource.com/182082 Reviewed-by: Shawn Nematbakhsh <shawnn(a)chromium.org> Reviewed-on: http://review.coreboot.org/5042 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <patrick(a)georgi-clan.de> See http://review.coreboot.org/5042 for details. -gerrit

1 0

Patch merged into coreboot/master: f24318d southbridge/amd/cimx/sb800: Unused func smbus_delay()
by gerrit＠coreboot.org 14 May '14

14 May '14

the following patch was just integrated into master: commit f24318dfb631e05db83b2e676f34b2e3cfb3dd6d Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Thu May 15 05:15:04 2014 +1000 southbridge/amd/cimx/sb800: Unused func smbus_delay() Change-Id: Icc12aafc1462c08bca77a1798d4fae86b8250708 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Reviewed-on: http://review.coreboot.org/5748 Reviewed-by: Patrick Georgi <patrick(a)georgi-clan.de> Tested-by: build bot (Jenkins) See http://review.coreboot.org/5748 for details. -gerrit

1 0

New patch to review for coreboot: a77ce69 vendorcode/amd/agesa, cimx: Integer comparisons always true
by Edward O'Callaghan 14 May '14

14 May '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5749 -gerrit commit a77ce69910863ac762ee058451c942b8e24cb0e7 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Thu May 15 05:23:09 2014 +1000 vendorcode/amd/agesa,cimx: Integer comparisons always true Change-Id: I6a3f36cd7e4f2cf26a72f3e849fed0b2da691d1d Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/vendorcode/amd/agesa/f14/Lib/amdlib.c | 2 +- src/vendorcode/amd/cimx/sb800/SATA.c | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/vendorcode/amd/agesa/f14/Lib/amdlib.c b/src/vendorcode/amd/agesa/f14/Lib/amdlib.c index 31b3f1e..d103598 100644 --- a/src/vendorcode/amd/agesa/f14/Lib/amdlib.c +++ b/src/vendorcode/amd/agesa/f14/Lib/amdlib.c @@ -348,7 +348,7 @@ LibAmdBitScanReverse ( IN UINT32 value ) { - UINTN Index; + int Index; for (Index = 31; Index >= 0; Index--){ if (value & (1 << Index)) break; } diff --git a/src/vendorcode/amd/cimx/sb800/SATA.c b/src/vendorcode/amd/cimx/sb800/SATA.c index a301208..c2f2162 100644 --- a/src/vendorcode/amd/cimx/sb800/SATA.c +++ b/src/vendorcode/amd/cimx/sb800/SATA.c @@ -17,7 +17,7 @@ * * Copyright (c) 2011, Advanced Micro Devices, Inc. * All rights reserved. - * + * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are met: * * Redistributions of source code must retain the above copyright @@ -25,10 +25,10 @@ * * Redistributions in binary form must reproduce the above copyright * notice, this list of conditions and the following disclaimer in the * documentation and/or other materials provided with the distribution. - * * Neither the name of Advanced Micro Devices, Inc. nor the names of - * its contributors may be used to endorse or promote products derived + * * Neither the name of Advanced Micro Devices, Inc. nor the names of + * its contributors may be used to endorse or promote products derived * from this software without specific prior written permission. - * + * * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE @@ -39,7 +39,7 @@ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - * + * * *************************************************************************** * */ @@ -568,7 +568,7 @@ sataDriveDetection ( UINT8 dbPortNum; UINT8 dbVar0; UINT16 dwIoBase; - UINT16 dwVar0; + UINT32 dwVar0; if ( (pConfig->SataClass == NATIVE_IDE_MODE) || (pConfig->SataClass == LEGACY_IDE_MODE) || (pConfig->SataClass == IDE_TO_AHCI_MODE) ) { for ( dbPortNum = 0; dbPortNum < 4; dbPortNum++ ) { ReadMEM (*pBar5 + SB_SATA_BAR5_REG128 + dbPortNum * 0x80, AccWidthUint32, &ddVar0);

1 0

New patch to review for coreboot: 5d3e072 southbridge/amd/cimx/sb800: Unused func smbus_delay()
by Edward O'Callaghan 14 May '14

14 May '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5748 -gerrit commit 5d3e0722d5a854b6773631128bb1413c0430ba9b Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Thu May 15 05:15:04 2014 +1000 southbridge/amd/cimx/sb800: Unused func smbus_delay() Change-Id: Icc12aafc1462c08bca77a1798d4fae86b8250708 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/southbridge/amd/cimx/sb800/smbus.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/southbridge/amd/cimx/sb800/smbus.c b/src/southbridge/amd/cimx/sb800/smbus.c index 9ec4eb2..6ab85bd 100644 --- a/src/southbridge/amd/cimx/sb800/smbus.c +++ b/src/southbridge/amd/cimx/sb800/smbus.c @@ -22,11 +22,6 @@ #include "smbus.h" #include <console/console.h> /* printk */ -static inline void smbus_delay(void) -{ - outb(inb(0x80), 0x80); -} - static int smbus_wait_until_ready(u32 smbus_io_base) { u32 loops;

1 0

Patch set updated for coreboot: f35ed82 build system: re-enable clang use
by Patrick Georgi 14 May '14

14 May '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5747 -gerrit commit f35ed826e4b1ab4c949e7744c1e4fb26649c2c70 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Wed May 14 21:05:35 2014 +0200 build system: re-enable clang use Change-Id: I6e07fdec449d0b259d77986f65a60aa36d367cc8 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- Makefile | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index c9648c0..9a96992 100644 --- a/Makefile +++ b/Makefile @@ -117,15 +117,19 @@ else include $(HAVE_DOTCONFIG) -include toolchain.inc - ifneq ($(INNER_SCANBUILD),y) ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y) -CC:=clang -m32 -mno-mmx -mno-sse -no-integrated-as +# FIXME: CC_* contains more than one word and quotes don't work either +# armv7/aarch64 won't build right now +CC_i386:=clang -target i386-elf -m32 -mno-mmx -mno-sse -no-integrated-as +CC_armv7:=clang -target armv7-eabi -no-integrated-as -ccc-gcc-name $(CC_armv7) +CC_aarch64:=clang -target aarch64-eabi -no-integrated-as -ccc-gcc-name $(CC_aarch64) HOSTCC:=clang endif endif +include toolchain.inc + ifeq ($(CONFIG_CCACHE),y) CCACHE:=$(word 1,$(wildcard $(addsuffix /ccache,$(subst :, ,$(PATH))))) ifeq ($(CCACHE),)

1 0

New patch to review for coreboot: 3aecc3b build system: re-enable clang use
by Patrick Georgi 14 May '14

14 May '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5747 -gerrit commit 3aecc3be6da8d1e51311bb08aebf667e6f787742 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Wed May 14 21:05:35 2014 +0200 build system: re-enable clang use Change-Id: I6e07fdec449d0b259d77986f65a60aa36d367cc8 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- Makefile | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index c9648c0..f59a494 100644 --- a/Makefile +++ b/Makefile @@ -117,15 +117,17 @@ else include $(HAVE_DOTCONFIG) -include toolchain.inc - ifneq ($(INNER_SCANBUILD),y) ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y) -CC:=clang -m32 -mno-mmx -mno-sse -no-integrated-as +CC_i386:=clang -m32 -mno-mmx -mno-sse -no-integrated-as -ccc-gcc-name "$(CC_i386)" +CC_armv7:=clang -no-integrated-as -ccc-gcc-name "$(CC_armv7)" +CC_arch64:=clang -no-integrated-as -ccc-gcc-name "$(CC_aarch64)" HOSTCC:=clang endif endif +include toolchain.inc + ifeq ($(CONFIG_CCACHE),y) CCACHE:=$(word 1,$(wildcard $(addsuffix /ccache,$(subst :, ,$(PATH))))) ifeq ($(CCACHE),)

1 0

New patch to review for coreboot: 315dc78 xcompile: ABIs are really architecture specific
by Patrick Georgi 14 May '14

14 May '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5746 -gerrit commit 315dc78f894bec7c005e73c5371d449e209211c9 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Wed May 14 14:48:31 2014 +0200 xcompile: ABIs are really architecture specific no need to test for i386-eabi or armv7a-elf Change-Id: Icbef5a64f5b793092ca0f94ee8f54bc896bf39ad Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- util/xcompile/xcompile | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index 239c233..0ac2bec 100644 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -169,6 +169,7 @@ arch_config_armv7() { TBFDARCH="littlearm" TCLIST="armv7a armv7-a" TWIDTH="32" + TABI="eabi" } arch_config_aarch64() { @@ -176,6 +177,7 @@ arch_config_aarch64() { TBFDARCH="littleaarch64" TCLIST="aarch64" TWIDTH="64" + TABI="eabi" } arch_config_x86() { @@ -183,6 +185,7 @@ arch_config_x86() { TBFDARCH="i386" TCLIST="i386 x86_64" TWIDTH="32" + TABI="elf" } test_architecture() { @@ -203,11 +206,9 @@ test_architecture() { search="$(eval echo \$CROSS_COMPILE_$architecture 2>/dev/null)" search="$search $CROSS_COMPILE" for toolchain in $TCLIST; do - search="$search $XGCCPATH$toolchain-elf-" - search="$search $toolchain-elf-" + search="$search $XGCCPATH$toolchain-$TABI-" + search="$search $toolchain-$TABI-" search="$search $toolchain-linux-gnu-" - search="$search $XGCCPATH$toolchain-eabi-" - search="$search $toolchain-eabi-" done echo "# $architecture TARCH_SEARCH=$search"

1 0

New patch to review for coreboot: a7e47c7 xcompile: break out big loop content into function
by Patrick Georgi 14 May '14

14 May '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5745 -gerrit commit a7e47c7558a4cdd572b1a9cf7f0fa62089f3deb3 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Wed May 14 14:32:11 2014 +0200 xcompile: break out big loop content into function Change-Id: Id98afa956a2af7113a6ef848b436d661a1fa39f2 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- util/xcompile/xcompile | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index cb27306..239c233 100644 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -185,8 +185,9 @@ arch_config_x86() { TWIDTH="32" } -# This loops over all supported architectures. -for architecture in $SUPPORTED_ARCHITECTURE; do +test_architecture() { + architecture=$1 + GCCPREFIX="invalid" if type arch_config_$architecture > /dev/null; then arch_config_$architecture @@ -225,5 +226,10 @@ for architecture in $SUPPORTED_ARCHITECTURE; do detect_special_flags "$architecture" report_arch_toolchain +} + +# This loops over all supported architectures. +for architecture in $SUPPORTED_ARCHITECTURE; do + test_architecture $architecture done

1 0

New patch to review for coreboot: 77b32f3 xcompile: move tempfile cleanup closer together
by Patrick Georgi 14 May '14

14 May '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5744 -gerrit commit 77b32f3236edc63200f65d7cee2b131b4ca6acc5 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Wed May 14 14:30:08 2014 +0200 xcompile: move tempfile cleanup closer together Change-Id: I4fb3041d505402de3cbcd7ec079dde5e168a90cf Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- util/xcompile/xcompile | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index e256c0d..cb27306 100644 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -33,6 +33,12 @@ clean_up() { fi } +# Create temporary file(s). +TMPFILE="$(mktemp /tmp/temp.XXXX 2>/dev/null || echo /tmp/temp.78gOIUGz)" +touch "$TMPFILE" +trap clean_up EXIT + + program_exists() { type "$1" >/dev/null 2>&1 } @@ -155,11 +161,6 @@ AR_${TARCH}:=${GCCPREFIX}ar EOF } -# Create temporary file(s). -TMPFILE="$(mktemp /tmp/temp.XXXX 2>/dev/null || echo /tmp/temp.78gOIUGz)" -touch "$TMPFILE" -trap clean_up EXIT - # Architecture definition SUPPORTED_ARCHITECTURE="x86 armv7 aarch64"

1 0

New patch to review for coreboot: 38ae9dd xcompile: actually use "special compile flags" idea
by Patrick Georgi 14 May '14

14 May '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5743 -gerrit commit 38ae9dd381141aa0e865c0fb74ce2aef569ea698 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Wed May 14 14:28:21 2014 +0200 xcompile: actually use "special compile flags" idea xcompile used to test for special ARM flags - that were empty. Meanwhile, -Wa,--divide, which is only useful on i386-elf was tested for on arm and aarch64, too Change-Id: I1a5a1bc40fa1040d0939038b073aef31c72d0c6f Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- util/xcompile/xcompile | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index 81d5b3c..e256c0d 100644 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -125,22 +125,16 @@ detect_special_flags() { testcc "$CC" "$CFLAGS -fuse-ld=bfd" && CFLAGS="$CFLAGS -fuse-ld=bfd" && LINKER_SUFFIX='.bfd' - testcc "$CC" "$CFLAGS -Wa,--divide" && - CFLAGS="$CFLAGS -Wa,--divide" testcc "$CC" "$CFLAGS -fno-stack-protector"&& CFLAGS="$CFLAGS -fno-stack-protector" testcc "$CC" "$CFLAGS -Wl,--build-id=none" && CFLAGS="$CFLAGS -Wl,--build-id=none" case "$architecture" in - armv7 ) - ARMFLAGS="" - testcc "$CC" "$CFLAGS $ARMFLAGS"&&CFLAGS="$CFLAGS $ARMFLAGS" - ;; - aarch64 ) - ARMFLAGS="" - testcc "$CC" "$CFLAGS $ARMFLAGS"&&CFLAGS="$CFLAGS $ARMFLAGS" - ;; + x86) + testcc "$CC" "$CFLAGS -Wa,--divide" && + CFLAGS="$CFLAGS -Wa,--divide" + ;; esac }

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2014