coreboot-gerrit May 2014

coreboot-gerrit@coreboot.org

1 participants
1066 discussions

New patch to review for coreboot: 37c709c build: allow romcc to be wrapped
by Patrick Georgi 17 May '14

17 May '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5773 -gerrit commit 37c709c7a380ffeade52790e6e51d7e1cf317a52 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Sat May 17 19:05:56 2014 +0200 build: allow romcc to be wrapped Allow ccache and scan-build to wrap romcc. This works a bit different from the other compilers because we only define it later. Change-Id: I3adce91d3dde9dd50aa6a2baad5b457744f35575 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- Makefile.inc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Makefile.inc b/Makefile.inc index d098cff..529250d 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -280,8 +280,11 @@ ifeq ($(_WINCHECK),Cygwin) STACK=-Wl,--stack,16384000 endif -ROMCC:= $(objutil)/romcc/romcc -$(ROMCC): $(top)/util/romcc/romcc.c +# this allows ccache to prepend itself +# (ccache handling happens first) +ROMCC_BIN= $(objutil)/romcc/romcc +ROMCC?=$(ROMCC_BIN) +$(ROMCC_BIN): $(top)/util/romcc/romcc.c @printf " HOSTCC $(subst $(obj)/,,$(@)) (this may take a while)\n" @# Note: Adding -O2 here might cause problems. For details see: @# http://www.coreboot.org/pipermail/coreboot/2010-February/055825.html

1 0

New patch to review for coreboot: b9f81ed abuild: replace hardcoded values by their variables
by Patrick Georgi 17 May '14

17 May '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5772 -gerrit commit b9f81eda063d8b00dee6316231cab65864512cd2 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Sat May 17 18:24:45 2014 +0200 abuild: replace hardcoded values by their variables Some coreboot-builds/ and makes made their way into abuild. Stop them. Change-Id: I5784e1fd623ada30e2fadcc74a7da3ee75c5ee96 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- util/abuild/abuild | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/util/abuild/abuild b/util/abuild/abuild index c08f4a2..434bcc6 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -545,9 +545,9 @@ build_all_targets() if [ "$enable_blobs" = "true" ]; then echo "CONFIG_USE_BLOBS=y" > $TMPCFG fi - make -j $cpus DOTCONFIG=$TMPCFG obj=coreboot-builds/temp objutil=coreboot-builds/sharedutils allnoconfig - make -j $cpus DOTCONFIG=$TMPCFG obj=coreboot-builds/temp objutil=coreboot-builds/sharedutils tools || exit 1 - rm -rf coreboot-builds/temp $TMPCFG + $MAKE -j $cpus DOTCONFIG=$TMPCFG obj=$TARGET/temp objutil=$TARGET/sharedutils allnoconfig + $MAKE -j $cpus DOTCONFIG=$TMPCFG obj=$TARGET/temp objutil=$TARGET/sharedutils tools || exit 1 + rm -rf $TARGET/temp $TMPCFG for VENDOR in $( vendors ); do for MAINBOARD in $( mainboards $VENDOR ); do echo $VENDOR/$MAINBOARD

1 0

Patch set updated for coreboot: 04ba35f build: remove call to missing function
by Patrick Georgi 17 May '14

17 May '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5770 -gerrit commit 04ba35f78d37b0e95a9728fc32a5a6f902c3a97d Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Sat May 17 15:13:40 2014 +0200 build: remove call to missing function set_stage_libgcc never existed in our tree. Change-Id: I864fc683dd7b89a030daf05eafb9624ce828cb72 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- toolchain.inc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/toolchain.inc b/toolchain.inc index 568b3d6..9417a73 100644 --- a/toolchain.inc +++ b/toolchain.inc @@ -70,8 +70,7 @@ endef # @1 : stage for which the toolchain is to be initialized init_standard_toolchain = \ $(eval $(call set_stage_toolchain,$(1))) \ - $(eval $(call create_class_compiler,$(1),$(ARCH-$(1)-y))) \ - $(eval $(call set_stage_libgcc,$(1))) + $(eval $(call create_class_compiler,$(1),$(ARCH-$(1)-y))) init_stages = \ $(foreach stage,$(COREBOOT_STANDARD_STAGES),$(eval $(call init_standard_toolchain,$(stage))))

1 0

Patch set updated for coreboot: 946b86b build: break compiler flags out of $(CC)
by Patrick Georgi 17 May '14

17 May '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5769 -gerrit commit 946b86beecfed3aa3636a3fc893729d6784edb0f Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Sat May 17 15:08:47 2014 +0200 build: break compiler flags out of $(CC) Having more than the executable in $(CC) only leads to trouble in a number of situations. Change-Id: I7642ca4068b3a3bd5798219d74de9e0eb85bb4e5 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- src/arch/x86/Makefile.inc | 2 +- toolchain.inc | 4 ++-- util/xcompile/xcompile | 3 ++- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc index 30f9243..6c7008c 100644 --- a/src/arch/x86/Makefile.inc +++ b/src/arch/x86/Makefile.inc @@ -28,7 +28,7 @@ subdirs-y += lib subdirs-y += smp ifeq ($(CONFIG_COMPILER_GCC),y) -DISASSEMBLY=-Wa,-acdlns +DISASSEMBLY=-Wa,-acdlns $(CFLAGS_x86_32) else DISASSEMBLY= endif diff --git a/toolchain.inc b/toolchain.inc index b615bce..568b3d6 100644 --- a/toolchain.inc +++ b/toolchain.inc @@ -25,7 +25,7 @@ ARCHDIR-i386 := x86 ARCHDIR-x86_32 := x86 ARCHDIR-armv7 := armv7 -CFLAGS_armv7 = \ +CFLAGS_armv7 += \ -ffixed-r8\ -march=armv7-a\ -marm\ @@ -35,7 +35,7 @@ CFLAGS_armv7 = \ toolchain_to_dir = \ $(foreach arch,$(ARCH_SUPPORTED),\ - $(eval CPPFLAGS_$(arch) = \ + $(eval CPPFLAGS_$(arch) += \ -Isrc/arch/$(ARCHDIR-$(arch))/include)) # set_stage_toolchain: Decides the toolchain to be used by every stage diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index b342de3..d133bd2 100644 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -147,7 +147,8 @@ detect_special_flags() { report_arch_toolchain() { cat <<EOF # elf${TWIDTH}-${TBFDARCH} toolchain (${GCCPREFIX}gcc) -CC_${TARCH}:=${GCCPREFIX}gcc ${CFLAGS} +CC_${TARCH}:=${GCCPREFIX}gcc +CFLAGS_${TARCH}:=${CFLAGS} CPP_${TARCH}:=${GCCPREFIX}cpp AS_${TARCH}:=${GCCPREFIX}as ${ASFLAGS} LD_${TARCH}:=${GCCPREFIX}ld${LINKER_SUFFIX} ${LDFLAGS}

1 0

Patch set updated for coreboot: c8cf677 build: don't call $(CC) -print-libgcc-file-name twice
by Patrick Georgi 17 May '14

17 May '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5768 -gerrit commit c8cf677f913d1d2e3a98f153187a45b2e7d8d614 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Sat May 17 14:52:28 2014 +0200 build: don't call $(CC) -print-libgcc-file-name twice Change-Id: Iaeeb8fc58e06c98273520e79999737da9ff3f872 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- toolchain.inc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/toolchain.inc b/toolchain.inc index d998a7e..b615bce 100644 --- a/toolchain.inc +++ b/toolchain.inc @@ -63,8 +63,7 @@ STRIP_$(1) := $(STRIP_$(2)) READELF_$(1) := $(READELF_$(2)) CFLAGS_$(1) = $$(CFLAGS_common) $$(CFLAGS_$(2)) CPPFLAGS_$(1) = $$(CPPFLAGS_common) $$(CPPFLAGS_$(2)) -LIBGCC_FILE_NAME_$(1) = $(shell [ -r `$(CC_$(2)) -print-libgcc-file-name` ] && \ - $(CC_$(2)) -print-libgcc-file-name) +LIBGCC_FILE_NAME_$(1) = $(wildcard $(shell $(CC_$(2)) -print-libgcc-file-name)) endef # initialize standard toolchain (CC,AS and others) for give stage

1 0

Patch set updated for coreboot: 55880ca build: kill one indirection
by Patrick Georgi 17 May '14

17 May '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5767 -gerrit commit 55880cad96e4253c36d0cd5981cf716756613020 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Sat May 17 14:02:08 2014 +0200 build: kill one indirection No need to first define X86_32 and then replace every single use of it with its lower cased equivalent. Just start out with the lower case versions in the first place. Change-Id: I1e771ef443db1b8d34018d19a64a9ee489cd8133 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- Makefile.inc | 2 +- src/vendorcode/google/chromeos/Makefile.inc | 2 +- toolchain.inc | 16 ++++++---------- 3 files changed, 8 insertions(+), 12 deletions(-) diff --git a/Makefile.inc b/Makefile.inc index 9e4c6b0..d098cff 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -149,7 +149,7 @@ smm-c-deps:=$$(OPTION_TABLE_H) define ramstage-objs_asl_template $(obj)/$(1).ramstage.o: src/$(1).asl $(obj)/config.h @printf " IASL $$(subst $(top)/,,$$(@))\n" - $(CC_ramstage) -x assembler-with-cpp -E -MMD -MT $$(@) -D__ACPI__ -P -include $(src)/include/kconfig.h -I$(obj) -I$(src) -I$(src)/include -I$(src)/arch/$(ARCHDIR-$(ARCH-RAMSTAGE-y))/include -I$(src)/mainboard/$(MAINBOARDDIR) $$< -o $$(basename $$(a)).asl + $(CC_ramstage) -x assembler-with-cpp -E -MMD -MT $$(@) -D__ACPI__ -P -include $(src)/include/kconfig.h -I$(obj) -I$(src) -I$(src)/include -I$(src)/arch/$(ARCHDIR-$(ARCH-ramstage-y))/include -I$(src)/mainboard/$(MAINBOARDDIR) $$< -o $$(basename $$(a)).asl cd $$(dir $$@); $(IASL) -p $$(notdir $$@) -tc $$(notdir $$(basename $$(a))).asl mv $$(basename $$(a)).hex $$(basename $$(a)).c $(CC_ramstage) $$(CFLAGS_ramstage) $$(CPPFLAGS_ramstage) $$(if $$(subst dsdt,,$$(basename $$(notdir $(1)))), -DAmlCode=AmlCode_$$(basename $$(notdir $(1)))) -c -o $$@ $$(basename $$(a)).c diff --git a/src/vendorcode/google/chromeos/Makefile.inc b/src/vendorcode/google/chromeos/Makefile.inc index 80a0da9..a875303 100644 --- a/src/vendorcode/google/chromeos/Makefile.inc +++ b/src/vendorcode/google/chromeos/Makefile.inc @@ -44,7 +44,7 @@ VB_LIB = $(obj)/external/vboot_reference/vboot_fw.a # up all components in one of the three stages of coreboot, vboot seems # most logical to fall under the romstage. Thus, all references to arch # and other compiler stuff for vboot is using the romstage arch. -VB_FIRMWARE_ARCH := $(ARCHDIR-$(ARCH-ROMSTAGE-y)) +VB_FIRMWARE_ARCH := $(ARCHDIR-$(ARCH-romstage-y)) VB_SOURCE := vboot_reference # Add the vboot include paths. diff --git a/toolchain.inc b/toolchain.inc index f666e0c..d998a7e 100644 --- a/toolchain.inc +++ b/toolchain.inc @@ -17,10 +17,7 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## -ARCH_SUPPORTED := ARMV7 X86_32 - -ARCH_TO_TOOLCHAIN_X86_32 := x86_32 -ARCH_TO_TOOLCHAIN_ARMV7 := armv7 +ARCH_SUPPORTED := armv7 x86_32 COREBOOT_STANDARD_STAGES := bootblock romstage ramstage @@ -38,8 +35,8 @@ CFLAGS_armv7 = \ toolchain_to_dir = \ $(foreach arch,$(ARCH_SUPPORTED),\ - $(eval CPPFLAGS_$(ARCH_TO_TOOLCHAIN_$(arch)) = \ - -Isrc/arch/$(ARCHDIR-$(ARCH_TO_TOOLCHAIN_$(arch)))/include)) + $(eval CPPFLAGS_$(arch) = \ + -Isrc/arch/$(ARCHDIR-$(arch))/include)) # set_stage_toolchain: Decides the toolchain to be used by every stage # E.g.: If bootblock is x86_32, it sets ARCH-BOOTBLOCK-y = x86_32, whereas @@ -49,7 +46,7 @@ toolchain_to_dir = \ # stages i.e. bootblock, romstage and ramstage, since it acts as the second # parameter to create_class_compiler below in init_standard_toolchain set_stage_toolchain= \ - $(foreach arch,$(ARCH_SUPPORTED),$(eval ARCH-$(1)-$(CONFIG_ARCH_$(1)_$(arch)) := $(ARCH_TO_TOOLCHAIN_$(arch)))) + $(foreach arch,$(ARCH_SUPPORTED),$(eval ARCH-$(1)-$($(shell echo CONFIG_ARCH_$(1)_$(arch) | tr '[:lower:]' '[:upper:]')) := $(arch))) # create_class_compiler: Used to create compiler tool set for # special classes @@ -73,9 +70,8 @@ endef # initialize standard toolchain (CC,AS and others) for give stage # @1 : stage for which the toolchain is to be initialized init_standard_toolchain = \ - $(eval stage_caps := $(shell printf "%s" $(1) | tr '[:lower:]' '[:upper:]' )) \ - $(eval $(call set_stage_toolchain,$(stage_caps))) \ - $(eval $(call create_class_compiler,$(1),$(ARCH-$(stage_caps)-y))) \ + $(eval $(call set_stage_toolchain,$(1))) \ + $(eval $(call create_class_compiler,$(1),$(ARCH-$(1)-y))) \ $(eval $(call set_stage_libgcc,$(1))) init_stages = \

1 0

Patch set updated for coreboot: 07a8080 build: get rid of a special case
by Patrick Georgi 17 May '14

17 May '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5766 -gerrit commit 07a8080ddb0699e0d5ddf760f2ee04b503f69ff3 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Sat May 17 14:20:11 2014 +0200 build: get rid of a special case Don't call things in xcompile i386 and in the buildsystem x86_32 and then bridge things so they match. just call it the same everywhere. Change-Id: Ieef5f03f7aafb0b0a606fbe5a2386e310d2b0e94 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- toolchain.inc | 3 --- util/xcompile/xcompile | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/toolchain.inc b/toolchain.inc index dca00fc..f666e0c 100644 --- a/toolchain.inc +++ b/toolchain.inc @@ -81,9 +81,6 @@ init_standard_toolchain = \ init_stages = \ $(foreach stage,$(COREBOOT_STANDARD_STAGES),$(eval $(call init_standard_toolchain,$(stage)))) -# This mapping is created to have consistency with xcompile naming -$(eval $(call create_class_compiler,x86_32,i386)) - $(eval $(call toolchain_to_dir)) $(call init_stages) diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index 0ac2bec..b342de3 100644 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -181,7 +181,7 @@ arch_config_aarch64() { } arch_config_x86() { - TARCH="i386" + TARCH="x86_32" TBFDARCH="i386" TCLIST="i386 x86_64" TWIDTH="32"

1 0

Patch set updated for coreboot: af99fab build: separate CPPFLAGS from CFLAGS
by Patrick Georgi 17 May '14

17 May '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5765 -gerrit commit af99fab23f2ade13622bc3d2f486a715c2879aef Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Sat May 17 14:00:12 2014 +0200 build: separate CPPFLAGS from CFLAGS There are a couple of places where CPPFLAGS are pasted into CFLAGS, eliminate them. Change-Id: Ic7f568cf87a7d9c5c52e2942032a867161036bd7 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- Makefile | 2 +- Makefile.inc | 16 ++++++++-------- src/arch/armv7/Makefile.inc | 4 ++-- src/arch/x86/Makefile.inc | 2 +- src/cpu/intel/fsp_model_206ax/Makefile.inc | 2 +- src/drivers/intel/fsp/Makefile.inc | 2 +- src/northbridge/intel/fsp_sandybridge/Makefile.inc | 2 +- src/soc/intel/baytrail/Makefile.inc | 2 +- src/southbridge/intel/fsp_bd82x6x/Makefile.inc | 2 +- src/vendorcode/google/chromeos/Makefile.inc | 2 +- toolchain.inc | 4 ++-- 11 files changed, 20 insertions(+), 20 deletions(-) diff --git a/Makefile b/Makefile index c9648c0..3404a51 100644 --- a/Makefile +++ b/Makefile @@ -242,7 +242,7 @@ ifn$(EMPTY)def $(1)-objs_$(2)_template de$(EMPTY)fine $(1)-objs_$(2)_template $(obj)/$$(1).$(1).o: src/$$(1).$(2) $(obj)/config.h $(4) @printf " CC $$$$(subst $$$$(obj)/,,$$$$(@))\n" - $(CC_$(1)) $(3) -MMD $$$$(CFLAGS_$(1)) -c -o $$$$@ $$$$< + $(CC_$(1)) $(3) -MMD $$$$(CPPFLAGS_$(1)) $$$$(CFLAGS_$(1)) -c -o $$$$@ $$$$< en$(EMPTY)def end$(EMPTY)if endef diff --git a/Makefile.inc b/Makefile.inc index d76fab9..9e4c6b0 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -152,7 +152,7 @@ $(obj)/$(1).ramstage.o: src/$(1).asl $(obj)/config.h $(CC_ramstage) -x assembler-with-cpp -E -MMD -MT $$(@) -D__ACPI__ -P -include $(src)/include/kconfig.h -I$(obj) -I$(src) -I$(src)/include -I$(src)/arch/$(ARCHDIR-$(ARCH-RAMSTAGE-y))/include -I$(src)/mainboard/$(MAINBOARDDIR) $$< -o $$(basename $$(a)).asl cd $$(dir $$@); $(IASL) -p $$(notdir $$@) -tc $$(notdir $$(basename $$(a))).asl mv $$(basename $$(a)).hex $$(basename $$(a)).c - $(CC_ramstage) $$(CFLAGS_ramstage) $$(if $$(subst dsdt,,$$(basename $$(notdir $(1)))), -DAmlCode=AmlCode_$$(basename $$(notdir $(1)))) -c -o $$@ $$(basename $$(a)).c + $(CC_ramstage) $$(CFLAGS_ramstage) $$(CPPFLAGS_ramstage) $$(if $$(subst dsdt,,$$(basename $$(notdir $(1)))), -DAmlCode=AmlCode_$$(basename $$(notdir $(1)))) -c -o $$@ $$(basename $$(a)).c # keep %.o: %.c rule from catching the temporary .c file after a make clean mv $$(basename $$(a)).c $$(basename $$(a)).hex endef @@ -214,11 +214,11 @@ ifneq ($(CONFIG_LOCALVERSION),"") COREBOOT_EXTRA_VERSION := -$(call strip_quotes,$(CONFIG_LOCALVERSION)) endif -CPPFLAGS := -Isrc -Isrc/include -I$(obj) -CPPFLAGS += -Isrc/device/oprom/include -CPPFLAGS += -include $(src)/include/kconfig.h +CPPFLAGS_common := -Isrc -Isrc/include -I$(obj) +CPPFLAGS_common += -Isrc/device/oprom/include +CPPFLAGS_common += -include $(src)/include/kconfig.h -CFLAGS_common = $(CPPFLAGS) -Os -pipe -g -nostdinc +CFLAGS_common = -Os -pipe -g -nostdinc CFLAGS_common += -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes CFLAGS_common += -Wwrite-strings -Wredundant-decls -Wno-trigraphs CFLAGS_common += -Wstrict-aliasing -Wshadow @@ -314,15 +314,15 @@ $(objutil)/%.o: $(objutil)/%.c $(obj)/%.ramstage.o $(abspath $(obj))/%.ramstage.o: $(obj)/%.c $(obj)/config.h $(OPTION_TABLE_H) @printf " CC $(subst $(obj)/,,$(@))\n" - $(CC_ramstage) -MMD $(CFLAGS_ramstage) -c -o $@ $< + $(CC_ramstage) -MMD $(CFLAGS_ramstage) $(CPPFLAGS_ramstage) -c -o $@ $< $(obj)/%.romstage.o $(abspath $(obj))/%.romstage.o: $(obj)/%.c $(obj)/config.h $(OPTION_TABLE_H) @printf " CC $(subst $(obj)/,,$(@))\n" - $(CC_romstage) -MMD -D__PRE_RAM__ $(CFLAGS_romstage) -c -o $@ $< + $(CC_romstage) -MMD -D__PRE_RAM__ $(CFLAGS_romstage) $(CPPFLAGS_romstage) -c -o $@ $< $(obj)/%.bootblock.o $(abspath $(obj))/%.bootblock.o: $(obj)/%.c $(obj)/config.h $(OPTION_TABLE_H) @printf " CC $(subst $(obj)/,,$(@))\n" - $(CC_bootblock) -MMD $(bootblock-c-ccopts) $(CFLAGS_bootblock) -c -o $@ $< + $(CC_bootblock) -MMD $(bootblock-c-ccopts) $(CFLAGS_bootblock) $(CPPFLAGS_bootblock) -c -o $@ $< ####################################################################### # Clean up rules diff --git a/src/arch/armv7/Makefile.inc b/src/arch/armv7/Makefile.inc index 23e0bf6..402c491 100644 --- a/src/arch/armv7/Makefile.inc +++ b/src/arch/armv7/Makefile.inc @@ -155,7 +155,7 @@ $(objgenerated)/crt0.s: $(objgenerated)/crt0.romstage.S $(obj)/config.h $(obj)/b $(obj)/mainboard/$(MAINBOARDDIR)/romstage.pre.inc: $(src)/mainboard/$(MAINBOARDDIR)/romstage.c $(OPTION_TABLE_H) $(obj)/build.h $(obj)/config.h @printf " CC romstage.inc\n" - $(CC_romstage) -MMD $(CFLAGS_romstage) -D__PRE_RAM__ -I$(src) -I. -I$(obj) -c -S $< -o $@ + $(CC_romstage) -MMD $(CFLAGS_romstage) $(CPPFLAGS_romstage) -D__PRE_RAM__ -I$(src) -I. -I$(obj) -c -S $< -o $@ endif # CONFIG_ARCH_ROMSTAGE_ARMV7 @@ -192,7 +192,7 @@ $(objgenerated)/ramstage.o: $(stages_o) $$(ramstage-objs) $(LIBGCC_FILE_NAME_ram ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y) $(LD_ramstage) -m -m armelf_linux_eabi -r -o $@ --wrap __divdi3 --wrap __udivdi3 --wrap __moddi3 --wrap __umoddi3 --wrap __uidiv --start-group $(ramstage-objs) $(LIBGCC_FILE_NAME_ramstage) --end-group else - $(CC_ramstage) $(CFLAGS_ramstage) -nostdlib -r -o $@ -Wl,--start-group $(stages_o) $(ramstage-objs) $(LIBGCC_FILE_NAME_ramstage) -Wl,--end-group + $(CC_ramstage) $(CFLAGS_ramstage) $(CPPFLAGS_ramstage) -nostdlib -r -o $@ -Wl,--start-group $(stages_o) $(ramstage-objs) $(LIBGCC_FILE_NAME_ramstage) -Wl,--end-group endif ifeq ($(CONFIG_GENERATE_PIRQ_TABLE),y) diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc index 6ff059c..30f9243 100644 --- a/src/arch/x86/Makefile.inc +++ b/src/arch/x86/Makefile.inc @@ -193,7 +193,7 @@ else $(obj)/mainboard/$(MAINBOARDDIR)/romstage.pre.inc: $(src)/mainboard/$(MAINBOARDDIR)/romstage.c $(OPTION_TABLE_H) $(obj)/build.h $(obj)/config.h @printf " CC romstage.inc\n" - $(CC_romstage) -MMD $(CFLAGS_romstage) -D__PRE_RAM__ -I$(src) -I. -I$(obj) -c -S $< -o $@ + $(CC_romstage) -MMD $(CFLAGS_romstage) $(CPPFLAGS_romstage) -D__PRE_RAM__ -I$(src) -I. -I$(obj) -c -S $< -o $@ $(obj)/mainboard/$(MAINBOARDDIR)/romstage.inc: $(obj)/mainboard/$(MAINBOARDDIR)/romstage.pre.inc @printf " POST romstage.inc\n" diff --git a/src/cpu/intel/fsp_model_206ax/Makefile.inc b/src/cpu/intel/fsp_model_206ax/Makefile.inc index 8345002..c6d7339 100644 --- a/src/cpu/intel/fsp_model_206ax/Makefile.inc +++ b/src/cpu/intel/fsp_model_206ax/Makefile.inc @@ -9,6 +9,6 @@ cpu_microcode-$(CONFIG_CPU_MICROCODE_CBFS_GENERATE) += microcode_blob.c ifneq ($(CONFIG_MICROCODE_INCLUDE_PATH),) ifneq ($(wildcard $(shell realpath -L "$(top)/$(CONFIG_MICROCODE_INCLUDE_PATH)")),) -CPPFLAGS += -I$(CONFIG_MICROCODE_INCLUDE_PATH) +CPPFLAGS_common += -I$(CONFIG_MICROCODE_INCLUDE_PATH) endif endif diff --git a/src/drivers/intel/fsp/Makefile.inc b/src/drivers/intel/fsp/Makefile.inc index 86c3a85..280f7b9 100644 --- a/src/drivers/intel/fsp/Makefile.inc +++ b/src/drivers/intel/fsp/Makefile.inc @@ -22,7 +22,7 @@ romstage-y += fsp_util.c ramstage-$(CONFIG_ENABLE_MRC_CACHE) += fastboot_cache.c romstage-$(CONFIG_ENABLE_MRC_CACHE) += fastboot_cache.c -CPPFLAGS += -Isrc/drivers/intel/fsp +CPPFLAGS_common += -Isrc/drivers/intel/fsp ifeq ($(CONFIG_USE_GENERIC_FSP_CAR_INC),y) cpu_incs += $(src)/drivers/intel/fsp/cache_as_ram.inc diff --git a/src/northbridge/intel/fsp_sandybridge/Makefile.inc b/src/northbridge/intel/fsp_sandybridge/Makefile.inc index 952c008..a229119 100644 --- a/src/northbridge/intel/fsp_sandybridge/Makefile.inc +++ b/src/northbridge/intel/fsp_sandybridge/Makefile.inc @@ -32,6 +32,6 @@ romstage-y += ../../../arch/x86/lib/walkcbfs.S smm-$(CONFIG_HAVE_SMI_HANDLER) += udelay.c smm-$(CONFIG_HAVE_SMI_HANDLER) += finalize.c -CPPFLAGS += -I$(src)/northbridge/intel/fsp_sandybridge/fsp +CPPFLAGS_common += -I$(src)/northbridge/intel/fsp_sandybridge/fsp $(obj)/northbridge/intel/fsp_sandybridge/acpi.ramstage.o : $(obj)/build.h diff --git a/src/soc/intel/baytrail/Makefile.inc b/src/soc/intel/baytrail/Makefile.inc index 179f2a6..d4f653e 100644 --- a/src/soc/intel/baytrail/Makefile.inc +++ b/src/soc/intel/baytrail/Makefile.inc @@ -53,7 +53,7 @@ ramstage-$(CONFIG_ELOG) += elog.c # Remove as ramstage gets fleshed out ramstage-y += placeholders.c -CPPFLAGS += -Isrc/soc/intel/baytrail/ +CPPFLAGS_common += -Isrc/soc/intel/baytrail/ # Run an intermediate step when producing coreboot.rom # that adds additional components to the final firmware diff --git a/src/southbridge/intel/fsp_bd82x6x/Makefile.inc b/src/southbridge/intel/fsp_bd82x6x/Makefile.inc index fdb0431..208611b 100644 --- a/src/southbridge/intel/fsp_bd82x6x/Makefile.inc +++ b/src/southbridge/intel/fsp_bd82x6x/Makefile.inc @@ -70,4 +70,4 @@ endif PHONY += bd82x6x_add_me -CPPFLAGS += -I$(src)/southbridge/intel/fsp_bd82x6x +CPPFLAGS_common += -I$(src)/southbridge/intel/fsp_bd82x6x diff --git a/src/vendorcode/google/chromeos/Makefile.inc b/src/vendorcode/google/chromeos/Makefile.inc index f0289f8..80a0da9 100644 --- a/src/vendorcode/google/chromeos/Makefile.inc +++ b/src/vendorcode/google/chromeos/Makefile.inc @@ -48,7 +48,7 @@ VB_FIRMWARE_ARCH := $(ARCHDIR-$(ARCH-ROMSTAGE-y)) VB_SOURCE := vboot_reference # Add the vboot include paths. -CPPFLAGS += -I$(VB_SOURCE)/firmware/include +CPPFLAGS_common += -I$(VB_SOURCE)/firmware/include VBOOT_STUB_ELF = $(obj)/vendorcode/google/chromeos/vbootstub.elf VBOOT_STUB = $(VBOOT_STUB_ELF).rmod diff --git a/toolchain.inc b/toolchain.inc index ea67ad4..dca00fc 100644 --- a/toolchain.inc +++ b/toolchain.inc @@ -64,8 +64,8 @@ OBJCOPY_$(1) := $(OBJCOPY_$(2)) OBJDUMP_$(1) := $(OBJDUMP_$(2)) STRIP_$(1) := $(STRIP_$(2)) READELF_$(1) := $(READELF_$(2)) -CPPFLAGS_$(1) = -Isrc/arch/$(ARCHDIR-$(2))/include -CFLAGS_$(1) = $$(CFLAGS_common) $$(CPPFLAGS_$(1)) $(CFLAGS_$(2)) +CFLAGS_$(1) = $$(CFLAGS_common) $$(CFLAGS_$(2)) +CPPFLAGS_$(1) = $$(CPPFLAGS_common) $$(CPPFLAGS_$(2)) LIBGCC_FILE_NAME_$(1) = $(shell [ -r `$(CC_$(2)) -print-libgcc-file-name` ] && \ $(CC_$(2)) -print-libgcc-file-name) endef

1 0

New patch to review for coreboot: 52cf0d2 build: remove call to missing function
by Patrick Georgi 17 May '14

17 May '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5770 -gerrit commit 52cf0d270acf07110d4c1ad607faf58e8f60b782 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Sat May 17 15:13:40 2014 +0200 build: remove call to missing function set_stage_libgcc never existed in our tree. Change-Id: I864fc683dd7b89a030daf05eafb9624ce828cb72 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- toolchain.inc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/toolchain.inc b/toolchain.inc index 568b3d6..9417a73 100644 --- a/toolchain.inc +++ b/toolchain.inc @@ -70,8 +70,7 @@ endef # @1 : stage for which the toolchain is to be initialized init_standard_toolchain = \ $(eval $(call set_stage_toolchain,$(1))) \ - $(eval $(call create_class_compiler,$(1),$(ARCH-$(1)-y))) \ - $(eval $(call set_stage_libgcc,$(1))) + $(eval $(call create_class_compiler,$(1),$(ARCH-$(1)-y))) init_stages = \ $(foreach stage,$(COREBOOT_STANDARD_STAGES),$(eval $(call init_standard_toolchain,$(stage))))

1 0

New patch to review for coreboot: 049649a build: break compiler flags out of $(CC)
by Patrick Georgi 17 May '14

17 May '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5769 -gerrit commit 049649a45acbefce6ec21980fda1f84d6de119cd Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Sat May 17 15:08:47 2014 +0200 build: break compiler flags out of $(CC) Having more than the executable in $(CC) only leads to trouble in a number of situations. Change-Id: I7642ca4068b3a3bd5798219d74de9e0eb85bb4e5 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- src/arch/x86/Makefile.inc | 2 +- toolchain.inc | 4 ++-- util/xcompile/xcompile | 3 ++- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc index 30f9243..6c7008c 100644 --- a/src/arch/x86/Makefile.inc +++ b/src/arch/x86/Makefile.inc @@ -28,7 +28,7 @@ subdirs-y += lib subdirs-y += smp ifeq ($(CONFIG_COMPILER_GCC),y) -DISASSEMBLY=-Wa,-acdlns +DISASSEMBLY=-Wa,-acdlns $(CFLAGS_x86_32) else DISASSEMBLY= endif diff --git a/toolchain.inc b/toolchain.inc index b615bce..568b3d6 100644 --- a/toolchain.inc +++ b/toolchain.inc @@ -25,7 +25,7 @@ ARCHDIR-i386 := x86 ARCHDIR-x86_32 := x86 ARCHDIR-armv7 := armv7 -CFLAGS_armv7 = \ +CFLAGS_armv7 += \ -ffixed-r8\ -march=armv7-a\ -marm\ @@ -35,7 +35,7 @@ CFLAGS_armv7 = \ toolchain_to_dir = \ $(foreach arch,$(ARCH_SUPPORTED),\ - $(eval CPPFLAGS_$(arch) = \ + $(eval CPPFLAGS_$(arch) += \ -Isrc/arch/$(ARCHDIR-$(arch))/include)) # set_stage_toolchain: Decides the toolchain to be used by every stage diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index b342de3..d133bd2 100644 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -147,7 +147,8 @@ detect_special_flags() { report_arch_toolchain() { cat <<EOF # elf${TWIDTH}-${TBFDARCH} toolchain (${GCCPREFIX}gcc) -CC_${TARCH}:=${GCCPREFIX}gcc ${CFLAGS} +CC_${TARCH}:=${GCCPREFIX}gcc +CFLAGS_${TARCH}:=${CFLAGS} CPP_${TARCH}:=${GCCPREFIX}cpp AS_${TARCH}:=${GCCPREFIX}as ${ASFLAGS} LD_${TARCH}:=${GCCPREFIX}ld${LINKER_SUFFIX} ${LDFLAGS}

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2014