coreboot-gerrit May 2014

coreboot-gerrit@coreboot.org

1 participants
1066 discussions

New patch to review for coreboot: c4c9726 mainboard/supermicro/h8dme: Unused func warn
by Edward O'Callaghan 23 May '14

23 May '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5828 -gerrit commit c4c97262c37e1dc832e0bb26d88e8d827be53ddc Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Sat May 24 01:45:41 2014 +1000 mainboard/supermicro/h8dme: Unused func warn Clang complains about a unused debug function, so #if 0 it out so abuilds move forward with Clang. Change-Id: I5a9a785fcd90761789aaa029f712f1feddd2afd1 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/mainboard/supermicro/h8dme/romstage.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mainboard/supermicro/h8dme/romstage.c b/src/mainboard/supermicro/h8dme/romstage.c index df5e2c8..b351ccd 100644 --- a/src/mainboard/supermicro/h8dme/romstage.c +++ b/src/mainboard/supermicro/h8dme/romstage.c @@ -45,6 +45,7 @@ static void memreset(int controllers, const struct mem_controller *ctrl) { } +#if 0 static inline void dump_smbus_registers(void) { u32 device; @@ -71,6 +72,7 @@ static inline void dump_smbus_registers(void) print_debug("\n"); } } +#endif static inline void activate_spd_rom(const struct mem_controller *ctrl) {

1 0

New patch to review for coreboot: 3f16922 mainboard/intel/emeraldlake2 Fix usage of GNU field designator ext
by Edward O'Callaghan 23 May '14

23 May '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5827 -gerrit commit 3f1692219b4a496d897ce10e1c74948d877bd222 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Sat May 24 02:08:04 2014 +1000 mainboard/intel/emeraldlake2 Fix usage of GNU field designator ext Following the reasoning in, 8089f17 mainboard/lenovo/x230 Fix usage of GNU field designator extension In C99 we defined a syntax for this. GCC's old syntax was deprecated. Change-Id: Idda1a49277c156670014fac27b9f1c378f8df0cd Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/mainboard/intel/emeraldlake2/romstage.c | 44 ++++++++++++++--------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/src/mainboard/intel/emeraldlake2/romstage.c b/src/mainboard/intel/emeraldlake2/romstage.c index 9308e96..a7ab482 100644 --- a/src/mainboard/intel/emeraldlake2/romstage.c +++ b/src/mainboard/intel/emeraldlake2/romstage.c @@ -169,32 +169,32 @@ void main(unsigned long bist) u16 pm1_sts; struct pei_data pei_data = { - pei_version: PEI_VERSION, - mchbar: DEFAULT_MCHBAR, - dmibar: DEFAULT_DMIBAR, - epbar: DEFAULT_EPBAR, - pciexbar: CONFIG_MMCONF_BASE_ADDRESS, - smbusbar: SMBUS_IO_BASE, - wdbbar: 0x4000000, - wdbsize: 0x1000, - hpet_address: CONFIG_HPET_ADDRESS, - rcba: DEFAULT_RCBABASE, - pmbase: DEFAULT_PMBASE, - gpiobase: DEFAULT_GPIOBASE, - thermalbase: 0xfed08000, - system_type: 0, // 0 Mobile, 1 Desktop/Server - tseg_size: CONFIG_SMM_TSEG_SIZE, - spd_addresses: { 0xa0, 0x00, 0xa4, 0x00 }, - ts_addresses: { 0x00, 0x00, 0x00, 0x00 }, - ec_present: 0, + .pei_version = PEI_VERSION, + .mchbar = DEFAULT_MCHBAR, + .dmibar = DEFAULT_DMIBAR, + .epbar = DEFAULT_EPBAR, + .pciexbar = CONFIG_MMCONF_BASE_ADDRESS, + .smbusbar = SMBUS_IO_BASE, + .wdbbar = 0x4000000, + .wdbsize = 0x1000, + .hpet_address = CONFIG_HPET_ADDRESS, + .rcba = DEFAULT_RCBABASE, + .pmbase = DEFAULT_PMBASE, + .gpiobase = DEFAULT_GPIOBASE, + .thermalbase = 0xfed08000, + .system_type = 0, // 0 Mobile, 1 Desktop/Server + .tseg_size = CONFIG_SMM_TSEG_SIZE, + .spd_addresses = { 0xa0, 0x00, 0xa4, 0x00 }, + .ts_addresses = { 0x00, 0x00, 0x00, 0x00 }, + .ec_present = 0, // 0 = leave channel enabled // 1 = disable dimm 0 on channel // 2 = disable dimm 1 on channel // 3 = disable dimm 0+1 on channel - dimm_channel0_disabled: 2, - dimm_channel1_disabled: 2, - max_ddr3_freq: 1600, - usb_port_config: { + .dimm_channel0_disabled = 2, + .dimm_channel1_disabled = 2, + .max_ddr3_freq = 1600, + .usb_port_config = { { 1, 0, 0x0040 }, /* P0: Front port (OC0) */ { 1, 1, 0x0040 }, /* P1: Back port (OC1) */ { 1, 0, 0x0040 }, /* P2: MINIPCIE1 (no OC) */

1 0

New patch to review for coreboot: 8347c0a mainboard/intel/baskingridge Fix usage of GNU field designator ext
by Edward O'Callaghan 23 May '14

23 May '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5826 -gerrit commit 8347c0a92dd1d372557021eb9ac3fe76157bb9d7 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Sat May 24 02:07:18 2014 +1000 mainboard/intel/baskingridge Fix usage of GNU field designator ext Following the reasoning in, 8089f17 mainboard/lenovo/x230 Fix usage of GNU field designator extension In C99 we defined a syntax for this. GCC's old syntax was deprecated. Change-Id: I61fe91e467c29f144323af9c4612420f322098b4 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/mainboard/intel/baskingridge/romstage.c | 44 ++++++++++++++--------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/src/mainboard/intel/baskingridge/romstage.c b/src/mainboard/intel/baskingridge/romstage.c index ee516d9..e02ae7a 100644 --- a/src/mainboard/intel/baskingridge/romstage.c +++ b/src/mainboard/intel/baskingridge/romstage.c @@ -70,31 +70,31 @@ const struct rcba_config_instruction rcba_config[] = { void mainboard_romstage_entry(unsigned long bist) { struct pei_data pei_data = { - pei_version: PEI_VERSION, - mchbar: DEFAULT_MCHBAR, - dmibar: DEFAULT_DMIBAR, - epbar: DEFAULT_EPBAR, - pciexbar: DEFAULT_PCIEXBAR, - smbusbar: SMBUS_IO_BASE, - wdbbar: 0x4000000, - wdbsize: 0x1000, - hpet_address: HPET_ADDR, - rcba: DEFAULT_RCBA, - pmbase: DEFAULT_PMBASE, - gpiobase: DEFAULT_GPIOBASE, - temp_mmio_base: 0xfed08000, - system_type: 0, // 0 Mobile, 1 Desktop/Server - tseg_size: CONFIG_SMM_TSEG_SIZE, - spd_addresses: { 0xa0, 0xa2, 0xa4, 0xa6 }, - ec_present: 0, + .pei_version = PEI_VERSION, + .mchbar = DEFAULT_MCHBAR, + .dmibar = DEFAULT_DMIBAR, + .epbar = DEFAULT_EPBAR, + .pciexbar = DEFAULT_PCIEXBAR, + .smbusbar = SMBUS_IO_BASE, + .wdbbar = 0x4000000, + .wdbsize = 0x1000, + .hpet_address = HPET_ADDR, + .rcba = DEFAULT_RCBA, + .pmbase = DEFAULT_PMBASE, + .gpiobase = DEFAULT_GPIOBASE, + .temp_mmio_base = 0xfed08000, + .system_type = 0, // 0 Mobile, 1 Desktop/Server + .tseg_size = CONFIG_SMM_TSEG_SIZE, + .spd_addresses = { 0xa0, 0xa2, 0xa4, 0xa6 }, + .ec_present = 0, // 0 = leave channel enabled // 1 = disable dimm 0 on channel // 2 = disable dimm 1 on channel // 3 = disable dimm 0+1 on channel - dimm_channel0_disabled: 0, - dimm_channel1_disabled: 0, - max_ddr3_freq: 1600, - usb2_ports: { + .dimm_channel0_disabled = 0, + .dimm_channel1_disabled = 0, + .max_ddr3_freq = 1600, + .usb2_ports = { /* Length, Enable, OCn#, Location */ { 0x0040, 1, 0, /* P0: Back USB3 port (OC0) */ USB_PORT_BACK_PANEL }, @@ -125,7 +125,7 @@ void mainboard_romstage_entry(unsigned long bist) { 0x0040, 1, 6, /* P13: USB/DP Jack (OC6) */ USB_PORT_FRONT_PANEL }, }, - usb3_ports: { + .usb3_ports = { /* Enable, OCn# */ { 1, 0 }, /* P1; */ { 1, 0 }, /* P2; */

1 0

New patch to review for coreboot: f9acde4 mainboard/intel/wtm2: Fix usage of GNU field designator extension
by Edward O'Callaghan 23 May '14

23 May '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5825 -gerrit commit f9acde41c453d7105a3dfeded17d9f895b96d551 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Sat May 24 02:06:10 2014 +1000 mainboard/intel/wtm2: Fix usage of GNU field designator extension Following the reasoning in, 8089f17 mainboard/lenovo/x230 Fix usage of GNU field designator extension In C99 we defined a syntax for this. GCC's old syntax was deprecated. Change-Id: I46fad8d236c620ee5dbeb24f4517f20f00db839f Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/mainboard/intel/wtm2/romstage.c | 44 ++++++++++++++++++------------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/src/mainboard/intel/wtm2/romstage.c b/src/mainboard/intel/wtm2/romstage.c index eacfb46..b831244 100644 --- a/src/mainboard/intel/wtm2/romstage.c +++ b/src/mainboard/intel/wtm2/romstage.c @@ -75,31 +75,31 @@ const struct rcba_config_instruction rcba_config[] = { void mainboard_romstage_entry(unsigned long bist) { struct pei_data pei_data = { - pei_version: PEI_VERSION, - mchbar: DEFAULT_MCHBAR, - dmibar: DEFAULT_DMIBAR, - epbar: DEFAULT_EPBAR, - pciexbar: DEFAULT_PCIEXBAR, - smbusbar: SMBUS_IO_BASE, - wdbbar: 0x4000000, - wdbsize: 0x1000, - hpet_address: HPET_ADDR, - rcba: DEFAULT_RCBA, - pmbase: DEFAULT_PMBASE, - gpiobase: DEFAULT_GPIOBASE, - temp_mmio_base: 0xfed08000, - system_type: 5, /* ULT */ - tseg_size: CONFIG_SMM_TSEG_SIZE, - spd_addresses: { 0xa2, 0x00, 0xa2, 0x00 }, - ec_present: 1, + .pei_version = PEI_VERSION, + .mchbar = DEFAULT_MCHBAR, + .dmibar = DEFAULT_DMIBAR, + .epbar = DEFAULT_EPBAR, + .pciexbar = DEFAULT_PCIEXBAR, + .smbusbar = SMBUS_IO_BASE, + .wdbbar = 0x4000000, + .wdbsize = 0x1000, + .hpet_address = HPET_ADDR, + .rcba = DEFAULT_RCBA, + .pmbase = DEFAULT_PMBASE, + .gpiobase = DEFAULT_GPIOBASE, + .temp_mmio_base = 0xfed08000, + .system_type = 5, /* ULT */ + .tseg_size = CONFIG_SMM_TSEG_SIZE, + .spd_addresses = { 0xa2, 0x00, 0xa2, 0x00 }, + .ec_present = 1, // 0 = leave channel enabled // 1 = disable dimm 0 on channel // 2 = disable dimm 1 on channel // 3 = disable dimm 0+1 on channel - dimm_channel0_disabled: 2, - dimm_channel1_disabled: 2, - max_ddr3_freq: 1600, - usb2_ports: { + .dimm_channel0_disabled = 2, + .dimm_channel1_disabled = 2, + .max_ddr3_freq = 1600, + .usb2_ports = { /* Length, Enable, OCn# */ { 0x40, 1, USB_OC_PIN_SKIP, /* P0: */ USB_PORT_FRONT_PANEL }, @@ -118,7 +118,7 @@ void mainboard_romstage_entry(unsigned long bist) { 0x40, 0, USB_OC_PIN_SKIP, /* P7: */ USB_PORT_FRONT_PANEL }, }, - usb3_ports: { + .usb3_ports = { /* Enable, OCn# */ { 1, USB_OC_PIN_SKIP }, /* P1; */ { 1, USB_OC_PIN_SKIP }, /* P2; */

1 0

New patch to review for coreboot: c6579de mainboard/kontron/ktqm77: Fix usage of GNU field designator ext
by Edward O'Callaghan 23 May '14

23 May '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5824 -gerrit commit c6579de16b8cd35e7d7b7ce1e23bafeb677bdd33 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Sat May 24 02:04:52 2014 +1000 mainboard/kontron/ktqm77: Fix usage of GNU field designator ext Following the reasoning in, 8089f17 mainboard/lenovo/x230 Fix usage of GNU field designator extension In C99 we defined a syntax for this. GCC's old syntax was deprecated. Change-Id: If948960abbd927aa6d2b471a42a2321a04d992f3 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/mainboard/kontron/ktqm77/romstage.c | 60 ++++++++++++++++----------------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/src/mainboard/kontron/ktqm77/romstage.c b/src/mainboard/kontron/ktqm77/romstage.c index b5959b1..7385cd0 100644 --- a/src/mainboard/kontron/ktqm77/romstage.c +++ b/src/mainboard/kontron/ktqm77/romstage.c @@ -157,34 +157,34 @@ void main(unsigned long bist) u16 pm1_sts; struct pei_data pei_data = { - pei_version: PEI_VERSION, - mchbar: DEFAULT_MCHBAR, - dmibar: DEFAULT_DMIBAR, - epbar: DEFAULT_EPBAR, - pciexbar: CONFIG_MMCONF_BASE_ADDRESS, - smbusbar: SMBUS_IO_BASE, - wdbbar: 0x4000000, - wdbsize: 0x1000, - hpet_address: CONFIG_HPET_ADDRESS, - rcba: DEFAULT_RCBABASE, - pmbase: DEFAULT_PMBASE, - gpiobase: DEFAULT_GPIOBASE, - thermalbase: 0xfed08000, - system_type: 0, // 0 Mobile, 1 Desktop/Server - tseg_size: CONFIG_SMM_TSEG_SIZE, - spd_addresses: { 0xA0, 0x00,0xA4,0x00 }, - ts_addresses: { 0x00, 0x00, 0x00, 0x00 }, - ec_present: 1, - gbe_enable: 1, - ddr3lv_support: 0, + .pei_version = PEI_VERSION, + .mchbar = DEFAULT_MCHBAR, + .dmibar = DEFAULT_DMIBAR, + .epbar = DEFAULT_EPBAR, + .pciexbar = CONFIG_MMCONF_BASE_ADDRESS, + .smbusbar = SMBUS_IO_BASE, + .wdbbar = 0x4000000, + .wdbsize = 0x1000, + .hpet_address = CONFIG_HPET_ADDRESS, + .rcba = DEFAULT_RCBABASE, + .pmbase = DEFAULT_PMBASE, + .gpiobase = DEFAULT_GPIOBASE, + .thermalbase = 0xfed08000, + .system_type = 0, // 0 Mobile, 1 Desktop/Server + .tseg_size = CONFIG_SMM_TSEG_SIZE, + .spd_addresses = { 0xA0, 0x00,0xA4,0x00 }, + .ts_addresses = { 0x00, 0x00, 0x00, 0x00 }, + .ec_present = 1, + .gbe_enable = 1, + .ddr3lv_support = 0, // 0 = leave channel enabled // 1 = disable dimm 0 on channel // 2 = disable dimm 1 on channel // 3 = disable dimm 0+1 on channel - dimm_channel0_disabled: 2, - dimm_channel1_disabled: 2, - max_ddr3_freq: 1600, - usb_port_config: { + .dimm_channel0_disabled = 2, + .dimm_channel1_disabled = 2, + .max_ddr3_freq = 1600, + .usb_port_config = { /* enabled usb oc pin length */ { 1, 0, 0x0040 }, /* P0: lower left USB 3.0 (OC0) */ { 1, 0, 0x0040 }, /* P1: upper left USB 3.0 (OC0) */ @@ -201,13 +201,13 @@ void main(unsigned long bist) { 1, 4, 0x0040 }, /* P12: internal USB 2.0 (OC4) */ { 1, 4, 0x0040 }, /* P13: internal USB 2.0 (OC4) */ }, - usb3: { - mode: 3, /* Smart Auto? */ - hs_port_switch_mask: 0xf, /* All four ports. */ - preboot_support: 1, /* preOS driver? */ - xhci_streams: 1, /* Enable. */ + .usb3 = { + .mode = 3, /* Smart Auto? */ + .hs_port_switch_mask = 0xf, /* All four ports. */ + .preboot_support = 1, /* preOS driver? */ + .xhci_streams = 1, /* Enable. */ }, - pcie_init: 1, + .pcie_init = 1, }; timestamp_init(get_initial_timestamp());

1 0

Patch set updated for coreboot: 1166342 drivers/pc80/Kconfig: Revert PS/2 initialization defaults
by Patrick Georgi 23 May '14

23 May '14

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5634 -gerrit commit 1166342c34407f77d54a00004eb695ff2dcd156b Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Fri May 2 15:19:21 2014 +0200 drivers/pc80/Kconfig: Revert PS/2 initialization defaults Remove the inconsistent behaviour based on unrelated configuration: PS/2 init is now always enabled. This can change once we find a better approach. Change-Id: Ia8d55032f0e5eca0bf82d77df7dab95bcb2b353a Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> --- src/drivers/pc80/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/src/drivers/pc80/Kconfig b/src/drivers/pc80/Kconfig index 1348dd4..3572bc2 100644 --- a/src/drivers/pc80/Kconfig +++ b/src/drivers/pc80/Kconfig @@ -2,7 +2,6 @@ # reliably support PS/2 init themselves. config DRIVERS_PS2_KEYBOARD bool "PS/2 keyboard init" - default n if PAYLOAD_GRUB2 || PAYLOAD_SEABIOS default y help Enable this option to initialize PS/2 keyboards found connected

1 0

Patch merged into coreboot/master: 8084e5b mainboard/google/peppy Fix usage of GNU field designator extension
by gerrit＠coreboot.org 23 May '14

23 May '14

the following patch was just integrated into master: commit 8084e5b6da38865bde976ae02563f83dad37c133 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Fri May 23 08:42:18 2014 +1000 mainboard/google/peppy Fix usage of GNU field designator extension Following the reasoning in, 8089f17 mainboard/lenovo/x230 Fix usage of GNU field designator extension In C99 we defined a syntax for this. GCC's old syntax was deprecated. Change-Id: Idd7305cb34be77894ca4b6062bc0a2dc61126347 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Reviewed-on: http://review.coreboot.org/5822 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <patrick(a)georgi-clan.de> See http://review.coreboot.org/5822 for details. -gerrit

1 0

Patch merged into coreboot/master: f5037bd mainboard/google/parrot Fix usage of GNU field designator extension
by gerrit＠coreboot.org 23 May '14

23 May '14

the following patch was just integrated into master: commit f5037bd570a7cbd2b09fb6d34d3feb77553144f4 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Fri May 23 08:36:01 2014 +1000 mainboard/google/parrot Fix usage of GNU field designator extension Following the reasoning in: 8089f17 mainboard/lenovo/x230 Fix usage of GNU field designator extension In C99 we defined a syntax for this. GCC's old syntax was deprecated. Change-Id: I5be77fe6670601e103260077fae07a5b9fd41f1d Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Reviewed-on: http://review.coreboot.org/5821 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <patrick(a)georgi-clan.de> See http://review.coreboot.org/5821 for details. -gerrit

1 0

Patch merged into coreboot/master: 26c74fb payloads/coreinfo/multiboot_module.c: Trivial fix indents
by gerrit＠coreboot.org 23 May '14

23 May '14

the following patch was just integrated into master: commit 26c74fbd4f23223cb461dba9e35f5921fbc08534 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Wed May 14 04:13:16 2014 +1000 payloads/coreinfo/multiboot_module.c: Trivial fix indents Stylistic fix-up's. Change-Id: I0cad7c860280d0d8dcb16d052846c72f690e2b65 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Reviewed-on: http://review.coreboot.org/5731 Tested-by: build bot (Jenkins) Reviewed-by: Idwer Vollering <vidwer(a)gmail.com> See http://review.coreboot.org/5731 for details. -gerrit

1 0

Patch merged into coreboot/master: aab0cce abuild: make build directory configurable with a variable
by gerrit＠coreboot.org 23 May '14

23 May '14

the following patch was just integrated into master: commit aab0cce88891197510740ac5a663e003b7f99981 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Thu Dec 19 20:43:29 2013 +0100 abuild: make build directory configurable with a variable Allow overriding the build directly (default: coreboot-builds) using the COREBOOT_BUILD_DIR variable, in addition to setting it through the -o parameter. This helps with build nodes where jenkins wants to run the same command everywhere but allows different environment variables. Change-Id: If907897cf6ac01caa7d1e4b51aad4c005356bc5b Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> Reviewed-on: http://review.coreboot.org/4543 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/4543 for details. -gerrit

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2014