Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5506
-gerrit
commit 06c293df959a0a5c4c65fc52d863e7ab0462883e
Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
Date: Tue Apr 15 17:26:46 2014 +1000
mainboard/jetway/nf81-t56n-lf: Make ACPI debug menuconfigable
Turns out we have a CONFIG_DEBUG_ACPI definition under:
Debugging -> Output verbose ACPI debug messages
Hence, let us make use of this definition.
Change-Id: I1b673feb6d9b2ee51c832a1cef159cd80e5c3517
Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
---
src/mainboard/jetway/nf81-t56n-lf/acpi_tables.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/mainboard/jetway/nf81-t56n-lf/acpi_tables.c b/src/mainboard/jetway/nf81-t56n-lf/acpi_tables.c
index b513fce..a3c5728 100644
--- a/src/mainboard/jetway/nf81-t56n-lf/acpi_tables.c
+++ b/src/mainboard/jetway/nf81-t56n-lf/acpi_tables.c
@@ -28,8 +28,7 @@
#include <device/pci_ids.h>
#include <string.h>
-#define DUMP_ACPI_TABLES 0
-#include <lib.h> /* used for hexdump for DUMP_ACPI_TABLES */
+#include <lib.h> /* used for hexdump for CONFIG_DEBUG_ACPI */
extern const unsigned char AmlCode[];
@@ -268,7 +267,7 @@ unsigned long write_acpi_tables(unsigned long start)
current += ssdt2->length;
acpi_add_table(rsdp,ssdt2);
-#if DUMP_ACPI_TABLES == 1
+#if defined(CONFIG_DEBUG_ACPI)
printk(BIOS_DEBUG, "rsdp\n");
hexdump(rsdp, sizeof(acpi_rsdp_t));
@@ -298,7 +297,7 @@ unsigned long write_acpi_tables(unsigned long start)
printk(BIOS_DEBUG, "hest\n");
hexdump(hest, hest->header.length);
-#endif /* DUMP_ACPI_TABLES */
+#endif /* CONFIG_DEBUG_ACPI */
printk(BIOS_INFO, "ACPI: done.\n");
return current;
Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5505
-gerrit
commit d09afda76752ebc74b34edced57ad760be8ff73f
Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
Date: Tue Apr 15 17:11:56 2014 +1000
drivers/elog: Ensure ELOG_BOOT_COUNT_CMOS_OFFSET >16bytes
The ELOG_BOOT_COUNT_CMOS_OFFSET compile-time constant must be >16 bytes
as not to interfere with the standard RTC region. Let us ensure the user
specified value is a sane one as we do with ELOG_FLASH_BASE.
Change-Id: Id56b4ceeef34386dac9176669e732641ae031d60
Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
---
src/drivers/elog/boot_count.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/drivers/elog/boot_count.c b/src/drivers/elog/boot_count.c
index 9ea828d..dca3508 100644
--- a/src/drivers/elog/boot_count.c
+++ b/src/drivers/elog/boot_count.c
@@ -34,12 +34,13 @@
# include "option_table.h"
# define BOOT_COUNT_CMOS_OFFSET (CMOS_VSTART_boot_count_offset >> 3)
#else
-# if defined(CONFIG_ELOG_BOOT_COUNT_CMOS_OFFSET)
+# if defined(CONFIG_ELOG_BOOT_COUNT_CMOS_OFFSET) && \
+ (CONFIG_ELOG_BOOT_COUNT_CMOS_OFFSET > 16)
# define BOOT_COUNT_CMOS_OFFSET CONFIG_ELOG_BOOT_COUNT_CMOS_OFFSET
# else
# error "Must define CONFIG_ELOG_BOOT_COUNT_CMOS_OFFSET"
-# endif
-#endif
+# endif /* CONFIG_ELOG_BOOT_COUNT_CMOS_OFFSET > 16 */
+#endif /* CONFIG_USE_OPTION_TABLE */
#define BOOT_COUNT_SIGNATURE 0x4342 /* 'BC' */
Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5504
-gerrit
commit 79d6d9ead40b25dac6a8eb76266e79484c8d9937
Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
Date: Tue Apr 15 14:32:53 2014 +1000
driver/elog: Fix implicit function declaration issue
Fix compilation. Relying on the pre-processor to condition a if
statement will lead to warnings of implicititly defined functions.
Change-Id: Id0117528c5579cc1dec750a8a17a76fab4314b3f
Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com>
---
src/drivers/elog/elog.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/drivers/elog/elog.c b/src/drivers/elog/elog.c
index de34928..4b1f839 100644
--- a/src/drivers/elog/elog.c
+++ b/src/drivers/elog/elog.c
@@ -607,12 +607,15 @@ int elog_init(void)
#if !defined(__SMM__)
/* Log boot count event except in S3 resume */
- if (CONFIG_ELOG_BOOT_COUNT && acpi_slp_type != 3)
+#if CONFIG_ELOG_BOOT_COUNT == 1
+ if (acpi_slp_type != 3)
elog_add_event_dword(ELOG_TYPE_BOOT, boot_count_read());
+#endif /* CONFIG_ELOG_BOOT_COUNT */
/* Check and log POST codes from previous boot */
- if (CONFIG_CMOS_POST)
- cmos_post_log();
+#if CONFIG_CMOS_POST == 1
+ cmos_post_log();
+#endif /* CONFIG_CMOS_POST */
#endif
return 0;