coreboot-gerrit March 2014

coreboot-gerrit@coreboot.org

1 participants
584 discussions

Patch set updated for coreboot: aa0ac5c superio/fintek/f71872: [3/5] Avoid .c includes
by Edward O'Callaghan 31 Mar '14

31 Mar '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5436 -gerrit commit aa0ac5c764e77978d79d981d6a87e883d77b3651 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Mon Mar 31 15:13:07 2014 +1100 superio/fintek/f71872: [3/5] Avoid .c includes Following the same reasoning as commit d3043313a91dff3bc2f879ffb3b4bf23a364d711 superio/fintek/f81865f: Avoid .c includes Clean up the early_serial #include directives in mainboard/romstage code. Change-Id: Ia021229154dc90b830a314f3adc2a0dd444bd68d Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/superio/fintek/f71872/Makefile.inc | 1 + src/superio/fintek/f71872/chip.h | 2 +- src/superio/fintek/f71872/early_serial.c | 3 ++- src/superio/fintek/f71872/f71872.h | 4 +++- 4 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/superio/fintek/f71872/Makefile.inc b/src/superio/fintek/f71872/Makefile.inc index ed40eb0..58ba5d5 100644 --- a/src/superio/fintek/f71872/Makefile.inc +++ b/src/superio/fintek/f71872/Makefile.inc @@ -18,4 +18,5 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## +romstage-$(CONFIG_SUPERIO_FINTEK_F71872) += early_serial.c ramstage-$(CONFIG_SUPERIO_FINTEK_F71872) += superio.c diff --git a/src/superio/fintek/f71872/chip.h b/src/superio/fintek/f71872/chip.h index a6ac51f..3368ef2 100644 --- a/src/superio/fintek/f71872/chip.h +++ b/src/superio/fintek/f71872/chip.h @@ -28,4 +28,4 @@ struct superio_fintek_f71872_config { struct pc_keyboard keyboard; }; -#endif +#endif /* SUPERIO_FINTEK_F71872_CHIP_H */ diff --git a/src/superio/fintek/f71872/early_serial.c b/src/superio/fintek/f71872/early_serial.c index af5cdb3..bbfc264 100644 --- a/src/superio/fintek/f71872/early_serial.c +++ b/src/superio/fintek/f71872/early_serial.c @@ -21,6 +21,7 @@ /* Pre-RAM driver for the Fintek F71872F/FG Super I/O chip. */ #include <arch/io.h> +#include <device/pnp.h> #include "f71872.h" static void pnp_enter_conf_state(device_t dev) @@ -36,7 +37,7 @@ static void pnp_exit_conf_state(device_t dev) outb(0xaa, port); } -static void f71872_enable_serial(device_t dev, u16 iobase) +void f71872_enable_serial(device_t dev, u16 iobase) { pnp_enter_conf_state(dev); pnp_set_logical_device(dev); diff --git a/src/superio/fintek/f71872/f71872.h b/src/superio/fintek/f71872/f71872.h index 585b142..577f8d1 100644 --- a/src/superio/fintek/f71872/f71872.h +++ b/src/superio/fintek/f71872/f71872.h @@ -32,4 +32,6 @@ #define F71872_VID 0x07 /* VID */ #define F71872_PM 0x0a /* ACPI/PME */ -#endif +void f71872_enable_serial(device_t dev, u16 iobase); + +#endif /* SUPERIO_FINTEK_F71872_F71872_H */

1 0

Patch set updated for coreboot: 2b44c33 superio/fintek/f71863fg: [2/5] Avoid .c includes
by Edward O'Callaghan 31 Mar '14

31 Mar '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5435 -gerrit commit 2b44c339c7511fbbf9b036557adfda651a4b6f17 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Mon Mar 31 15:08:35 2014 +1100 superio/fintek/f71863fg: [2/5] Avoid .c includes Following the same reasoning as commit d3043313a91dff3bc2f879ffb3b4bf23a364d711 superio/fintek/f81865f: Avoid .c includes Clean up the early_serial #include directives in mainboard/romstage code. Change-Id: I863c16634873224c17e43100271e9b91419724d0 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/mainboard/jetway/pa78vm5/romstage.c | 2 +- src/superio/fintek/f71863fg/Makefile.inc | 2 +- src/superio/fintek/f71863fg/chip.h | 2 +- src/superio/fintek/f71863fg/early_serial.c | 3 ++- src/superio/fintek/f71863fg/f71863fg.h | 4 +++- 5 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/mainboard/jetway/pa78vm5/romstage.c b/src/mainboard/jetway/pa78vm5/romstage.c index b8fa48e..c082a67 100644 --- a/src/mainboard/jetway/pa78vm5/romstage.c +++ b/src/mainboard/jetway/pa78vm5/romstage.c @@ -42,7 +42,7 @@ #include "northbridge/amd/amdfam10/reset_test.c" #include <console/loglevel.h> #include "cpu/x86/bist.h" -#include "superio/fintek/f71863fg/early_serial.c" +#include <superio/fintek/f71863fg/f71863fg.h> #include <cpu/amd/mtrr.h> #include "northbridge/amd/amdfam10/setup_resource_map.c" #include "southbridge/amd/rs780/early_setup.c" diff --git a/src/superio/fintek/f71863fg/Makefile.inc b/src/superio/fintek/f71863fg/Makefile.inc index 0deb77e..85ec530 100644 --- a/src/superio/fintek/f71863fg/Makefile.inc +++ b/src/superio/fintek/f71863fg/Makefile.inc @@ -18,5 +18,5 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## +romstage-$(CONFIG_SUPERIO_FINTEK_F71863FG) += early_serial.c ramstage-$(CONFIG_SUPERIO_FINTEK_F71863FG) += superio.c - diff --git a/src/superio/fintek/f71863fg/chip.h b/src/superio/fintek/f71863fg/chip.h index 9084824..4d2652e 100644 --- a/src/superio/fintek/f71863fg/chip.h +++ b/src/superio/fintek/f71863fg/chip.h @@ -29,4 +29,4 @@ struct superio_fintek_f71863fg_config { struct pc_keyboard keyboard; }; -#endif +#endif /* SUPERIO_FINTEK_F71863FG_CHIP_H */ diff --git a/src/superio/fintek/f71863fg/early_serial.c b/src/superio/fintek/f71863fg/early_serial.c index 5d1cfb7..251f298 100644 --- a/src/superio/fintek/f71863fg/early_serial.c +++ b/src/superio/fintek/f71863fg/early_serial.c @@ -21,6 +21,7 @@ /* Pre-RAM driver for the Fintek F71863FG Super I/O chip. */ #include <arch/io.h> +#include <device/pnp.h> #include "f71863fg.h" static void pnp_enter_conf_state(device_t dev) @@ -36,7 +37,7 @@ static void pnp_exit_conf_state(device_t dev) outb(0xaa, port); } -static void f71863fg_enable_serial(device_t dev, u16 iobase) +void f71863fg_enable_serial(device_t dev, u16 iobase) { pnp_enter_conf_state(dev); pnp_set_logical_device(dev); diff --git a/src/superio/fintek/f71863fg/f71863fg.h b/src/superio/fintek/f71863fg/f71863fg.h index 5f11879..127a120 100644 --- a/src/superio/fintek/f71863fg/f71863fg.h +++ b/src/superio/fintek/f71863fg/f71863fg.h @@ -33,4 +33,6 @@ #define F71863FG_SPI 0x08 /* SPI */ #define F71863FG_PME 0x0a /* Power Management Events (PME) and ACPI */ -#endif +void f71863fg_enable_serial(device_t dev, u16 iobase); + +#endif /* SUPERIO_FINTEK_F71863FG_F71863FG_H */

1 0

Patch set updated for coreboot: 5999cf0 superio/fintek/f71805f: [1/5] Avoid .c includes
by Edward O'Callaghan 31 Mar '14

31 Mar '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5434 -gerrit commit 5999cf09690ba25fb803e4650ed1b2f61b355de3 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Mon Mar 31 15:01:16 2014 +1100 superio/fintek/f71805f: [1/5] Avoid .c includes Following the same reasoning as commit d3043313a91dff3bc2f879ffb3b4bf23a364d711 superio/fintek/f81865f: Avoid .c includes Clean up the early_serial #include directives in mainboard/romstage code. Change-Id: Ibf743f7a5dd4a424a4513014fc9a896b87ecf3b1 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/mainboard/jetway/j7f2/romstage.c | 2 +- src/superio/fintek/f71805f/Makefile.inc | 2 +- src/superio/fintek/f71805f/early_serial.c | 3 ++- src/superio/fintek/f71805f/f71805f.h | 4 +++- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/mainboard/jetway/j7f2/romstage.c b/src/mainboard/jetway/j7f2/romstage.c index 928fcef..37c3ab4 100644 --- a/src/mainboard/jetway/j7f2/romstage.c +++ b/src/mainboard/jetway/j7f2/romstage.c @@ -31,7 +31,7 @@ #include "drivers/pc80/udelay_io.c" #include "lib/delay.c" #include "southbridge/via/vt8237r/early_smbus.c" -#include "superio/fintek/f71805f/early_serial.c" +#include <superio/fintek/f71805f/f71805f.h> #include <lib.h> #include <spd.h> diff --git a/src/superio/fintek/f71805f/Makefile.inc b/src/superio/fintek/f71805f/Makefile.inc index 9ed5e6f..22c01e0 100644 --- a/src/superio/fintek/f71805f/Makefile.inc +++ b/src/superio/fintek/f71805f/Makefile.inc @@ -18,5 +18,5 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## +romstage-$(CONFIG_SUPERIO_FINTEK_F71805F) += early_serial.c ramstage-$(CONFIG_SUPERIO_FINTEK_F71805F) += superio.c - diff --git a/src/superio/fintek/f71805f/early_serial.c b/src/superio/fintek/f71805f/early_serial.c index 827f870..b823a43 100644 --- a/src/superio/fintek/f71805f/early_serial.c +++ b/src/superio/fintek/f71805f/early_serial.c @@ -21,6 +21,7 @@ /* Pre-RAM driver for the Fintek F71805F/FG Super I/O chip. */ #include <arch/io.h> +#include <device/pnp.h> #include "f71805f.h" static void pnp_enter_conf_state(device_t dev) @@ -36,7 +37,7 @@ static void pnp_exit_conf_state(device_t dev) outb(0xaa, port); } -static void f71805f_enable_serial(device_t dev, u16 iobase) +void f71805f_enable_serial(device_t dev, u16 iobase) { pnp_enter_conf_state(dev); pnp_set_logical_device(dev); diff --git a/src/superio/fintek/f71805f/f71805f.h b/src/superio/fintek/f71805f/f71805f.h index 0670128..6aae58f 100644 --- a/src/superio/fintek/f71805f/f71805f.h +++ b/src/superio/fintek/f71805f/f71805f.h @@ -38,4 +38,6 @@ #define F71805F_GPIO 0x06 /* General Purpose I/O (GPIO) */ #define F71805F_PME 0x0a /* Power Management Events (PME) */ -#endif +void f71805f_enable_serial(device_t dev, u16 iobase); + +#endif /* SUPERIO_FINTEK_F71805F_F71805F_H */

1 0

Patch set updated for coreboot: bd553b7 superio/fintek/f71859: [5/5] Avoid .c includes
by Edward O'Callaghan 31 Mar '14

31 Mar '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5417 -gerrit commit bd553b71aba523556d5c29b3d4acadc40d4cece1 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Sat Mar 29 20:42:58 2014 +1100 superio/fintek/f71859: [5/5] Avoid .c includes Following the same reasoning as commit d3043313a91dff3bc2f879ffb3b4bf23a364d711 superio/fintek/f81865f: Avoid .c includes Clean up the early_serial #include directives in mainboard/romstage code. Change-Id: I3577ca3f761fb699dc51141a02e1f853bf1f1a21 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/mainboard/iei/kino-780am2-fam10/romstage.c | 2 +- src/superio/fintek/f71859/Makefile.inc | 2 +- src/superio/fintek/f71859/early_serial.c | 3 ++- src/superio/fintek/f71859/f71859.h | 4 +++- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/mainboard/iei/kino-780am2-fam10/romstage.c b/src/mainboard/iei/kino-780am2-fam10/romstage.c index e5e2c57..299ba61 100644 --- a/src/mainboard/iei/kino-780am2-fam10/romstage.c +++ b/src/mainboard/iei/kino-780am2-fam10/romstage.c @@ -41,7 +41,7 @@ #include "northbridge/amd/amdfam10/reset_test.c" #include <console/loglevel.h> #include "cpu/x86/bist.h" -#include "superio/fintek/f71859/early_serial.c" +#include <superio/fintek/f71859/f71859.h> #include <cpu/amd/mtrr.h> #include "northbridge/amd/amdfam10/setup_resource_map.c" #include "southbridge/amd/rs780/early_setup.c" diff --git a/src/superio/fintek/f71859/Makefile.inc b/src/superio/fintek/f71859/Makefile.inc index bf150da..8858811 100644 --- a/src/superio/fintek/f71859/Makefile.inc +++ b/src/superio/fintek/f71859/Makefile.inc @@ -18,5 +18,5 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## +romstage-$(CONFIG_SUPERIO_FINTEK_F71859) += early_serial.c ramstage-$(CONFIG_SUPERIO_FINTEK_F71859) += superio.c - diff --git a/src/superio/fintek/f71859/early_serial.c b/src/superio/fintek/f71859/early_serial.c index 4401714..cb0d3de 100644 --- a/src/superio/fintek/f71859/early_serial.c +++ b/src/superio/fintek/f71859/early_serial.c @@ -21,6 +21,7 @@ /* Pre-RAM driver for the Fintek F71859 Super I/O chip. */ #include <arch/io.h> +#include <device/pnp.h> #include "f71859.h" static void pnp_enter_conf_state(device_t dev) @@ -36,7 +37,7 @@ static void pnp_exit_conf_state(device_t dev) outb(0xaa, port); } -static void f71859_enable_serial(device_t dev, u16 iobase) +void f71859_enable_serial(device_t dev, u16 iobase) { pnp_enter_conf_state(dev); pnp_set_logical_device(dev); diff --git a/src/superio/fintek/f71859/f71859.h b/src/superio/fintek/f71859/f71859.h index 2c89d19..580fa34 100644 --- a/src/superio/fintek/f71859/f71859.h +++ b/src/superio/fintek/f71859/f71859.h @@ -24,4 +24,6 @@ /* Logical Device Numbers (LDN). */ #define F71859_SP1 0x03 /* UART1 */ -#endif +void f71859_enable_serial(device_t dev, u16 iobase); + +#endif /* SUPERIO_FINTEK_F71859_F71859_H */

1 0

New patch to review for coreboot: 17c7c70 superio/fintek/f71889: [4/4] Avoid .c includes
by Edward O'Callaghan 31 Mar '14

31 Mar '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5437 -gerrit commit 17c7c70d5ee761a0652876545fc108bf91d58300 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Mon Mar 31 15:14:14 2014 +1100 superio/fintek/f71889: [4/4] Avoid .c includes Following the same reasoning as commit d3043313a91dff3bc2f879ffb3b4bf23a364d711 superio/fintek/f81865f: Avoid .c includes Clean up the early_serial #include directives in mainboard/romstage code. Change-Id: Id8a1a2e8c87add636af1506598c2669d72dc3238 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/superio/fintek/f71889/Makefile.inc | 2 +- src/superio/fintek/f71889/chip.h | 2 +- src/superio/fintek/f71889/early_serial.c | 2 +- src/superio/fintek/f71889/f71889.h | 4 +++- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/superio/fintek/f71889/Makefile.inc b/src/superio/fintek/f71889/Makefile.inc index ef14b74..9864140 100644 --- a/src/superio/fintek/f71889/Makefile.inc +++ b/src/superio/fintek/f71889/Makefile.inc @@ -18,5 +18,5 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## +romstage-$(CONFIG_SUPERIO_FINTEK_F71889) += early_serial.c ramstage-$(CONFIG_SUPERIO_FINTEK_F71889) += superio.c - diff --git a/src/superio/fintek/f71889/chip.h b/src/superio/fintek/f71889/chip.h index 2895efc..50312ad 100644 --- a/src/superio/fintek/f71889/chip.h +++ b/src/superio/fintek/f71889/chip.h @@ -29,4 +29,4 @@ struct superio_fintek_f71889_config { struct pc_keyboard keyboard; }; -#endif +#endif /* SUPERIO_FINTEK_F71889_CHIP_H */ diff --git a/src/superio/fintek/f71889/early_serial.c b/src/superio/fintek/f71889/early_serial.c index 9623cbd..7ab8946 100644 --- a/src/superio/fintek/f71889/early_serial.c +++ b/src/superio/fintek/f71889/early_serial.c @@ -35,7 +35,7 @@ static void pnp_exit_conf_state(device_t dev) outb(0xaa, port); } -static void f71889_enable_serial(device_t dev, u16 iobase) +void f71889_enable_serial(device_t dev, u16 iobase) { pnp_enter_conf_state(dev); pnp_set_logical_device(dev); diff --git a/src/superio/fintek/f71889/f71889.h b/src/superio/fintek/f71889/f71889.h index 1b6a369..6dc43b3 100644 --- a/src/superio/fintek/f71889/f71889.h +++ b/src/superio/fintek/f71889/f71889.h @@ -34,4 +34,6 @@ #define F71889_PME 0x0a /* Power Management Events (PME) and ACPI */ #define F71889_VREF 0x0b /* Vref */ -#endif +void f71889_enable_serial(device_t dev, u16 iobase); + +#endif /* SUPERIO_FINTEK_F71889_F71889_H */

1 0

New patch to review for coreboot: 6d69996 superio/fintek/f71872: [3/4] Avoid .c includes
by Edward O'Callaghan 31 Mar '14

31 Mar '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5436 -gerrit commit 6d69996950e198ec5bb1836d958fa79404579872 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Mon Mar 31 15:13:07 2014 +1100 superio/fintek/f71872: [3/4] Avoid .c includes Following the same reasoning as commit d3043313a91dff3bc2f879ffb3b4bf23a364d711 superio/fintek/f81865f: Avoid .c includes Clean up the early_serial #include directives in mainboard/romstage code. Change-Id: Ia021229154dc90b830a314f3adc2a0dd444bd68d Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/superio/fintek/f71872/Makefile.inc | 1 + src/superio/fintek/f71872/chip.h | 2 +- src/superio/fintek/f71872/early_serial.c | 2 +- src/superio/fintek/f71872/f71872.h | 4 +++- 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/superio/fintek/f71872/Makefile.inc b/src/superio/fintek/f71872/Makefile.inc index ed40eb0..58ba5d5 100644 --- a/src/superio/fintek/f71872/Makefile.inc +++ b/src/superio/fintek/f71872/Makefile.inc @@ -18,4 +18,5 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## +romstage-$(CONFIG_SUPERIO_FINTEK_F71872) += early_serial.c ramstage-$(CONFIG_SUPERIO_FINTEK_F71872) += superio.c diff --git a/src/superio/fintek/f71872/chip.h b/src/superio/fintek/f71872/chip.h index a6ac51f..3368ef2 100644 --- a/src/superio/fintek/f71872/chip.h +++ b/src/superio/fintek/f71872/chip.h @@ -28,4 +28,4 @@ struct superio_fintek_f71872_config { struct pc_keyboard keyboard; }; -#endif +#endif /* SUPERIO_FINTEK_F71872_CHIP_H */ diff --git a/src/superio/fintek/f71872/early_serial.c b/src/superio/fintek/f71872/early_serial.c index af5cdb3..3de7c90 100644 --- a/src/superio/fintek/f71872/early_serial.c +++ b/src/superio/fintek/f71872/early_serial.c @@ -36,7 +36,7 @@ static void pnp_exit_conf_state(device_t dev) outb(0xaa, port); } -static void f71872_enable_serial(device_t dev, u16 iobase) +void f71872_enable_serial(device_t dev, u16 iobase) { pnp_enter_conf_state(dev); pnp_set_logical_device(dev); diff --git a/src/superio/fintek/f71872/f71872.h b/src/superio/fintek/f71872/f71872.h index 585b142..577f8d1 100644 --- a/src/superio/fintek/f71872/f71872.h +++ b/src/superio/fintek/f71872/f71872.h @@ -32,4 +32,6 @@ #define F71872_VID 0x07 /* VID */ #define F71872_PM 0x0a /* ACPI/PME */ -#endif +void f71872_enable_serial(device_t dev, u16 iobase); + +#endif /* SUPERIO_FINTEK_F71872_F71872_H */

1 0

New patch to review for coreboot: 13747f8 superio/fintek/f71863fg: [2/4] Avoid .c includes
by Edward O'Callaghan 31 Mar '14

31 Mar '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5435 -gerrit commit 13747f85210831144409c8684f11e8654a951047 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Mon Mar 31 15:08:35 2014 +1100 superio/fintek/f71863fg: [2/4] Avoid .c includes Following the same reasoning as commit d3043313a91dff3bc2f879ffb3b4bf23a364d711 superio/fintek/f81865f: Avoid .c includes Clean up the early_serial #include directives in mainboard/romstage code. Change-Id: I863c16634873224c17e43100271e9b91419724d0 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/mainboard/jetway/pa78vm5/romstage.c | 2 +- src/superio/fintek/f71863fg/Makefile.inc | 2 +- src/superio/fintek/f71863fg/chip.h | 2 +- src/superio/fintek/f71863fg/early_serial.c | 2 +- src/superio/fintek/f71863fg/f71863fg.h | 4 +++- 5 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/mainboard/jetway/pa78vm5/romstage.c b/src/mainboard/jetway/pa78vm5/romstage.c index b8fa48e..c082a67 100644 --- a/src/mainboard/jetway/pa78vm5/romstage.c +++ b/src/mainboard/jetway/pa78vm5/romstage.c @@ -42,7 +42,7 @@ #include "northbridge/amd/amdfam10/reset_test.c" #include <console/loglevel.h> #include "cpu/x86/bist.h" -#include "superio/fintek/f71863fg/early_serial.c" +#include <superio/fintek/f71863fg/f71863fg.h> #include <cpu/amd/mtrr.h> #include "northbridge/amd/amdfam10/setup_resource_map.c" #include "southbridge/amd/rs780/early_setup.c" diff --git a/src/superio/fintek/f71863fg/Makefile.inc b/src/superio/fintek/f71863fg/Makefile.inc index 0deb77e..85ec530 100644 --- a/src/superio/fintek/f71863fg/Makefile.inc +++ b/src/superio/fintek/f71863fg/Makefile.inc @@ -18,5 +18,5 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## +romstage-$(CONFIG_SUPERIO_FINTEK_F71863FG) += early_serial.c ramstage-$(CONFIG_SUPERIO_FINTEK_F71863FG) += superio.c - diff --git a/src/superio/fintek/f71863fg/chip.h b/src/superio/fintek/f71863fg/chip.h index 9084824..4d2652e 100644 --- a/src/superio/fintek/f71863fg/chip.h +++ b/src/superio/fintek/f71863fg/chip.h @@ -29,4 +29,4 @@ struct superio_fintek_f71863fg_config { struct pc_keyboard keyboard; }; -#endif +#endif /* SUPERIO_FINTEK_F71863FG_CHIP_H */ diff --git a/src/superio/fintek/f71863fg/early_serial.c b/src/superio/fintek/f71863fg/early_serial.c index 5d1cfb7..2daadbe 100644 --- a/src/superio/fintek/f71863fg/early_serial.c +++ b/src/superio/fintek/f71863fg/early_serial.c @@ -36,7 +36,7 @@ static void pnp_exit_conf_state(device_t dev) outb(0xaa, port); } -static void f71863fg_enable_serial(device_t dev, u16 iobase) +void f71863fg_enable_serial(device_t dev, u16 iobase) { pnp_enter_conf_state(dev); pnp_set_logical_device(dev); diff --git a/src/superio/fintek/f71863fg/f71863fg.h b/src/superio/fintek/f71863fg/f71863fg.h index 5f11879..127a120 100644 --- a/src/superio/fintek/f71863fg/f71863fg.h +++ b/src/superio/fintek/f71863fg/f71863fg.h @@ -33,4 +33,6 @@ #define F71863FG_SPI 0x08 /* SPI */ #define F71863FG_PME 0x0a /* Power Management Events (PME) and ACPI */ -#endif +void f71863fg_enable_serial(device_t dev, u16 iobase); + +#endif /* SUPERIO_FINTEK_F71863FG_F71863FG_H */

1 0

Patch set updated for coreboot: addbf61 superio/fintek/f71805f: [1/4] Avoid .c includes
by Edward O'Callaghan 31 Mar '14

31 Mar '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5434 -gerrit commit addbf617c0a8c50ae12ff381389bbd5c4e1b8b0b Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Mon Mar 31 15:01:16 2014 +1100 superio/fintek/f71805f: [1/4] Avoid .c includes Following the same reasoning as commit d3043313a91dff3bc2f879ffb3b4bf23a364d711 superio/fintek/f81865f: Avoid .c includes Clean up the early_serial #include directives in mainboard/romstage code. Change-Id: Ibf743f7a5dd4a424a4513014fc9a896b87ecf3b1 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/mainboard/jetway/j7f2/romstage.c | 2 +- src/superio/fintek/f71805f/Makefile.inc | 2 +- src/superio/fintek/f71805f/early_serial.c | 3 ++- src/superio/fintek/f71805f/f71805f.h | 4 +++- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/mainboard/jetway/j7f2/romstage.c b/src/mainboard/jetway/j7f2/romstage.c index 928fcef..37c3ab4 100644 --- a/src/mainboard/jetway/j7f2/romstage.c +++ b/src/mainboard/jetway/j7f2/romstage.c @@ -31,7 +31,7 @@ #include "drivers/pc80/udelay_io.c" #include "lib/delay.c" #include "southbridge/via/vt8237r/early_smbus.c" -#include "superio/fintek/f71805f/early_serial.c" +#include <superio/fintek/f71805f/f71805f.h> #include <lib.h> #include <spd.h> diff --git a/src/superio/fintek/f71805f/Makefile.inc b/src/superio/fintek/f71805f/Makefile.inc index 9ed5e6f..22c01e0 100644 --- a/src/superio/fintek/f71805f/Makefile.inc +++ b/src/superio/fintek/f71805f/Makefile.inc @@ -18,5 +18,5 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## +romstage-$(CONFIG_SUPERIO_FINTEK_F71805F) += early_serial.c ramstage-$(CONFIG_SUPERIO_FINTEK_F71805F) += superio.c - diff --git a/src/superio/fintek/f71805f/early_serial.c b/src/superio/fintek/f71805f/early_serial.c index 827f870..b823a43 100644 --- a/src/superio/fintek/f71805f/early_serial.c +++ b/src/superio/fintek/f71805f/early_serial.c @@ -21,6 +21,7 @@ /* Pre-RAM driver for the Fintek F71805F/FG Super I/O chip. */ #include <arch/io.h> +#include <device/pnp.h> #include "f71805f.h" static void pnp_enter_conf_state(device_t dev) @@ -36,7 +37,7 @@ static void pnp_exit_conf_state(device_t dev) outb(0xaa, port); } -static void f71805f_enable_serial(device_t dev, u16 iobase) +void f71805f_enable_serial(device_t dev, u16 iobase) { pnp_enter_conf_state(dev); pnp_set_logical_device(dev); diff --git a/src/superio/fintek/f71805f/f71805f.h b/src/superio/fintek/f71805f/f71805f.h index 0670128..6aae58f 100644 --- a/src/superio/fintek/f71805f/f71805f.h +++ b/src/superio/fintek/f71805f/f71805f.h @@ -38,4 +38,6 @@ #define F71805F_GPIO 0x06 /* General Purpose I/O (GPIO) */ #define F71805F_PME 0x0a /* Power Management Events (PME) */ -#endif +void f71805f_enable_serial(device_t dev, u16 iobase); + +#endif /* SUPERIO_FINTEK_F71805F_F71805F_H */

1 0

New patch to review for coreboot: 626beed superio/fintek/f71805f: Avoid .c includes
by Edward O'Callaghan 31 Mar '14

31 Mar '14

Edward O'Callaghan (eocallaghan(a)alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5434 -gerrit commit 626beed9c7a29b807797fe40c2882c9dcead5465 Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Mon Mar 31 15:01:16 2014 +1100 superio/fintek/f71805f: Avoid .c includes Following the same reasoning as commit d3043313a91dff3bc2f879ffb3b4bf23a364d711 superio/fintek/f81865f: Avoid .c includes Clean up the early_serial #include directives in mainboard/romstage code. Change-Id: Ibf743f7a5dd4a424a4513014fc9a896b87ecf3b1 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> --- src/mainboard/jetway/j7f2/romstage.c | 2 +- src/superio/fintek/f71805f/Makefile.inc | 2 +- src/superio/fintek/f71805f/early_serial.c | 3 ++- src/superio/fintek/f71805f/f71805f.h | 4 +++- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/mainboard/jetway/j7f2/romstage.c b/src/mainboard/jetway/j7f2/romstage.c index 928fcef..37c3ab4 100644 --- a/src/mainboard/jetway/j7f2/romstage.c +++ b/src/mainboard/jetway/j7f2/romstage.c @@ -31,7 +31,7 @@ #include "drivers/pc80/udelay_io.c" #include "lib/delay.c" #include "southbridge/via/vt8237r/early_smbus.c" -#include "superio/fintek/f71805f/early_serial.c" +#include <superio/fintek/f71805f/f71805f.h> #include <lib.h> #include <spd.h> diff --git a/src/superio/fintek/f71805f/Makefile.inc b/src/superio/fintek/f71805f/Makefile.inc index 9ed5e6f..22c01e0 100644 --- a/src/superio/fintek/f71805f/Makefile.inc +++ b/src/superio/fintek/f71805f/Makefile.inc @@ -18,5 +18,5 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## +romstage-$(CONFIG_SUPERIO_FINTEK_F71805F) += early_serial.c ramstage-$(CONFIG_SUPERIO_FINTEK_F71805F) += superio.c - diff --git a/src/superio/fintek/f71805f/early_serial.c b/src/superio/fintek/f71805f/early_serial.c index 827f870..b823a43 100644 --- a/src/superio/fintek/f71805f/early_serial.c +++ b/src/superio/fintek/f71805f/early_serial.c @@ -21,6 +21,7 @@ /* Pre-RAM driver for the Fintek F71805F/FG Super I/O chip. */ #include <arch/io.h> +#include <device/pnp.h> #include "f71805f.h" static void pnp_enter_conf_state(device_t dev) @@ -36,7 +37,7 @@ static void pnp_exit_conf_state(device_t dev) outb(0xaa, port); } -static void f71805f_enable_serial(device_t dev, u16 iobase) +void f71805f_enable_serial(device_t dev, u16 iobase) { pnp_enter_conf_state(dev); pnp_set_logical_device(dev); diff --git a/src/superio/fintek/f71805f/f71805f.h b/src/superio/fintek/f71805f/f71805f.h index 0670128..6aae58f 100644 --- a/src/superio/fintek/f71805f/f71805f.h +++ b/src/superio/fintek/f71805f/f71805f.h @@ -38,4 +38,6 @@ #define F71805F_GPIO 0x06 /* General Purpose I/O (GPIO) */ #define F71805F_PME 0x0a /* Power Management Events (PME) */ -#endif +void f71805f_enable_serial(device_t dev, u16 iobase); + +#endif /* SUPERIO_FINTEK_F71805F_F71805F_H */

1 0

Patch merged into coreboot/master: 4866a57 superio/fintek/f81865f: Avoid .c includes
by gerrit＠coreboot.org 31 Mar '14

31 Mar '14

the following patch was just integrated into master: commit 4866a57812216ec53c410baff63bfda2f12863ee Author: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Date: Sat Mar 29 20:28:03 2014 +1100 superio/fintek/f81865f: Avoid .c includes We should not be #include .c files, instead link early_serial into romstage and provide a prototype. Change-Id: Ia9277169ce1592e1fc72f8849f0982741daec567 Signed-off-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> See http://review.coreboot.org/5416 for details. -gerrit

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2014