the following patch was just integrated into master:
commit 617f853ae43ce1c15fbec1ecba2aa5624f6b4c7d
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Sat Nov 23 14:46:34 2013 +0100
lib/coreboot_table: set type and size of framebuffer tag after fill_lb_framebuffer
When testing Ron's patch on qemu I found out that fill_lb_framebuffer
overwrites size and tag fields. We need either to fix/check all
fill_lb_framebuffer implementations or write tag/size after fill_lb_framebuffer.
I prefer later as it's more robust.
Change-Id: I98f5bac14f65fb4d990cb21426d402b27f2e8a48
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
Reviewed-on: http://review.coreboot.org/4263
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com>
See http://review.coreboot.org/4263 for details.
-gerrit
Vladimir Serbinenko (phcoder(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4263
-gerrit
commit 45735d818e4b971a3e4952b6a8f149e494d0d2ab
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Sat Nov 23 14:46:34 2013 +0100
lib/coreboot_table: set type and size of framebuffer tag after fill_lb_framebuffer
When testing Ron's patch on qemu I found out that fill_lb_framebuffer
overwrites size and tag fields. We need either to fix/check all
fill_lb_framebuffer implementations or write tag/size after fill_lb_framebuffer.
I prefer later as it's more robust.
Change-Id: I98f5bac14f65fb4d990cb21426d402b27f2e8a48
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
---
src/lib/coreboot_table.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c
index e5729ba..a0a806d 100644
--- a/src/lib/coreboot_table.c
+++ b/src/lib/coreboot_table.c
@@ -177,9 +177,9 @@ static void lb_framebuffer(struct lb_header *header)
return;
struct lb_framebuffer *framebuffer;
framebuffer = (struct lb_framebuffer *)lb_new_record(header);
+ fill_lb_framebuffer(framebuffer);
framebuffer->tag = LB_TAG_FRAMEBUFFER;
framebuffer->size = sizeof(*framebuffer);
- fill_lb_framebuffer(framebuffer);
#endif
}
the following patch was just integrated into master:
commit 71f35ebdaab56e4ff1d4d882d2cd4f29bda1aacc
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Tue Nov 12 23:32:52 2013 +0100
Rename SANDYBRIDGE_BCLK to NEHALEM_BCLK in 2065x.
2065x is with nehalem and not sandybridge.
I don't care much eitherway but it clears some confusion.
Change-Id: Ib2b8e570b830a12ed8d0d313ee4eb56755796d4b
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
Reviewed-on: http://review.coreboot.org/4046
Tested-by: build bot (Jenkins)
Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
See http://review.coreboot.org/4046 for details.
-gerrit
the following patch was just integrated into master:
commit e2b6795e046894487863e4bc9e29aa075dfcc3f6
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Thu Nov 14 19:09:42 2013 +0100
Call X201 dock hooks in EC code
Unlike on X60/T60 dock has to be inited at the same time as EC.
Change-Id: If6eb3140c871859ce99027a50908f72bcc560243
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
Reviewed-on: http://review.coreboot.org/4082
Reviewed-by: Idwer Vollering <vidwer(a)gmail.com>
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
See http://review.coreboot.org/4082 for details.
-gerrit
the following patch was just integrated into master:
commit 75b90a1f50f15b8ccb814d005c840d189d512f26
Author: Vladimir Serbinenko <phcoder(a)gmail.com>
Date: Thu Nov 14 18:49:26 2013 +0100
Remove MRC variables from 2065x CAR init.
2065x boards don't use MRC. And the space in question isn't used either.
Read number of variable range MTRRs from MSR rather than hardcoding it.
2ff is still zeroed out as unless you zero-out undocumented bits as well
boot fails.
Tested on Lenovo X201.
Change-Id: Ic574193094e7d27c2d6a4d7d3e387d989578532e
Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com>
Reviewed-on: http://review.coreboot.org/4080
Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Tested-by: build bot (Jenkins)
See http://review.coreboot.org/4080 for details.
-gerrit