Felix Held has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/82192?usp=email )
Change subject: include/device: Fix IO resource handling covering 0xFFFF ......................................................................
Patch Set 3:
(1 comment)
File src/include/device/device.h:
https://review.coreboot.org/c/coreboot/+/82192/comment/d1a514bf_b6c72a28?usp... : PS1, Line 377: end - base
Yes ... For the end-base I kept it as uint16_t due to that will not be exceeded in actual cases.
eventually we should change the whole resource api so that the end parameter of the *_from_to functions is the last location instead of the location after the region. the current behavior has bugged me for a while, but haven't gotten around to look into changing this. might be that Kyosti's patch train that has been abandoned long time ago did that in one of the later patches after the not-for-merge patch that didn't end up getting submitted
-
Felix Held (Code Review)