Change in coreboot[master]: tigerlake: add unique acpi device ids for dptf

[Sumeet R Pawnikar (Code Review)]

Sumeet R Pawnikar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42040 )

Change subject: tigerlake: add unique acpi device ids for dptf
......................................................................

tigerlake: add unique acpi device ids for dptf

Add unique new acpi device ids for dptf for Tigerlake soc based platforms

BUG=None
BRANCH=None
TEST=Build and boot on volteer system

Change-Id: I7dbb812c0fc0f5084c98cf2752ce7ddce8e4d50e
Signed-off-by: Sumeet R Pawnikar 
---
M src/mainboard/google/volteer/dsdt.asl
A src/soc/intel/tigerlake/acpi/dptf.asl
2 files changed, 45 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/42040/1

diff --git a/src/mainboard/google/volteer/dsdt.asl b/src/mainboard/google/volteer/dsdt.asl
index fa39e79..62ddc15 100644
--- a/src/mainboard/google/volteer/dsdt.asl
+++ b/src/mainboard/google/volteer/dsdt.asl
@@ -57,8 +57,8 @@
    {
    	/* Per board variant specific definitions. */
    	#include <variant/acpi/dptf.asl>
-		/* Include soc specific DPTF changes */
-		#include <soc/intel/common/acpi/dptf.asl>
+		/* Include Tigerlake soc specific DPTF changes */
+		#include <soc/intel/tigerlake/acpi/dptf.asl>
    	/* Include common dptf ASL files */
    	#include <soc/intel/common/acpi/dptf/dptf.asl>
    }
diff --git a/src/soc/intel/tigerlake/acpi/dptf.asl b/src/soc/intel/tigerlake/acpi/dptf.asl
new file mode 100644
index 0000000..cc7ce4f
--- /dev/null
+++ b/src/soc/intel/tigerlake/acpi/dptf.asl
@@ -0,0 +1,43 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#define DPTF_CPU_DEVICE			TCPU
+#define DPTF_CPU_ADDR			0x00040000
+
+#ifndef DPTF_CPU_PASSIVE
+#define DPTF_CPU_PASSIVE		80
+#endif
+
+#ifndef DPTF_CPU_CRITICAL
+#define DPTF_CPU_CRITICAL		90
+#endif
+
+#ifndef DPTF_CPU_ACTIVE_AC0
+#define DPTF_CPU_ACTIVE_AC0		90
+#endif
+
+#ifndef DPTF_CPU_ACTIVE_AC1
+#define DPTF_CPU_ACTIVE_AC1		80
+#endif
+
+#ifndef DPTF_CPU_ACTIVE_AC2
+#define DPTF_CPU_ACTIVE_AC2		70
+#endif
+
+#ifndef DPTF_CPU_ACTIVE_AC3
+#define DPTF_CPU_ACTIVE_AC3		60
+#endif
+
+#ifndef DPTF_CPU_ACTIVE_AC4
+#define DPTF_CPU_ACTIVE_AC4		50
+#endif
+
+/* Below are the unique ACPI Device IDs for thermal/dptf on Tigerlake SoC. */
+
+/* DPTF ACPI Device ID */
+#define	DPTF_DPTF_DEVICE		"INTC1040"
+
+/* Generic ACPI Device ID for TSR0/1/2/3 */
+#define	DPTF_GEN_DEVICE		"INTC1043"
+
+/* Fan ACPI Device ID */
+#define	DPTF_FAN_DEVICE		"INTC1044"

[Sumeet R Pawnikar (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Tim Wawrzynczak, Puthikorn Voravootivat, Todd Broch, Subrata Banik, Aaron Durbin, Patrick Rudolph, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42040

to look at the new patch set (#2).

Change subject: tigerlake: add unique acpi device ids for dptf
......................................................................

tigerlake: add unique acpi device ids for dptf

Add unique new acpi device ids for dptf for Tigerlake soc based platforms
and cleanup other defines.

BUG=None
BRANCH=None
TEST=Build and boot on volteer system

Change-Id: I7dbb812c0fc0f5084c98cf2752ce7ddce8e4d50e
Signed-off-by: Sumeet R Pawnikar 
---
M src/mainboard/google/volteer/dsdt.asl
A src/soc/intel/tigerlake/acpi/dptf.asl
2 files changed, 11 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/42040/2

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42040 )

Change subject: tigerlake: add unique acpi device ids for dptf
......................................................................

Patch Set 2:

(1 comment)

What's the reason for the _HID changes in TGL ?

https://review.coreboot.org/c/coreboot/+/42040/2/src/soc/intel/tigerlake/acp... 
File src/soc/intel/tigerlake/acpi/dptf.asl:

https://review.coreboot.org/c/coreboot/+/42040/2/src/soc/intel/tigerlake/acp... 
PS2, Line 5: 	
extra tab

[Wonkyu Kim (Code Review)]

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42040 )

Change subject: tigerlake: add unique acpi device ids for dptf
......................................................................

Patch Set 2: Code-Review+1

[Sumeet R Pawnikar (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Tim Wawrzynczak, Puthikorn Voravootivat, Todd Broch, Subrata Banik, Aaron Durbin, Patrick Rudolph, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42040

to look at the new patch set (#3).

Change subject: tigerlake: add unique acpi device ids for dptf
......................................................................

tigerlake: add unique acpi device ids for dptf

Add unique new acpi device ids for dptf for Tigerlake soc based platforms
and update volteer speficic dsdt.asl file accordigly.

BUG=None
BRANCH=None
TEST=Build and boot on volteer system

Change-Id: I7dbb812c0fc0f5084c98cf2752ce7ddce8e4d50e
Signed-off-by: Sumeet R Pawnikar 
---
M src/mainboard/google/volteer/dsdt.asl
A src/soc/intel/tigerlake/acpi/dptf.asl
2 files changed, 11 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/42040/3

[Sumeet R Pawnikar (Code Review)]

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42040 )

Change subject: tigerlake: add unique acpi device ids for dptf
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42040/2/src/soc/intel/tigerlake/acp... 
File src/soc/intel/tigerlake/acpi/dptf.asl:

https://review.coreboot.org/c/coreboot/+/42040/2/src/soc/intel/tigerlake/acp... 
PS2, Line 5:
> extra tab

Ack

[Sumeet R Pawnikar (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Tim Wawrzynczak, Puthikorn Voravootivat, Todd Broch, Subrata Banik, Aaron Durbin, Patrick Rudolph, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42040

to look at the new patch set (#4).

Change subject: tigerlake: add unique acpi device ids for dptf
......................................................................

tigerlake: add unique acpi device ids for dptf

Add unique new acpi device ids for dptf for Tigerlake soc based platforms
and update volteer speficic dsdt.asl file accordigly.

BUG=None
BRANCH=None
TEST=Build and boot on volteer system

Change-Id: I7dbb812c0fc0f5084c98cf2752ce7ddce8e4d50e
Signed-off-by: Sumeet R Pawnikar 
---
M src/mainboard/google/volteer/dsdt.asl
A src/soc/intel/tigerlake/acpi/dptf.asl
2 files changed, 11 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/42040/4

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42040 )

Change subject: tigerlake: add unique acpi device ids for dptf
......................................................................

Patch Set 4:

Has this change gotten picked into anyone's kernel tree yet?

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42040 )

Change subject: tigerlake: add unique acpi device ids for dptf
......................................................................

Patch Set 4:

err, the corresponding change

[Wonkyu Kim (Code Review)]

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42040 )

Change subject: tigerlake: add unique acpi device ids for dptf
......................................................................

Patch Set 4: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42040 )

Change subject: tigerlake: add unique acpi device ids for dptf
......................................................................

Patch Set 4:

(3 comments)

https://review.coreboot.org/c/coreboot/+/42040/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/42040/4//COMMIT_MSG@9 
PS4, Line 9: Tigerlake
Tiger Lake

https://review.coreboot.org/c/coreboot/+/42040/4//COMMIT_MSG@10 
PS4, Line 10: g
accordingly

https://review.coreboot.org/c/coreboot/+/42040/4//COMMIT_MSG@11 
PS4, Line 11: 
From where did you get the new IDs?

[Sumeet R Pawnikar (Code Review)]

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42040 )

Change subject: tigerlake: add unique acpi device ids for dptf
......................................................................

Patch Set 4:

(1 comment)

These new dptf ACPI Device IDs for Tigerlake are already part of latest mainline kernel.

https://review.coreboot.org/c/coreboot/+/42040/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/42040/4//COMMIT_MSG@11 
PS4, Line 11:
> From where did you get the new IDs?

https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2...

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42040 )

Change subject: tigerlake: add unique acpi device ids for dptf
......................................................................

Patch Set 4:

(1 comment)
> Patch Set 4:
>
> (1 comment)
>
> These new dptf ACPI Device IDs for Tigerlake are already part of latest mainline kernel.

Thanks.

https://review.coreboot.org/c/coreboot/+/42040/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/42040/4//COMMIT_MSG@11 
PS4, Line 11:
> https://chromium-review.googlesource. […]

Please mention that in the commit message, that the Linux kernel driver expects these.

[Sumeet R Pawnikar (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Duncan Laurie, Tim Wawrzynczak, Puthikorn Voravootivat, Todd Broch, Subrata Banik, Aaron Durbin, Patrick Rudolph, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42040

to look at the new patch set (#5).

Change subject: tigerlake: add unique acpi device ids for dptf
......................................................................

tigerlake: add unique acpi device ids for dptf

Add unique new acpi device ids for dptf for Tiger Lake soc based platforms
and update volteer speficic dsdt.asl file accordingly. The Linux kernel
driver expects these new acpi device ids for dptf functionalities.

BUG=None
BRANCH=None
TEST=Build and boot on volteer system

Change-Id: I7dbb812c0fc0f5084c98cf2752ce7ddce8e4d50e
Signed-off-by: Sumeet R Pawnikar 
---
M src/mainboard/google/volteer/dsdt.asl
A src/soc/intel/tigerlake/acpi/dptf.asl
2 files changed, 11 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/42040/5

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42040 )

Change subject: tigerlake: add unique acpi device ids for dptf
......................................................................

Patch Set 5:

(5 comments)

https://review.coreboot.org/c/coreboot/+/42040/5/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/dsdt.asl:

https://review.coreboot.org/c/coreboot/+/42040/5/src/mainboard/google/voltee... 
PS5, Line 60: Tigerlake
Tiger Lake

https://review.coreboot.org/c/coreboot/+/42040/5/src/soc/intel/tigerlake/acp... 
File src/soc/intel/tigerlake/acpi/dptf.asl:

https://review.coreboot.org/c/coreboot/+/42040/5/src/soc/intel/tigerlake/acp... 
PS5, Line 3: Tigerlake
Tiger Lake

https://review.coreboot.org/c/coreboot/+/42040/5/src/soc/intel/tigerlake/acp... 
PS5, Line 5: 	
space, not tab

https://review.coreboot.org/c/coreboot/+/42040/5/src/soc/intel/tigerlake/acp... 
PS5, Line 7: 	
space, not tab

https://review.coreboot.org/c/coreboot/+/42040/5/src/soc/intel/tigerlake/acp... 
PS5, Line 9: 	
space, not tab

[Sumeet R Pawnikar (Code Review)]

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42040 )

Change subject: tigerlake: add unique acpi device ids for dptf
......................................................................

Patch Set 5:

(8 comments)

https://review.coreboot.org/c/coreboot/+/42040/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/42040/4//COMMIT_MSG@9 
PS4, Line 9: Tigerlake
> Tiger Lake

Done

https://review.coreboot.org/c/coreboot/+/42040/4//COMMIT_MSG@10 
PS4, Line 10: g
> accordingly

Done

https://review.coreboot.org/c/coreboot/+/42040/4//COMMIT_MSG@11 
PS4, Line 11:
> Please mention that in the commit message, that the Linux kernel driver expects these.

Ack

https://review.coreboot.org/c/coreboot/+/42040/5/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/dsdt.asl:

https://review.coreboot.org/c/coreboot/+/42040/5/src/mainboard/google/voltee... 
PS5, Line 60: Tigerlake
> Tiger Lake

Ack

https://review.coreboot.org/c/coreboot/+/42040/5/src/soc/intel/tigerlake/acp... 
File src/soc/intel/tigerlake/acpi/dptf.asl:

https://review.coreboot.org/c/coreboot/+/42040/5/src/soc/intel/tigerlake/acp... 
PS5, Line 3: Tigerlake
> Tiger Lake

Ack

https://review.coreboot.org/c/coreboot/+/42040/5/src/soc/intel/tigerlake/acp... 
PS5, Line 5:
> space, not tab

Ack

https://review.coreboot.org/c/coreboot/+/42040/5/src/soc/intel/tigerlake/acp... 
PS5, Line 7:
> space, not tab

Ack

https://review.coreboot.org/c/coreboot/+/42040/5/src/soc/intel/tigerlake/acp... 
PS5, Line 9:
> space, not tab

Ack

[Sumeet R Pawnikar (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Tim Wawrzynczak, Duncan Laurie, Puthikorn Voravootivat, Todd Broch, Subrata Banik, Aaron Durbin, Patrick Rudolph, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42040

to look at the new patch set (#6).

Change subject: tigerlake: add unique acpi device ids for dptf
......................................................................

tigerlake: add unique acpi device ids for dptf

Add unique new acpi device ids for dptf for Tiger Lake soc based platforms
and update volteer speficic dsdt.asl file accordingly. The Linux kernel
driver expects these new acpi device ids for dptf functionalities.

BUG=None
BRANCH=None
TEST=Build and boot on volteer system

Change-Id: I7dbb812c0fc0f5084c98cf2752ce7ddce8e4d50e
Signed-off-by: Sumeet R Pawnikar 
---
M src/mainboard/google/volteer/dsdt.asl
A src/soc/intel/tigerlake/acpi/dptf.asl
2 files changed, 11 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/42040/6

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42040 )

Change subject: tigerlake: add unique acpi device ids for dptf
......................................................................

Patch Set 6: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/42040/6/src/soc/intel/tigerlake/acp... 
File src/soc/intel/tigerlake/acpi/dptf.asl:

https://review.coreboot.org/c/coreboot/+/42040/6/src/soc/intel/tigerlake/acp... 
PS6, Line 5: 	
extra tab

[Sumeet R Pawnikar (Code Review)]

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42040 )

Change subject: tigerlake: add unique acpi device ids for dptf
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42040/6/src/soc/intel/tigerlake/acp... 
File src/soc/intel/tigerlake/acpi/dptf.asl:

https://review.coreboot.org/c/coreboot/+/42040/6/src/soc/intel/tigerlake/acp... 
PS6, Line 5:
> extra tab

Below two defines have 2 tabs so kept here 2 tabs as well.

[Sumeet R Pawnikar (Code Review)]

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42040 )

Change subject: tigerlake: add unique acpi device ids for dptf
......................................................................

Patch Set 6:

This is tested and verified on Tiger Lake based volteer system. We have kernel patches dependent on this coreboot patch to get merge. Please merge this. Thanks.

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42040 )

Change subject: tigerlake: add unique acpi device ids for dptf
......................................................................

tigerlake: add unique acpi device ids for dptf

Add unique new acpi device ids for dptf for Tiger Lake soc based platforms
and update volteer speficic dsdt.asl file accordingly. The Linux kernel
driver expects these new acpi device ids for dptf functionalities.

BUG=None
BRANCH=None
TEST=Build and boot on volteer system

Change-Id: I7dbb812c0fc0f5084c98cf2752ce7ddce8e4d50e
Signed-off-by: Sumeet R Pawnikar 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42040
Tested-by: build bot (Jenkins) 
Reviewed-by: Tim Wawrzynczak 
---
M src/mainboard/google/volteer/dsdt.asl
A src/soc/intel/tigerlake/acpi/dptf.asl
2 files changed, 11 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/dsdt.asl b/src/mainboard/google/volteer/dsdt.asl
index fa39e79..31897674 100644
--- a/src/mainboard/google/volteer/dsdt.asl
+++ b/src/mainboard/google/volteer/dsdt.asl
@@ -57,8 +57,8 @@
    {
    	/* Per board variant specific definitions. */
    	#include <variant/acpi/dptf.asl>
-		/* Include soc specific DPTF changes */
-		#include <soc/intel/common/acpi/dptf.asl>
+		/* Include Tiger Lake soc specific DPTF changes */
+		#include <soc/intel/tigerlake/acpi/dptf.asl>
    	/* Include common dptf ASL files */
    	#include <soc/intel/common/acpi/dptf/dptf.asl>
    }
diff --git a/src/soc/intel/tigerlake/acpi/dptf.asl b/src/soc/intel/tigerlake/acpi/dptf.asl
new file mode 100644
index 0000000..4877c88
--- /dev/null
+++ b/src/soc/intel/tigerlake/acpi/dptf.asl
@@ -0,0 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+/* Below are the unique ACPI Device IDs for thermal/dptf on Tiger Lake SoC. */
+/* DPTF ACPI Device ID */
+#define DPTF_DPTF_DEVICE		"INTC1040"
+/* Generic ACPI Device ID for TSR0/1/2/3 and charger */
+#define DPTF_GEN_DEVICE		"INTC1043"
+/* Fan ACPI Device ID */
+#define DPTF_FAN_DEVICE		"INTC1044"