Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43822 )
Change subject: nb/intel/x4x/rcven.c: Rename memory barrier function ......................................................................
nb/intel/x4x/rcven.c: Rename memory barrier function
Use the name of the assembly instruction it uses, mfence.
Change-Id: I98d7926434694a41fb6415bed4276741fa7996af Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/x4x/rcven.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/43822/1
diff --git a/src/northbridge/intel/x4x/rcven.c b/src/northbridge/intel/x4x/rcven.c index 332d89c..506282b 100644 --- a/src/northbridge/intel/x4x/rcven.c +++ b/src/northbridge/intel/x4x/rcven.c @@ -19,7 +19,7 @@ u8 tap; };
-static inline void barrier(void) +static inline void mfence(void) { asm volatile("mfence":::); } @@ -33,10 +33,10 @@ udelay(2); MCHBAR8(RESET_CNTL(channel)) |= 0x2; udelay(2); - barrier(); + mfence(); /* Read strobe */ read32((u32 *)addr); - barrier(); + mfence(); return (MCHBAR8(sample_offset) >> 6) & 1; }
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43822 )
Change subject: nb/intel/x4x/rcven.c: Rename memory barrier function ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43822 )
Change subject: nb/intel/x4x/rcven.c: Rename memory barrier function ......................................................................
nb/intel/x4x/rcven.c: Rename memory barrier function
Use the name of the assembly instruction it uses, mfence.
Change-Id: I98d7926434694a41fb6415bed4276741fa7996af Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43822 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/northbridge/intel/x4x/rcven.c 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/northbridge/intel/x4x/rcven.c b/src/northbridge/intel/x4x/rcven.c index 332d89c..506282b 100644 --- a/src/northbridge/intel/x4x/rcven.c +++ b/src/northbridge/intel/x4x/rcven.c @@ -19,7 +19,7 @@ u8 tap; };
-static inline void barrier(void) +static inline void mfence(void) { asm volatile("mfence":::); } @@ -33,10 +33,10 @@ udelay(2); MCHBAR8(RESET_CNTL(channel)) |= 0x2; udelay(2); - barrier(); + mfence(); /* Read strobe */ read32((u32 *)addr); - barrier(); + mfence(); return (MCHBAR8(sample_offset) >> 6) & 1; }
-
Angel Pons (Code Review) -
Tim Wawrzynczak (Code Review)