Change in coreboot[master]: mb/google/volteer/var/terrador: Add gpio-keys ACPI node for PENH

[David Wu (Code Review)]

David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48522 )

Change subject: mb/google/volteer/var/terrador: Add gpio-keys ACPI node for PENH
......................................................................

mb/google/volteer/var/terrador: Add gpio-keys ACPI node for PENH

Use gpio_keys driver to add ACPI node for pen eject event.  Also
setting gpio wake pin for wake events.

BUG=None
TEST=tested on a Terrador

Signed-off-by: David Wu 
Change-Id: I314d90200a508cba9ac144797fe20d4423820a4c
---
M src/mainboard/google/volteer/variants/terrador/gpio.c
M src/mainboard/google/volteer/variants/terrador/overridetree.cb
2 files changed, 14 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/48522/1

diff --git a/src/mainboard/google/volteer/variants/terrador/gpio.c b/src/mainboard/google/volteer/variants/terrador/gpio.c
index a0267cc..738341b 100644
--- a/src/mainboard/google/volteer/variants/terrador/gpio.c
+++ b/src/mainboard/google/volteer/variants/terrador/gpio.c
@@ -111,7 +111,7 @@
    /* E16 : ISH_GP7 ==> USB_A0_RT_RST_ODL */
    PAD_CFG_GPO(GPP_E16, 1, DEEP),
    /* E17 : THC0_SPI1_INT# ==> PEN_DET_ODL */
-	PAD_CFG_GPI_SCI_LOW(GPP_E1, NONE, DEEP, EDGE_SINGLE),
+	PAD_CFG_GPI(GPP_E17, NONE, DEEP),
    /* E19 : DDP1_CTRLDATA ==> USB0_C0_LSX_SOC_RX_STRAP */
    PAD_CFG_NF(GPP_E19, DN_20K, DEEP, NF4),

diff --git a/src/mainboard/google/volteer/variants/terrador/overridetree.cb b/src/mainboard/google/volteer/variants/terrador/overridetree.cb
index 039dc85..e4c7824 100644
--- a/src/mainboard/google/volteer/variants/terrador/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/terrador/overridetree.cb
@@ -113,6 +113,19 @@
    			register "hid_desc_reg_offset" = "0x01"
    			device i2c 10 on end
    		end
+			chip drivers/generic/gpio_keys
+				register "name" = ""PENH""
+				# GPP_E17 is the IRQ source, and GPP_E1 is the wake source
+				register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_E17)"
+				register "key.wake_gpe" = "GPE0_DW2_01"
+				register "key.wakeup_route" = "WAKEUP_ROUTE_SCI"
+				register "key.wakeup_event_action" = "EV_ACT_DEASSERTED"
+				register "key.dev_name" = ""EJCT""
+				register "key.linux_code" = "SW_PEN_INSERTED"
+				register "key.linux_input_type" = "EV_SW"
+				register "key.label" = ""pen_eject""
+				device generic 0 on end
+			end
    	end
    	device ref i2c5 on
    		chip drivers/i2c/hid

[David Wu (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48522

to look at the new patch set (#2).

Change subject: mb/google/volteer/var/terrador: Add gpio-keys ACPI node for PENH
......................................................................

mb/google/volteer/var/terrador: Add gpio-keys ACPI node for PENH

Use gpio_keys driver to add ACPI node for pen eject event.  Also
setting gpio wake pin for wake events.

BUG=None
TEST=emerge-volteer coreboot chromeos-bootimage

Signed-off-by: David Wu 
Change-Id: I314d90200a508cba9ac144797fe20d4423820a4c
---
M src/mainboard/google/volteer/variants/terrador/gpio.c
M src/mainboard/google/volteer/variants/terrador/overridetree.cb
2 files changed, 15 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/48522/2

[David Wu (Code Review)]

David Wu has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48522 )

Change subject: mb/google/volteer/var/terrador: Add gpio-keys ACPI node for PENH
......................................................................

Abandoned