Change in coreboot[master]: cpu/x86: Remove unnecessary guard.

[Name of user not set (Code Review)]

[e-mail] has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38820 )

Change subject: cpu/x86: Remove unnecessary guard.
......................................................................

cpu/x86: Remove unnecessary guard.

The is_smm_enabled is not necessary because it is done previously
in this code path.

Signed-off-by: Eugene D. Myers 
Change-Id: I20d50acbea891cb56ad49edc128df25d21c5f1ca
---
M src/cpu/x86/mp_init.c
1 file changed, 7 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/38820/1

diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c
index 5169861..6082df9 100644
--- a/src/cpu/x86/mp_init.c
+++ b/src/cpu/x86/mp_init.c
@@ -747,20 +747,15 @@
    mp_state.ops.relocation_handler(cpu, curr_smbase, perm_smbase);

if (CONFIG(STM)) {
-		if (is_smm_enabled()) {
-			uintptr_t mseg;
+		uintptr_t mseg;

-			mseg = mp_state.perm_smbase +
-				(mp_state.perm_smsize - CONFIG_MSEG_SIZE);
+		mseg = mp_state.perm_smbase +
+			(mp_state.perm_smsize - CONFIG_MSEG_SIZE);

-			stm_setup(mseg, p->cpu, runtime->num_cpus,
-					perm_smbase,
-					mp_state.perm_smbase,
-					runtime->start32_offset);
-		} else {
-			printk(BIOS_DEBUG,
-				"STM not loaded because SMM is not enabled!\n");
-		}
+		stm_setup(mseg, p->cpu, runtime->num_cpus,
+				perm_smbase,
+				mp_state.perm_smbase,
+				runtime->start32_offset);
    }
 }

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38820 )

Change subject: cpu/x86: Remove unnecessary guard.
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38820/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38820/1//COMMIT_MSG@7 
PS1, Line 7: cpu/x86: Remove unnecessary guard.
Please remove the dot/period at the end of the commit message summary.

[Name of user not set (Code Review)]

[e-mail] has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38820 )

Change subject: cpu/x86: Remove unnecessary guard.
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38820/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38820/1//COMMIT_MSG@7 
PS1, Line 7: cpu/x86: Remove unnecessary guard.
> Please remove the dot/period at the end of the commit message summary.

Done

Change in coreboot[master]: cpu/x86: Remove unnecessary guard

[Name of user not set (Code Review)]

Hello Patrick Rudolph, ron minnich, build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38820

to look at the new patch set (#2).

Change subject: cpu/x86: Remove unnecessary guard
......................................................................

cpu/x86: Remove unnecessary guard

The is_smm_enabled is not necessary because it is done previously
in this code path.

Signed-off-by: Eugene D. Myers 
Change-Id: I20d50acbea891cb56ad49edc128df25d21c5f1ca
---
M src/cpu/x86/mp_init.c
1 file changed, 7 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/38820/2

Change in coreboot[master]: cpu/x86: Remove unnecessary guard

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38820 )

Change subject: cpu/x86: Remove unnecessary guard
......................................................................

Patch Set 2: Code-Review+2

Change in coreboot[master]: cpu/x86: Remove unnecessary guard

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38820 )

Change subject: cpu/x86: Remove unnecessary guard
......................................................................

cpu/x86: Remove unnecessary guard

The is_smm_enabled is not necessary because it is done previously
in this code path.

Signed-off-by: Eugene D. Myers 
Change-Id: I20d50acbea891cb56ad49edc128df25d21c5f1ca
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38820
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
M src/cpu/x86/mp_init.c
1 file changed, 7 insertions(+), 12 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c
index 5169861..6082df9 100644
--- a/src/cpu/x86/mp_init.c
+++ b/src/cpu/x86/mp_init.c
@@ -747,20 +747,15 @@
    mp_state.ops.relocation_handler(cpu, curr_smbase, perm_smbase);

if (CONFIG(STM)) {
-		if (is_smm_enabled()) {
-			uintptr_t mseg;
+		uintptr_t mseg;

-			mseg = mp_state.perm_smbase +
-				(mp_state.perm_smsize - CONFIG_MSEG_SIZE);
+		mseg = mp_state.perm_smbase +
+			(mp_state.perm_smsize - CONFIG_MSEG_SIZE);

-			stm_setup(mseg, p->cpu, runtime->num_cpus,
-					perm_smbase,
-					mp_state.perm_smbase,
-					runtime->start32_offset);
-		} else {
-			printk(BIOS_DEBUG,
-				"STM not loaded because SMM is not enabled!\n");
-		}
+		stm_setup(mseg, p->cpu, runtime->num_cpus,
+				perm_smbase,
+				mp_state.perm_smbase,
+				runtime->start32_offset);
    }
 }