Attention is currently required from: Jonathan Zhang, Johnny Lin, Christian Walter, David Hendricks, Arthur Heymans, Tim Chu.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73171 )
Change subject: soc/intel/xeon_sp: Split SKX/CPX MSRs into separate headers
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
This patchset implements a suggestion from CB:72611 to split MSR headers into different files. Some of the MSRs on SPR are laid out differently from previous generations, so it made sense to split the headers apart.
For this patch set, I went through the EDS docs for SKX, CPX, and SPR to figure out which MSRs are common or not. SKX and CPX are fairly similar, particularly fields in MSR_POWER_CTL. However there are some differences, for example in the number of MC banks implemented. SPR (CB:73172) has a lot more differences.
For now I tried to leave formatting the same (simple cut+paste from one header to another). We may want to re-formatt these files later on using the updated .clang-format from Elyes (CB:64779).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73171
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ecfebdde453a48b7b0e6f21b3c4394411eed671
Gerrit-Change-Number: 73171
Gerrit-PatchSet: 4
Gerrit-Owner: David Hendricks
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Wed, 01 Mar 2023 23:05:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment