[L] Change in coreboot[main]: mb/hp: Add Pro 3400

[Václav Straka (Code Review)]

Attention is currently required from: Angel Pons, Nicholas Chin.

Václav Straka has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85825?usp=email )

Change subject: mb/hp: Add Pro 3400
......................................................................

Patch Set 11:

(5 comments)

File Documentation/mainboard/hp/pro_3500_series.md:

https://review.coreboot.org/c/coreboot/+/85825/comment/1d825c2c_9bbe3fa2?usp... :
PS10, Line 10: When using MrChromebox edk2 with secure boot build in, the
             : board will hang on each boot for about 20 seconds before continuing.
> I'm assuming you tested this and found that it was no longer true?

Yes, that's right.

File src/mainboard/hp/pro_3x00_series/cmos.layout:

https://review.coreboot.org/c/coreboot/+/85825/comment/efbaf367_53b9a0c2?usp... :
PS10, Line 37: 2	0	Enable
             : 2	1	Disable
> Not used; can be removed.

Removed. Should i also renumber the other enums? I was not sure so i left it as is.

File src/mainboard/hp/pro_3x00_series/dsdt.asl:

https://review.coreboot.org/c/coreboot/+/85825/comment/5d03bb24_3e59f785?usp... :
PS10, Line 3: define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB
            : #define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB
> These can be dropped, as it's only used by the Thinkpad H8 ACPI code. […]

I already made a follow up for this, as Angel Pons requested.

File src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/85825/comment/2be561fc_2d805fe1?usp... :
PS10, Line 5:
> I would drop the blank line here as I don't think it adds much.

Done

File src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/85825/comment/bb52d9e6_daa0e3be?usp... :
PS10, Line 5:
> Same here, drop the blank line

Done