Attention is currently required from: Furquan Shaikh, Subrata Banik, Angel Pons, Kyösti Mälkki.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57305 )
Change subject: arch/x86: Skip returning default leaf value as `0`
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57305/comment/432f0349_e65102eb
PS2, Line 11: leaf
leafs?
https://review.coreboot.org/c/coreboot/+/57305/comment/520d4b9d_a5c97e3b
PS2, Line 16: e2b5fee
Please add:
Fixes: e2b5fee3b006 (arch/x86: smbios write 7 table using deterministic cache functions)
File src/arch/x86/cpu_common.c:
https://review.coreboot.org/c/coreboot/+/57305/comment/53376b4b_9b02dff7
PS2, Line 115: return DETERMINISTIC_CACHE_PARAMETERS_CPUID_IA;
You could use the ternary operator.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57305
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee33b39298e7821ac5280d998172b58a70c8715b
Gerrit-Change-Number: 57305
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Swift Geek (Sebastian Grzywna)
swiftgeek@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 01 Sep 2021 23:09:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment