Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Felix Held, Jakub Czapiga, Kapil Porwal, Nick Vaccaro, Patrick Georgi, Shelley Chen, Tarun.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79936?usp=email )
Change subject: soc/intel/{adl, mtl}: Increase heap size (HEAP_SIZE) config
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
Btw would it make sense to add the BLT buffer to cbmem rather than heap, just like BMP? That avoids those if BMP_LOGO lines in Kconfig.
good idea, let me explorer that option incrementally
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/79936/comment/76078f41_b541e599 :
PS3, Line 221: default 0x100000 if BMP_LOGO
So 1MB. Should we make that the default across the tree? SMM/resume shouldn't break on that anymore.
that is good idea. I saw ur initial CL which tries to set 1MB as default across the tree bt dropped because of the brokenness ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79936?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If34b1ef497d38ba561221c584aab5399cfc5de82
Gerrit-Change-Number: 79936
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 16 Jan 2024 16:45:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
patrick@coreboot.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment