Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39638 )
Change subject: drivers/intel/gma: hook up GMA for Skylake+
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39638/12/src/soc/intel/skylake/acpi...
File src/soc/intel/skylake/acpi/pch.asl:
https://review.coreboot.org/c/coreboot/+/39638/12/src/soc/intel/skylake/acpi...
PS12, Line 32: /* IGD 0:2.0 */
Shouldn't this be included in the systemagent.asl? That is where the graphics resides. The pch. […]
For this generation, the IGD is still spread across both chips and the ACPI relevant part
(backlight control) is in the PCH. (I don't know if that changed with the 10nm generations,
but it might.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39638
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c2f0e8fe1ef91334d494c8a8605dd46cda80e3d
Gerrit-Change-Number: 39638
Gerrit-PatchSet: 12
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 25 Mar 2020 11:03:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-MessageType: comment