Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56074 )
Change subject: mb/google/brya: Add UsbTcPortEn in devicetree ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/mainboard/google/brya/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/56074/comment/20b5f7b3_9e935189 PS1, Line 62: 0x7 can we have bit wise macro to make the code more readable please ?
File src/soc/intel/alderlake/chip.h:
https://review.coreboot.org/c/coreboot/+/56074/comment/682a068b_a2005430 PS1, Line 115: /* suggested to add a macro here, similar to https://review.coreboot.org/c/coreboot/+/56074/1/src/soc/intel/alderlake/chi... for TCSS port
-
Subrata Banik (Code Review)