Jon Murphy has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62864 )
Change subject: mb/google/skyrim: Add counter initializers ......................................................................
mb/google/skyrim: Add counter initializers
Some counters are not being initialized in the SOC code and are relying on mainboards to set their values. If the mainboards have not implemented these functions it leads to indeterminate behavior. Set the counters in the mainboard to prevent the indeterminate state.
BUG=b:224618411 TEST=builds
Change-Id: I69ad46a3c717bd6dee0f5d9daa5cf65696046be9 --- M src/mainboard/google/skyrim/port_descriptors.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/62864/1
diff --git a/src/mainboard/google/skyrim/port_descriptors.c b/src/mainboard/google/skyrim/port_descriptors.c index 56bd9f3..4fabeb9 100644 --- a/src/mainboard/google/skyrim/port_descriptors.c +++ b/src/mainboard/google/skyrim/port_descriptors.c @@ -8,4 +8,7 @@ const fsp_ddi_descriptor **ddi_descs, size_t *ddi_num) { /* TODO: Initialize DXIO and DDI descriptors */ + /* Set counters to 0 for now to avoid indeterminate state */ + *ddi_num = 0; + *ddi_descs = 0; }