Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32739
Change subject: lib/hexdump: Drop redundant isprint() implementation ......................................................................
lib/hexdump: Drop redundant isprint() implementation
Change-Id: I23e2d89274553cbc75e42f0420a1a84d4cec4340 Signed-off-by: Nico Huber nico.h@gmx.de --- M src/lib/hexdump.c 1 file changed, 1 insertion(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/32739/1
diff --git a/src/lib/hexdump.c b/src/lib/hexdump.c index 2861d63..ca36dde 100644 --- a/src/lib/hexdump.c +++ b/src/lib/hexdump.c @@ -14,11 +14,7 @@
#include <console/console.h> #include <lib.h> - -static int isprint(int c) -{ - return (c >= 32 && c <= 126); -} +#include <string.h>
void hexdump(const void *memory, size_t length) {
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32739 )
Change subject: lib/hexdump: Drop redundant isprint() implementation ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32739 )
Change subject: lib/hexdump: Drop redundant isprint() implementation ......................................................................
lib/hexdump: Drop redundant isprint() implementation
Change-Id: I23e2d89274553cbc75e42f0420a1a84d4cec4340 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/32739 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M src/lib/hexdump.c 1 file changed, 1 insertion(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/src/lib/hexdump.c b/src/lib/hexdump.c index 2861d63..ca36dde 100644 --- a/src/lib/hexdump.c +++ b/src/lib/hexdump.c @@ -14,11 +14,7 @@
#include <console/console.h> #include <lib.h> - -static int isprint(int c) -{ - return (c >= 32 && c <= 126); -} +#include <string.h>
void hexdump(const void *memory, size_t length) {
-
Julius Werner (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)