Attention is currently required from: Martin L Roth, Jason Nien, Arthur Heymans, Martin Roth.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73294 )
Change subject: mb/google/skyrim: Allow port descriptors to be overridden
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/skyrim/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/73294/comment/2fc703a0_142a0d78
PS2, Line 97: if (!*dxio_num || !*dxio_descs)
: {
: *dxio_descs = skyrim_mdn_dxio_descriptors;
: *dxio_num = ARRAY_SIZE(skyrim_mdn_dxio_descriptors);
: }
Sure, we can do that. […]
Looking through the use-case it sounds Kconfig makes sense to me too.
If the concerned config is not enabled, then use the baseboard port_descriptors.c. Else use the override port_descriptors.c from the variant.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73294
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8cff44f5b39d130a7191a69970cae8a88bb5d475
Gerrit-Change-Number: 73294
Gerrit-PatchSet: 3
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Mon, 06 Mar 2023 23:04:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment