Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47892 )
Change subject: mb/system76/oryp5: Add System76 Oryx Pro 5 ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47892/2/src/mainboard/system76/oryp... File src/mainboard/system76/oryp5/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/47892/2/src/mainboard/system76/oryp... PS2, Line 26: register "SaGv" = "SaGv_Enabled"
I'm not sure if this has any effect on Halo
What's Halo? Is there a way I can verify that?
https://review.coreboot.org/c/coreboot/+/47892/3/src/mainboard/system76/oryp... File src/mainboard/system76/oryp5/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/47892/3/src/mainboard/system76/oryp... PS3, Line 87: subsystemid 0x1558 0x95e6 inherit
Values in static.c are correct. […]
FSP integration guide only lists the registers with abbreviated names. Passing a custom SiSsidTablePtr prevents FSP from writing the default values (this is explained much better in the TGL guide).
https://review.coreboot.org/c/coreboot/+/47892/2/src/mainboard/system76/oryp... File src/mainboard/system76/oryp5/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/47892/2/src/mainboard/system76/oryp... PS2, Line 25: // Enable DMIC microphone on ALC1220 : 0x02050036, : 0x02042a6a,
What does the microphone have to do with beep?
Jeremy got these magic numbers from the Windows driver, and putting them here happens to make the DMIC work. So I suppose just convenience? There seems to be several boards doing this (using pc_beep_verbs for init verbs).
-
Tim Crawford (Code Review)