Attention is currently required from: Sean Rhodes, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59258 )
Change subject: drivers/intel/gma: Remove _BCL from acpigen
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
How is it supposed to work without _BCL? ACPI spec says it's […]
Looking at the code, it walks the list of advertised
display connectors in the devicetree. There is no
reason to advertise a panel in the devicetree whilst
not including the static ASL files. This ACPI generator
and the static code work hand-in-hand, neither of them
makes sense without the other. The SoC may select it,
but it's the devicetree which controls what is generated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59258
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf2f2fa33abd11952c888c9502d1d5ef1ad6544f
Gerrit-Change-Number: 59258
Gerrit-PatchSet: 6
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
admin@starlabs.systems
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 03 Jan 2022 13:32:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment