Change in coreboot[master]: util/gitconfig: Fix commit-msg for BSD grep

[Patrick Elsen (Code Review)]

Patrick Elsen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38205 )

Change subject: util/gitconfig: Fix commit-msg for BSD grep
......................................................................

util/gitconfig: Fix commit-msg for BSD grep

BSD grep (on macOS) doesn't like repeated repetition operators, it
throws the error

grep: repetition-operator operand invalid

This removes the superfluous repetition operator to make the commit-msg
hook work on macOS and other platforms not using GNU grep.

Change-Id: Id0f57d0f14634f7844b889d71342b2982fcadeb2
Signed-off-by: Patrick Elsen 
---
M util/gitconfig/commit-msg
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/38205/1

diff --git a/util/gitconfig/commit-msg b/util/gitconfig/commit-msg
index 2eef752..ba6fa3f 100755
--- a/util/gitconfig/commit-msg
+++ b/util/gitconfig/commit-msg
@@ -169,7 +169,7 @@
    git hash-object -t commit --stdin
 }

-if ! grep -qi '^[[:space:]]*+Signed-off-by:' "$MSG"; then
+if ! grep -qi '^[[:space:]]*Signed-off-by:' "$MSG"; then
    printf "\nError: No Signed-off-by line in the commit message.\n"
    exit 1
 fi

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38205 )

Change subject: util/gitconfig: Fix commit-msg for BSD grep
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38205 )

Change subject: util/gitconfig: Fix commit-msg for BSD grep
......................................................................

util/gitconfig: Fix commit-msg for BSD grep

BSD grep (on macOS) doesn't like repeated repetition operators, it
throws the error

grep: repetition-operator operand invalid

This removes the superfluous repetition operator to make the commit-msg
hook work on macOS and other platforms not using GNU grep.

Change-Id: Id0f57d0f14634f7844b889d71342b2982fcadeb2
Signed-off-by: Patrick Elsen 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38205
Tested-by: build bot (Jenkins) 
Reviewed-by: Patrick Georgi 
---
M util/gitconfig/commit-msg
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved

diff --git a/util/gitconfig/commit-msg b/util/gitconfig/commit-msg
index 2eef752..ba6fa3f 100755
--- a/util/gitconfig/commit-msg
+++ b/util/gitconfig/commit-msg
@@ -169,7 +169,7 @@
    git hash-object -t commit --stdin
 }

-if ! grep -qi '^[[:space:]]*+Signed-off-by:' "$MSG"; then
+if ! grep -qi '^[[:space:]]*Signed-off-by:' "$MSG"; then
    printf "\nError: No Signed-off-by line in the commit message.\n"
    exit 1
 fi

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38205 )

Change subject: util/gitconfig: Fix commit-msg for BSD grep
......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3
Emulation targets:
EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1114
EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1113
EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1112

Please note: This test is under development and might not be accurate at all!