Raul Rangel has posted comments on this change. ( https://review.coreboot.org/28904 )
Change subject: soc/amd/stoneyridge: Allow mainboard to update I2C at runtime
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/28904/1/src/soc/amd/stoneyridge/include/soc/...
File src/soc/amd/stoneyridge/include/soc/southbridge.h:
https://review.coreboot.org/#/c/28904/1/src/soc/amd/stoneyridge/include/soc/...
PS1, Line 562: pointer
pointer to the pointer of the i2c value structure.
Or can i2c_vals be made a single pointer instead of double?
--
To view, visit
https://review.coreboot.org/28904
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id00c352a04b3d7845027882bcfcee09518787067
Gerrit-Change-Number: 28904
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 03 Oct 2018 18:45:53 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes