Attention is currently required from: jacz@semihalf.com, Jan Dabros, Duncan Laurie.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50910 )
Change subject: acpi/acpigen.h: Add more intuitive AML package closing functions
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Personally, I like to use C scopes to know what gets closed with a particular acpigen_pop_len() call. For example: https://review.coreboot.org/c/coreboot/+/48807/4/src/mainboard/prodrive/herm...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50910
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icfdc3804cd93bde049cd11dec98758b3a639eafd
Gerrit-Change-Number: 50910
Gerrit-PatchSet: 1
Gerrit-Owner: jacz@semihalf.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@gmail.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: jacz@semihalf.com
Gerrit-Attention: Jan Dabros
jsd@semihalf.com
Gerrit-Attention: Duncan Laurie
dlaurie@gmail.com
Gerrit-Comment-Date: Fri, 19 Feb 2021 15:20:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment