Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39104 )
Change subject: mb/asrock/h110m: add libgfxinit support ......................................................................
Patch Set 15: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/39104/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39104/10//COMMIT_MSG@7 PS10, Line 7: mb/asrock/h110m: add libgfxinit support
I understand, but maybe we should configure ptn3356 bridge somehow? […]
It's hard to tell. It might need out-of-band configuration (e.g. via I2C like that ptn3460 driver does) or maybe via DP Aux. Didn't look into the datasheet yet...
Marking this as resolved as the original issue was fixed. I think it's ok to merge it as long as it's documented what does(n't) work.
https://review.coreboot.org/c/coreboot/+/39104/15/src/mainboard/asrock/h110m... File src/mainboard/asrock/h110m/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/39104/15/src/mainboard/asrock/h110m... PS15, Line 13: HDMI3, -- HDMI (DDI3) I'm confused. There is no HDMI in the picture linked?
I assume the -HDV version of the board would have that. But is the coreboot port compatible?
-
Nico Huber (Code Review)