Attention is currently required from: Patrick Rudolph, Johnny Lin, Ziang Wang, Christian Walter, Arthur Heymans, Tim Chu.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74231 )
Change subject: soc/intel/xeon_sp/acpi: Fix _OSC method
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/soc/intel/xeon_sp/spr/acpi/cxl_resource.asl:
https://review.coreboot.org/c/coreboot/+/74231/comment/ee57bdaf_6ce3ce67
PS2, Line 56: If (Arg0 == ToUUID ("68f2d50b-c469-4d8a-bd3d-941a103fd3fc"))
nit: would be good to add back the comment that this GUID is for CXL, as defined in ACPI spec.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74231
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide598e386c30ced24e4f96c37f2b4a609ac33441
Gerrit-Change-Number: 74231
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Ziang Wang
ziang.wang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Ziang Wang
ziang.wang@intel.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Wed, 05 Apr 2023 13:45:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment