Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74651 )
(
3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/siemens/mc_ehl4: Adjust USB settings ......................................................................
mb/siemens/mc_ehl4: Adjust USB settings
Correct the USB settings, suitable for this mainboard.
Change-Id: I943eb891e2f2d967acfd441c085063dbad49e993 Signed-off-by: Mario Scheithauer mario.scheithauer@siemens.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/74651 Reviewed-by: Jan Samek jan.samek@siemens.com Reviewed-by: Paul Menzel paulepanter@mailbox.org Reviewed-by: Werner Zeh werner.zeh@siemens.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/siemens/mc_ehl/variants/mc_ehl4/devicetree.cb 1 file changed, 21 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Werner Zeh: Looks good to me, approved Jan Samek: Looks good to me, but someone else must approve
diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl4/devicetree.cb b/src/mainboard/siemens/mc_ehl/variants/mc_ehl4/devicetree.cb index 52da98e..5cc496f 100644 --- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl4/devicetree.cb +++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl4/devicetree.cb @@ -20,9 +20,9 @@ }"
# USB related UPDs - register "usb2_ports[0]" = "USB2_PORT_SHORT(OC_SKIP)" # USB3/2 Type A port 1 - register "usb2_ports[1]" = "USB2_PORT_SHORT(OC_SKIP)" # USB3/2 Type A Port 2 - register "usb2_ports[2]" = "USB2_PORT_MID(OC_SKIP)" # Onboard USB + register "usb2_ports[0]" = "USB2_PORT_SHORT(OC_SKIP)" # X125 + register "usb2_ports[1]" = "USB2_PORT_SHORT(OC_SKIP)" # X135 + register "usb2_ports[2]" = "USB2_PORT_MID(OC_SKIP)" # internal USB-OC register "usb2_ports[3]" = "USB2_PORT_EMPTY" # Port is unused register "usb2_ports[4]" = "USB2_PORT_EMPTY" # Port is unused register "usb2_ports[5]" = "USB2_PORT_EMPTY" # Port is unused @@ -32,7 +32,7 @@ register "usb2_ports[9]" = "USB2_PORT_EMPTY" # Port is unused
register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)" # USB3/2 Type A port1 - register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC_SKIP)" # USB3/2 Type A port2 + register "usb3_ports[1]" = "USB3_PORT_EMPTY" # Port is not used register "usb3_ports[2]" = "USB3_PORT_EMPTY" # Port is not used register "usb3_ports[3]" = "USB3_PORT_EMPTY" # Port is not used