Attention is currently required from: Frank Wu, Dtrain Hsu, Paul Menzel, Eric Lai, Karthik Ramasubramanian.
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73489 )
Change subject: spd/lp5: Add 2 Micron memory parts
......................................................................
Patch Set 7:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73489/comment/a6d0ad3e_3436d616
PS5, Line 7: Add new memory part to LP5 list
More specific: Add 2 Micron memory parts
Done
https://review.coreboot.org/c/coreboot/+/73489/comment/b0b02fd0_6483dbd0
PS5, Line 9: MICRON
Micron
Done
https://review.coreboot.org/c/coreboot/+/73489/comment/5338a67a_0f0ad462
PS5, Line 10: data sheets
Please add the names and revisions.
Done
https://review.coreboot.org/c/coreboot/+/73489/comment/1f1085e1_592411b7
PS5, Line 11: SoC
the SoC
Done
https://review.coreboot.org/c/coreboot/+/73489/comment/8d46f22b_fe9c9a5a
PS5, Line 11: using the newly added parts
That’s redundant.
Done
File spd/lp5/memory_parts.json:
https://review.coreboot.org/c/coreboot/+/73489/comment/52f1f9bc_8181a3df
PS5, Line 222: {
Tabs and spaces seem to be mixed. Maybe add a commit before fixing this for the old entries too.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73489
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6675a68b7a515bd6d21db3ea2da762b06dee017a
Gerrit-Change-Number: 73489
Gerrit-PatchSet: 7
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Jamie Chen
jamie_chen@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rex Chou
rex_chou@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 07 Mar 2023 07:56:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment