Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46356 )
Change subject: soc/intel/broadwell/memmap.c: Use `SA_DEV_ROOT` macro ......................................................................
soc/intel/broadwell/memmap.c: Use `SA_DEV_ROOT` macro
Tested with BUILD_TIMELESS=1, Purism Librem 13 v1 remains identical.
Change-Id: I013357d31974582f64a35b8228d9edfa16af99fd Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/memmap.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/46356/1
diff --git a/src/soc/intel/broadwell/memmap.c b/src/soc/intel/broadwell/memmap.c index fb9a834..e4c787a 100644 --- a/src/soc/intel/broadwell/memmap.c +++ b/src/soc/intel/broadwell/memmap.c @@ -35,8 +35,8 @@
void smm_region(uintptr_t *start, size_t *size) { - uintptr_t tseg = pci_read_config32(PCI_DEV(0, 0, 0), TSEG); - uintptr_t bgsm = pci_read_config32(PCI_DEV(0, 0, 0), BGSM); + uintptr_t tseg = pci_read_config32(SA_DEV_ROOT, TSEG); + uintptr_t bgsm = pci_read_config32(SA_DEV_ROOT, BGSM);
tseg = ALIGN_DOWN(tseg, 1 * MiB); bgsm = ALIGN_DOWN(bgsm, 1 * MiB);
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46356 )
Change subject: soc/intel/broadwell/memmap.c: Use `SA_DEV_ROOT` macro ......................................................................
Patch Set 1: Code-Review+2
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46356 )
Change subject: soc/intel/broadwell/memmap.c: Use `SA_DEV_ROOT` macro ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46356 )
Change subject: soc/intel/broadwell/memmap.c: Use `SA_DEV_ROOT` macro ......................................................................
soc/intel/broadwell/memmap.c: Use `SA_DEV_ROOT` macro
Tested with BUILD_TIMELESS=1, Purism Librem 13 v1 remains identical.
Change-Id: I013357d31974582f64a35b8228d9edfa16af99fd Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46356 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Singer felixsinger@posteo.net Reviewed-by: Nico Huber nico.h@gmx.de --- M src/soc/intel/broadwell/memmap.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Felix Singer: Looks good to me, approved
diff --git a/src/soc/intel/broadwell/memmap.c b/src/soc/intel/broadwell/memmap.c index fb9a834..e4c787a 100644 --- a/src/soc/intel/broadwell/memmap.c +++ b/src/soc/intel/broadwell/memmap.c @@ -35,8 +35,8 @@
void smm_region(uintptr_t *start, size_t *size) { - uintptr_t tseg = pci_read_config32(PCI_DEV(0, 0, 0), TSEG); - uintptr_t bgsm = pci_read_config32(PCI_DEV(0, 0, 0), BGSM); + uintptr_t tseg = pci_read_config32(SA_DEV_ROOT, TSEG); + uintptr_t bgsm = pci_read_config32(SA_DEV_ROOT, BGSM);
tseg = ALIGN_DOWN(tseg, 1 * MiB); bgsm = ALIGN_DOWN(bgsm, 1 * MiB);
-
Angel Pons (Code Review) -
Felix Singer (Code Review)
-
Nico Huber (Code Review)