Change in coreboot[master]: soc/intel/jasperlake: Move HECI_DISABLE_USING_SMM to mainboards - coreboot-gerrit

7 Apr 2021


      Attention is currently required from: Furquan Shaikh, Aseda Aboagye, Karthik Ramasubramanian.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52147 )
Change subject: soc/intel/jasperlake: Move HECI_DISABLE_USING_SMM to mainboards
......................................................................
Patch Set 1:
(1 comment)
This change is ready for review.
File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/52147/comment/37f51d3a_ab810b0c 
PS1, Line 38: HECI_DISABLE_USING_SMM
...
Should we drop this for entire dedede family i.e. […]
An argument can be made for keeping things the way they were as well as consistency everywhere. Karthik, what do you think?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52147
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iced84faaab8a0cca8400ccd3ec6e4cd525c30e92
Gerrit-Change-Number: 52147
Gerrit-PatchSet: 1
Gerrit-Owner: Aseda Aboagye aaboagye@google.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Aseda Aboagye aaboagye@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Wed, 07 Apr 2021 14:11:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment