Attention is currently required from: Aseda Aboagye.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81863?usp=email )
Change subject: acpigen_ps2_keybd: Add support for dictation key
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81863/comment/204b88dd_597df228 :
PS2, Line 14: Flash DUT that emits a scancode for a dictation key, verify that it
: is mapped to KEY_DICTATE in the Linux kernel.
ACK, will do. Yes, I used `evtest` to verify.
Acknowledged
File src/acpi/acpigen_ps2_keybd.c:
https://review.coreboot.org/c/coreboot/+/81863/comment/28223787_12ac6438 :
PS2, Line 59: [PS2_KEY_DICTATE] = KEYMAP(0xa7, KEY_DICTATE), /* e027*/
Could you be a bit more specific as to what it should have been sorted by? This table is currently s […]
0xa7 < 0xdd
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81863?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iabc56662a9d6b29e84ab81ed93cb46d2e8372de9
Gerrit-Change-Number: 81863
Gerrit-PatchSet: 2
Gerrit-Owner: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Aseda Aboagye
aaboagye@google.com
Gerrit-Comment-Date: Wed, 17 Apr 2024 08:13:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Aseda Aboagye
aaboagye@google.com
Gerrit-MessageType: comment