Change in coreboot[master]: drivers/intel/gma: hook up GMA for Skylake+

[Wim Vervoorn (Code Review)]

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39638 )

Change subject: drivers/intel/gma: hook up GMA for Skylake+
......................................................................

Patch Set 12:
> Patch Set 12:
> > Cannonlake employs a stub GFX ACPI table, to be used with the generic GFX driver. This is utilised by some Google boards to enable some "privacy screen" functionality. Presently excluding support for this reason.
> >
> > Additionally, I'm considering adding a guard around the "includes." This could be done using the existing GMA_ACPI, or an alternative option (allowing specific boards to opt-out. This may useful, if, for example, a board operates brightness using the EC).
>
> Makes me wonder if we shouldn't just move the #include to the `mainboard/dsdt.asl`.
> There are already a lot of blind includes for the `default_brightness_levels` on older
> platforms (even on desktop boards) just because this was included unconditionally.

I agree with you, for a large number of boards this is at least confusing. I prefer an opt-in for the boards that need it over an opt-out.