Change in coreboot[master]: {soc/amd,sb/amd/hudson}: Fix generating the ACPI mcfg

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35872 )

Change subject: {soc/amd,sb/amd/hudson}: Fix generating the ACPI mcfg
......................................................................

{soc/amd,sb/amd/hudson}: Fix generating the ACPI mcfg

The last argument for acpi_fill_mcfg is the last PCI bus, not the
total number of busses.

Change-Id: I8887e14128dbe54688eb6e803d6694b7c29956c1
Signed-off-by: Arthur Heymans 
---
M src/soc/amd/picasso/northbridge.c
M src/soc/amd/stoneyridge/northbridge.c
M src/southbridge/amd/pi/hudson/lpc.c
3 files changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/35872/1

diff --git a/src/soc/amd/picasso/northbridge.c b/src/soc/amd/picasso/northbridge.c
index 36135f9..756537b 100644
--- a/src/soc/amd/picasso/northbridge.c
+++ b/src/soc/amd/picasso/northbridge.c
@@ -167,7 +167,7 @@
    				     CONFIG_MMCONF_BASE_ADDRESS,
    				     0,
    				     0,
-					     CONFIG_MMCONF_BUS_NUMBER);
+					     CONFIG_MMCONF_BUS_NUMBER - 1);

return current;
 }
diff --git a/src/soc/amd/stoneyridge/northbridge.c b/src/soc/amd/stoneyridge/northbridge.c
index 044a1b0..2304e73 100644
--- a/src/soc/amd/stoneyridge/northbridge.c
+++ b/src/soc/amd/stoneyridge/northbridge.c
@@ -183,7 +183,7 @@
    				     CONFIG_MMCONF_BASE_ADDRESS,
    				     0,
    				     0,
-					     CONFIG_MMCONF_BUS_NUMBER);
+					     CONFIG_MMCONF_BUS_NUMBER - 1);

return current;
 }
diff --git a/src/southbridge/amd/pi/hudson/lpc.c b/src/southbridge/amd/pi/hudson/lpc.c
index 02123a1..cf73a8c 100644
--- a/src/southbridge/amd/pi/hudson/lpc.c
+++ b/src/southbridge/amd/pi/hudson/lpc.c
@@ -336,7 +336,7 @@
    				     CONFIG_MMCONF_BASE_ADDRESS,
    				     0,
    				     0,
-					     CONFIG_MMCONF_BUS_NUMBER);
+					     CONFIG_MMCONF_BUS_NUMBER - 1);
    return current;
 }

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/35872 )

Change subject: {soc/amd,sb/amd/hudson}: Fix generating the ACPI mcfg
......................................................................

{soc/amd,sb/amd/hudson}: Fix generating the ACPI mcfg

The last argument for acpi_fill_mcfg() is the last PCI bus, which is
an uint8_t, not the total number of busses, which overflows the
argument if CONFIG_MMCONF_BUS_NUMBER is 256.

Change-Id: I8887e14128dbe54688eb6e803d6694b7c29956c1
Signed-off-by: Arthur Heymans 
---
M src/soc/amd/picasso/northbridge.c
M src/soc/amd/stoneyridge/northbridge.c
M src/southbridge/amd/pi/hudson/lpc.c
3 files changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/35872/2

[Michał Żygowski (Code Review)]

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35872 )

Change subject: {soc/amd,sb/amd/hudson}: Fix generating the ACPI mcfg
......................................................................

Patch Set 2: Code-Review+2

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35872 )

Change subject: {soc/amd,sb/amd/hudson}: Fix generating the ACPI mcfg
......................................................................

Patch Set 4: Code-Review+1

I suspect it was the rebase that broke the build.  +2 when it's verified though.

[Michał Żygowski (Code Review)]

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35872 )

Change subject: {soc/amd,sb/amd/hudson}: Fix generating the ACPI mcfg
......................................................................

Patch Set 4: Code-Review+1

Same as Marshall

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded a new patch set (#6) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/35872 )

Change subject: {soc/amd,sb/amd/hudson}: Fix generating the ACPI mcfg
......................................................................

{soc/amd,sb/amd/hudson}: Fix generating the ACPI mcfg

The last argument for acpi_fill_mcfg() is the last PCI bus, which is
an uint8_t, not the total number of busses, which overflows the
argument if CONFIG_MMCONF_BUS_NUMBER is 256.

Change-Id: I8887e14128dbe54688eb6e803d6694b7c29956c1
Signed-off-by: Arthur Heymans 
---
M src/soc/amd/stoneyridge/northbridge.c
M src/southbridge/amd/pi/hudson/lpc.c
2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/35872/6

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35872 )

Change subject: {soc/amd,sb/amd/hudson}: Fix generating the ACPI mcfg
......................................................................

Patch Set 7: Code-Review+2

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35872 )

Change subject: {soc/amd,sb/amd/hudson}: Fix generating the ACPI mcfg
......................................................................

Patch Set 7: Code-Review+2

[Michał Żygowski (Code Review)]

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35872 )

Change subject: {soc/amd,sb/amd/hudson}: Fix generating the ACPI mcfg
......................................................................

Patch Set 7: Code-Review+2

[Marshall Dawson (Code Review)]

Marshall Dawson has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35872 )

Change subject: {soc/amd,sb/amd/hudson}: Fix generating the ACPI mcfg
......................................................................

{soc/amd,sb/amd/hudson}: Fix generating the ACPI mcfg

The last argument for acpi_fill_mcfg() is the last PCI bus, which is
an uint8_t, not the total number of busses, which overflows the
argument if CONFIG_MMCONF_BUS_NUMBER is 256.

Change-Id: I8887e14128dbe54688eb6e803d6694b7c29956c1
Signed-off-by: Arthur Heymans 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35872
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
Reviewed-by: Marshall Dawson 
Reviewed-by: Michał Żygowski 
---
M src/soc/amd/stoneyridge/northbridge.c
M src/southbridge/amd/pi/hudson/lpc.c
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Marshall Dawson: Looks good to me, approved
  Angel Pons: Looks good to me, approved
  Michał Żygowski: Looks good to me, approved

diff --git a/src/soc/amd/stoneyridge/northbridge.c b/src/soc/amd/stoneyridge/northbridge.c
index 63ab6b4..0f66927 100644
--- a/src/soc/amd/stoneyridge/northbridge.c
+++ b/src/soc/amd/stoneyridge/northbridge.c
@@ -170,7 +170,7 @@
    				     CONFIG_MMCONF_BASE_ADDRESS,
    				     0,
    				     0,
-					     CONFIG_MMCONF_BUS_NUMBER);
+					     CONFIG_MMCONF_BUS_NUMBER - 1);

return current;
 }
diff --git a/src/southbridge/amd/pi/hudson/lpc.c b/src/southbridge/amd/pi/hudson/lpc.c
index c884f20..b77548e 100644
--- a/src/southbridge/amd/pi/hudson/lpc.c
+++ b/src/southbridge/amd/pi/hudson/lpc.c
@@ -324,7 +324,7 @@
    				     CONFIG_MMCONF_BASE_ADDRESS,
    				     0,
    				     0,
-					     CONFIG_MMCONF_BUS_NUMBER);
+					     CONFIG_MMCONF_BUS_NUMBER - 1);
    return current;
 }