Edward O'Callaghan (eocallaghan@alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5844
-gerrit
commit d4672005679350f2064f7544492ea0c79c69ab07 Author: Edward O'Callaghan eocallaghan@alterapraxis.com Date: Sun May 25 06:30:35 2014 +1000
northbridge/intel/i3100/raminit.c: Uninitialized variable
Spotted by Clang
Change-Id: If524a5cd984602a332c4ca28a8167a3597206b94 Signed-off-by: Edward O'Callaghan eocallaghan@alterapraxis.com --- src/northbridge/intel/i3100/raminit.c | 2 +- src/northbridge/intel/i3100/raminit_ep80579.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/northbridge/intel/i3100/raminit.c b/src/northbridge/intel/i3100/raminit.c index e83feaa..443972e 100644 --- a/src/northbridge/intel/i3100/raminit.c +++ b/src/northbridge/intel/i3100/raminit.c @@ -634,7 +634,7 @@ static void set_on_dimm_termination_enable(const struct mem_controller *ctrl) { u8 c1,c2; u32 dimm,i; - u32 data32; + u32 data32 = 0; u32 t4;
/* Set up northbridge values */ diff --git a/src/northbridge/intel/i3100/raminit_ep80579.c b/src/northbridge/intel/i3100/raminit_ep80579.c index 682b1fc..90c1005 100644 --- a/src/northbridge/intel/i3100/raminit_ep80579.c +++ b/src/northbridge/intel/i3100/raminit_ep80579.c @@ -503,8 +503,8 @@ static void sdram_set_spd_registers(const struct mem_controller *ctrl) static void set_on_dimm_termination_enable(const struct mem_controller *ctrl) { u8 c1,c2; - u32 dimm,i; - u32 data32; + u32 dimm, i; + u32 data32 = 0; u32 t4;
/* Set up northbridge values */