Change in coreboot[master]: soc/intel/skylake: Make use of Intel common Graphics block

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/22615 )

Change subject: soc/intel/skylake: Make use of Intel common Graphics block
......................................................................

Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/22615/1/src/soc/intel/skylake/graphics.c
File src/soc/intel/skylake/graphics.c:

https://review.coreboot.org/#/c/22615/1/src/soc/intel/skylake/graphics.c@17
PS1, Line 17: #include <arch/io.h>
Is this required?

https://review.coreboot.org/#/c/22615/1/src/soc/intel/skylake/graphics.c@39
PS1, Line 39: graphics_gtt_read
Before this change, igd_init checked to ensure that the base was not 0 before doing any other operation. The behavior now is not the same.

Do we want to return a success/error for the read/write operations here and bail out early if any of those fail?

https://review.coreboot.org/#/c/22615/1/src/soc/intel/skylake/graphics.c@86
PS1, Line 86: return 0;
This function always returns 0. Is it really useful to have a return type for the function?