Hello Lee Leahy, Huang Jin, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43590
to look at the new patch set (#6).
Change subject: post_code: replace postcode constants with their defines in CAR stage ......................................................................
post_code: replace postcode constants with their defines in CAR stage
This change replaces constants of the postcode calls with the newly introduced defines. Some constants are left as is are meant to be removed in a follow-up commit due to the postcode being mainboard specific.
Introduced defines largely reflect postcodes common across the stage
Some calls are repositioned to reflect the defined constants
Change-Id: Ied0d6b41deed6db5eb3b39514664eb9bcc322c20 Signed-off-by: Sindhoor Tilak sindhoor@sin9yt.net --- M src/cpu/intel/car/core2/cache_as_ram.S M src/cpu/intel/car/non-evict/cache_as_ram.S M src/cpu/intel/car/p3/cache_as_ram.S M src/cpu/intel/car/p4-netburst/cache_as_ram.S M src/cpu/qemu-x86/cache_as_ram_bootblock.S M src/drivers/amd/agesa/cache_as_ram.S M src/drivers/intel/fsp1_1/cache_as_ram.S M src/include/console/post_codes.h M src/soc/amd/picasso/bootblock/pre_c.S M src/soc/intel/common/block/cpu/car/cache_as_ram.S M src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S 11 files changed, 143 insertions(+), 57 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/43590/6