Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52704 )
Change subject: drivers/intel/gma/Kconfig: Simplify Skylake/Kaby Lake conditions ......................................................................
drivers/intel/gma/Kconfig: Simplify Skylake/Kaby Lake conditions
Use `SOC_INTEL_COMMON_SKYLAKE_BASE` to simplify conditions.
Change-Id: Ie69bde31b58bbd973db00bd578a51477c5b21cab Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/52704 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Timofey Komarov happycorsair@yandex.ru Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Felix Singer felixsinger@posteo.net --- M src/drivers/intel/gma/Kconfig 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Felix Singer: Looks good to me, approved Timofey Komarov: Looks good to me, but someone else must approve
diff --git a/src/drivers/intel/gma/Kconfig b/src/drivers/intel/gma/Kconfig index b001fd3..bc96846 100644 --- a/src/drivers/intel/gma/Kconfig +++ b/src/drivers/intel/gma/Kconfig @@ -84,9 +84,9 @@ def_bool y depends on NORTHBRIDGE_INTEL_GM45 || NORTHBRIDGE_INTEL_X4X \ || NORTHBRIDGE_INTEL_IRONLAKE || NORTHBRIDGE_INTEL_SANDYBRIDGE \ - || NORTHBRIDGE_INTEL_HASWELL \ - || SOC_INTEL_BROADWELL || SOC_INTEL_SKYLAKE || SOC_INTEL_APOLLOLAKE \ - || SOC_INTEL_KABYLAKE || SOC_INTEL_COFFEELAKE \ + || NORTHBRIDGE_INTEL_HASWELL || SOC_INTEL_BROADWELL \ + || SOC_INTEL_COMMON_SKYLAKE_BASE || SOC_INTEL_APOLLOLAKE \ + || SOC_INTEL_COFFEELAKE \ || SOC_INTEL_WHISKEYLAKE || SOC_INTEL_COMETLAKE depends on MAINBOARD_USE_LIBGFXINIT || INTEL_GMA_LIBGFXINIT_EDID select RAMSTAGE_LIBHWBASE @@ -113,7 +113,7 @@ config GFX_GMA_GENERATION string default "Broxton" if SOC_INTEL_APOLLOLAKE - default "Skylake" if SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE || \ + default "Skylake" if SOC_INTEL_COMMON_SKYLAKE_BASE || \ SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE || \ SOC_INTEL_COMETLAKE default "Haswell" if NORTHBRIDGE_INTEL_HASWELL || SOC_INTEL_BROADWELL