Change in coreboot[master]: arch/x86: Fix naked reference to CONFIG_NO_CAR_GLOBAL_MIGRATION
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34440 )
Change subject: arch/x86: Fix naked reference to CONFIG_NO_CAR_GLOBAL_MIGRATION ......................................................................
arch/x86: Fix naked reference to CONFIG_NO_CAR_GLOBAL_MIGRATION
Found-by: util/lint/kconfig_lint Change-Id: I43408ddd31d7da8fde3253c56053170e01a7fd22 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/x86/car.ld M src/arch/x86/include/arch/early_variables.h 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/34440/1
diff --git a/src/arch/x86/car.ld b/src/arch/x86/car.ld index 5802b02..ab03da4 100644 --- a/src/arch/x86/car.ld +++ b/src/arch/x86/car.ld @@ -84,7 +84,7 @@ *(.sbss.*) #else /* .car.global_data objects only around when - * !CONFIG_NO_CAR_GLOBAL_MIGRATION is employed. */ + * !CONFIG(NO_CAR_GLOBAL_MIGRATION) is true. */ *(.car.global_data); #endif . = ALIGN(ARCH_POINTER_ALIGN_SIZE); diff --git a/src/arch/x86/include/arch/early_variables.h b/src/arch/x86/include/arch/early_variables.h index a69c230..ca343e7 100644 --- a/src/arch/x86/include/arch/early_variables.h +++ b/src/arch/x86/include/arch/early_variables.h @@ -83,7 +83,7 @@ /* * We might end up here if: * 1. ENV_CACHE_AS_RAM is not set for the stage or - * 2. ENV_CACHE_AS_RAM is set for the stage but CONFIG_NO_CAR_GLOBAL_MIGRATION + * 2. ENV_CACHE_AS_RAM is set for the stage but CONFIG(NO_CAR_GLOBAL_MIGRATION) is true * is also set. In this case, there is no need to migrate CAR global * variables. But, since we might still be running out of CAR, car_active needs * to return 1 if ENV_CACHE_AS_RAM is set.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34440 )
Change subject: arch/x86: Fix naked reference to CONFIG_NO_CAR_GLOBAL_MIGRATION ......................................................................
Patch Set 1:
Uhh... these are comments. That's a known limitation in the linter. That's why the check is not being enforced.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34440 )
Change subject: arch/x86: Fix naked reference to CONFIG_NO_CAR_GLOBAL_MIGRATION ......................................................................
Patch Set 1:
Patch Set 1:
Uhh... these are comments. That's a known limitation in the linter. That's why the check is not being enforced.
Yeh , right
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34440 )
Change subject: arch/x86: Fix naked reference to CONFIG_NO_CAR_GLOBAL_MIGRATION ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review) -
Julius Werner (Code Review)