Attention is currently required from: Varshit B Pandya, Subrata Banik, Maulik V Vaghela, Sugnan Prabhu S, Tim Wawrzynczak, Patrick Rudolph.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61146 )
Change subject: driver/intel/mipi_camera: Increase max power ops count to 6
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61146/comment/48fedf9d_3c51cd44
PS4, Line 9: Current max count for camera power ops is 5 which is not sufficient,
Please make that a sentence by itself (dot/period and no comma). But why is it not sufficient? Newer hardware needs more ops, and the compiler throws an error?
https://review.coreboot.org/c/coreboot/+/61146/comment/41de94ac_6b4a994d
PS4, Line 10: if we increase the ops by 1 in current variants the compiler
: will throw error for intel mipi camera driver
1. Please add a dot/period at the end of sentences.
2. But you increment it by 1. So “will throw *no* error”?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61146
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f4c090f2275616816dfc697f27520cd1cbc1a80
Gerrit-Change-Number: 61146
Gerrit-PatchSet: 4
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 26 Jan 2022 08:25:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment