Reto Buerki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44439 )
Change subject: mb/up/squared: Prompt for MAX_CPUS ......................................................................
mb/up/squared: Prompt for MAX_CPUS
The board also supports Atom processors, which have four physical cores.
Signed-off-by: Reto Buerki reet@codelabs.ch Change-Id: I98a3da660052eb7ad2f18b0c7fc0e67a609eac54 --- M src/mainboard/up/squared/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/44439/1
diff --git a/src/mainboard/up/squared/Kconfig b/src/mainboard/up/squared/Kconfig index cc8f98e..f702cfb 100644 --- a/src/mainboard/up/squared/Kconfig +++ b/src/mainboard/up/squared/Kconfig @@ -61,6 +61,7 @@ default "10ec,8168"
config MAX_CPUS + prompt "Number of CPUs" int default 2
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44439 )
Change subject: mb/up/squared: Prompt for MAX_CPUS ......................................................................
Patch Set 1:
I think a prompt for CPU cores can confuse people too much. I would rather have a choice menu or multiple boards in Kconfig.name.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44439 )
Change subject: mb/up/squared: Prompt for MAX_CPUS ......................................................................
Patch Set 1:
Please bump MAX_CPUS to 4.
Reto Buerki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44439 )
Change subject: mb/up/squared: Prompt for MAX_CPUS ......................................................................
Patch Set 1:
Patch Set 1:
Please bump MAX_CPUS to 4.
Will do. Do you also prefer a choice like Felix or do you think the current int prompt is fine?
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44439 )
Change subject: mb/up/squared: Prompt for MAX_CPUS ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Please bump MAX_CPUS to 4.
Will do. Do you also prefer a choice like Felix or do you think the current int prompt is fine?
I'm fine with setting it to 4. That's the easiest.
Reto Buerki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44439 )
Change subject: mb/up/squared: Prompt for MAX_CPUS ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1:
Please bump MAX_CPUS to 4.
Will do. Do you also prefer a choice like Felix or do you think the current int prompt is fine?
I'm fine with setting it to 4. That's the easiest.
Just to be sure, you both mean without the prompt right? Will this work for setups with only two cores?
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44439 )
Change subject: mb/up/squared: Prompt for MAX_CPUS ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1:
Please bump MAX_CPUS to 4.
Will do. Do you also prefer a choice like Felix or do you think the current int prompt is fine?
I'm fine with setting it to 4. That's the easiest.
Just to be sure, you both mean without the prompt right? Will this work for setups with only two cores?
Yes, should be fine IMO.
Hello Felix Singer, build bot (Jenkins), Christian Walter,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44439
to look at the new patch set (#2).
Change subject: mb/up/squared: Increase MAX_CPUS from 2 to 4 ......................................................................
mb/up/squared: Increase MAX_CPUS from 2 to 4
The board also supports Atom processors, which have four physical cores.
Signed-off-by: Reto Buerki reet@codelabs.ch Change-Id: I98a3da660052eb7ad2f18b0c7fc0e67a609eac54 --- M src/mainboard/up/squared/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/44439/2
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44439 )
Change subject: mb/up/squared: Increase MAX_CPUS from 2 to 4 ......................................................................
Patch Set 2: Code-Review+2
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44439 )
Change subject: mb/up/squared: Increase MAX_CPUS from 2 to 4 ......................................................................
Patch Set 2: Code-Review+2
Please rebase on master to fix the build issue.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44439 )
Change subject: mb/up/squared: Increase MAX_CPUS from 2 to 4 ......................................................................
mb/up/squared: Increase MAX_CPUS from 2 to 4
The board also supports Atom processors, which have four physical cores.
Signed-off-by: Reto Buerki reet@codelabs.ch Change-Id: I98a3da660052eb7ad2f18b0c7fc0e67a609eac54 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44439 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Christian Walter christian.walter@9elements.com Reviewed-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/up/squared/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Christian Walter: Looks good to me, approved
diff --git a/src/mainboard/up/squared/Kconfig b/src/mainboard/up/squared/Kconfig index cc8f98e..836c5bb 100644 --- a/src/mainboard/up/squared/Kconfig +++ b/src/mainboard/up/squared/Kconfig @@ -62,7 +62,7 @@
config MAX_CPUS int - default 2 + default 4
config LINUX_COMMAND_LINE string
-
Christian Walter (Code Review) -
Felix Singer (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Reto Buerki (Code Review)