Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43044 )
Change subject: volteer: enable VBOOT_EC_EFS
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43044/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43044/1//COMMIT_MSG@12
PS1, Line 12: TEST=used "V=1 emerge-${BOARD} coreboot" to verify "-DEC_EFS=1" is
: used when compiling 2ec_sync.c
does it still boot???
LoL, ya 😊
ability to boot was never in question - the issue is
whether we end up in recovery when we should not.
daisuke mentioned b/160272400 that this flag is for EFS1 only,
not EFS2, so i think more clarification is needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43044
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie71bb169242b2511b4a4102d46a6981d72d07806
Gerrit-Change-Number: 43044
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 06 Jul 2020 21:00:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment