Yan Liu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/mainboard/dedede: Add P-sensor for Boten ......................................................................
mb/mainboard/dedede: Add P-sensor for Boten
Add devicetree and device ID for P-sensor
BUG=b:161217096 BRANCH=NONE TEST=We can get the data from P-sensor if touch the SAR antenna. Signed-off-by: Yan Liu yan.liu@bitland.corp-partner.google.com Change-Id: I8e02c2cf477aa83b3d4c69ce84d48a8ad1a2560f --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/overridetree.cb 2 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/43478/1
diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig index dcea3fa..0658e66 100644 --- a/src/mainboard/google/dedede/Kconfig +++ b/src/mainboard/google/dedede/Kconfig @@ -17,6 +17,7 @@ select MAINBOARD_HAS_SPI_TPM_CR50 select MAINBOARD_HAS_TPM2 select SOC_INTEL_JASPERLAKE + select DRIVERS_I2C_SX9310
if BOARD_GOOGLE_BASEBOARD_DEDEDE
diff --git a/src/mainboard/google/dedede/variants/boten/overridetree.cb b/src/mainboard/google/dedede/variants/boten/overridetree.cb index 46fe20e..e743abe 100644 --- a/src/mainboard/google/dedede/variants/boten/overridetree.cb +++ b/src/mainboard/google/dedede/variants/boten/overridetree.cb @@ -140,6 +140,15 @@ device i2c 29 on end end end # I2C 4 + device pci 19.1 on + chip drivers/i2c/generic + register "hid" = ""sx932x"" + register "name" = ""Semtech sx932x"" + register "desc" = ""SAR Proximity Sensor"" + register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_E11_IRQ)" + device i2c 28 on end + end + end # I2C 5 device pci 1f.3 on end # Intel HDA/cAVS end end
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/mainboard/dedede: Add P-sensor for Boten ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43478/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43478/1//COMMIT_MSG@7 PS1, Line 7: mb/mainboard/dedede mb/google/dedede
Yan Liu has removed build bot (Jenkins) from this change. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/mainboard/dedede: Add P-sensor for Boten ......................................................................
Removed reviewer build bot (Jenkins) with the following votes:
* Verified+1 by build bot (Jenkins) no-reply@coreboot.org
Yan Liu has removed Marco Chen from this change. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/mainboard/dedede: Add P-sensor for Boten ......................................................................
Removed reviewer Marco Chen.
Yan Liu has removed Furquan Shaikh from this change. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/mainboard/dedede: Add P-sensor for Boten ......................................................................
Removed reviewer Furquan Shaikh.
Hello Peichao Li,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43478
to look at the new patch set (#2).
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
mb/google/dedede: Add P-sensor for Boten
Add devicetree and device ID for P-sensor
BUG=b:161217096 BRANCH=NONE TEST=We can get the data from P-sensor if touch the SAR antenna. Signed-off-by: Yan Liu yan.liu@bitland.corp-partner.google.com Change-Id: I8e02c2cf477aa83b3d4c69ce84d48a8ad1a2560f --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/overridetree.cb 2 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/43478/2
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43478/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43478/2/src/mainboard/google/dedede... PS2, Line 145: register "hid" = ""sx932x"" Do we have kernel driver to support this id already?
https://review.coreboot.org/c/coreboot/+/43478/2/src/mainboard/google/dedede... PS2, Line 149: device i2c 28 on end Some nits of the tabs above
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43478/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/43478/2/src/mainboard/google/dedede... PS2, Line 20: select DRIVERS_I2C_SX9310 Nit: Move it after Line 5 just so that it is sorted in alphabetical order.
Yan Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43478/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43478/2/src/mainboard/google/dedede... PS2, Line 145: register "hid" = ""sx932x""
Do we have kernel driver to support this id already?
Not yet,we already update sx932x driver to vendor. But may take some times to ready.
Hello build bot (Jenkins), Furquan Shaikh, Marco Chen, Peichao Li, Karthik Ramasubramanian, Gwendal Grignou,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43478
to look at the new patch set (#3).
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
mb/google/dedede: Add P-sensor for Boten
Add devicetree and device ID for P-sensor
BUG=b:161217096 BRANCH=NONE TEST=We can get the data from P-sensor if touch the SAR antenna. Signed-off-by: Yan Liu yan.liu@bitland.corp-partner.google.com Change-Id: I8e02c2cf477aa83b3d4c69ce84d48a8ad1a2560f --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/overridetree.cb 2 files changed, 126 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/43478/3
Hello build bot (Jenkins), Furquan Shaikh, Marco Chen, Peichao Li, Karthik Ramasubramanian, Gwendal Grignou,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43478
to look at the new patch set (#4).
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
mb/google/dedede: Add P-sensor for Boten
Add devicetree and device ID for P-sensor
BUG=b:161217096 BRANCH=NONE TEST=We can get the data from P-sensor if touch the SAR antenna. Signed-off-by: Yan Liu yan.liu@bitland.corp-partner.google.com Change-Id: I8e02c2cf477aa83b3d4c69ce84d48a8ad1a2560f --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/overridetree.cb 2 files changed, 125 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/43478/4
Alec Wang has uploaded a new patch set (#5) to the change originally created by Yan Liu. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
mb/google/dedede: Add P-sensor for Boten
Add devicetree and device ID for P-sensor
BUG=b:161217096 BRANCH=NONE TEST=We can get the data from P-sensor if touch the SAR antenna. Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: I8e02c2cf477aa83b3d4c69ce84d48a8ad1a2560f --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/overridetree.cb 2 files changed, 99 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/43478/5
Alec Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
Set Ready For Review
Alec Wang has uploaded a new patch set (#6) to the change originally created by Yan Liu. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
mb/google/dedede: Add P-sensor for Boten
Add devicetree and device ID for P-sensor
BUG=b:161217096 BRANCH=NONE TEST=We can get the data from P-sensor if touch the SAR antenna. Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: I8e02c2cf477aa83b3d4c69ce84d48a8ad1a2560f --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/overridetree.cb 2 files changed, 100 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/43478/6
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43478/6/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43478/6/src/mainboard/google/dedede... PS6, Line 38: .i2c[5] = { This file adds much more than just support for P-sensor. All changes other than the ones that affect P-sensor should be moved to separate CLs.
Alec Wang has uploaded a new patch set (#7) to the change originally created by Yan Liu. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
mb/google/dedede: Add P-sensor for Boten
Add devicetree and device ID for P-sensor
BUG=b:161217096 BRANCH=NONE TEST=We can get the data from P-sensor if touch the SAR antenna. Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: I8e02c2cf477aa83b3d4c69ce84d48a8ad1a2560f --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/overridetree.cb 2 files changed, 22 insertions(+), 23 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/43478/7
Alec Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43478/6/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43478/6/src/mainboard/google/dedede... PS6, Line 38: .i2c[5] = {
This file adds much more than just support for P-sensor. […]
Done
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43478/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43478/8/src/mainboard/google/dedede... PS8, Line 63: end While adding P-Sensor, you removed the Audio amplifier codec configuration. Audio will be broken. Please rebase this CL and put the audio config back.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43478/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43478/8/src/mainboard/google/dedede... PS8, Line 57: ""SAR Proximity Sensor"" Just to clarify, is this sensor added in Sub-board?
Also, you need to configure the I2C5 GPIOs as Native Function in the override GPIO configuration.
Alec Wang has uploaded a new patch set (#9) to the change originally created by Yan Liu. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
mb/google/dedede: Add P-sensor for Boten
Add devicetree and device ID for P-sensor
BUG=b:161217096 BRANCH=NONE TEST=We can get the data from P-sensor if touch the SAR antenna. Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: I8e02c2cf477aa83b3d4c69ce84d48a8ad1a2560f --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/overridetree.cb 2 files changed, 26 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/43478/9
Alec Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43478/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43478/8/src/mainboard/google/dedede... PS8, Line 57: ""SAR Proximity Sensor""
Just to clarify, is this sensor added in Sub-board? […]
Yes, it is added in Sub-board. I checked I2C5 have already enabled: PAD_CFG_NF(GPP_D22, NONE, DEEP, NF1), PAD_CFG_NF(GPP_D23, NONE, DEEP, NF1),
https://review.coreboot.org/c/coreboot/+/43478/8/src/mainboard/google/dedede... PS8, Line 63: end
While adding P-Sensor, you removed the Audio amplifier codec configuration. Audio will be broken. […]
Done. I have recovered it.
Alec Wang has uploaded a new patch set (#10) to the change originally created by Yan Liu. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
mb/google/dedede: Add P-sensor for Boten
Add devicetree and device ID for P-sensor
BUG=b:161217096 BRANCH=NONE TEST=We can get the data from P-sensor if touch the SAR antenna. Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: I8e02c2cf477aa83b3d4c69ce84d48a8ad1a2560f --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/overridetree.cb 2 files changed, 26 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/43478/10
Ben Kao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43478/10/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43478/10/src/mainboard/google/deded... PS10, Line 45: [PchSerialIoIndexI2C1] = PchSerialIoDisabled, If you want to enable the pen, please set PchSerialIoIndexI2C1 to PchSerialIoPci.
Alec Wang has uploaded a new patch set (#11) to the change originally created by Yan Liu. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
mb/google/dedede: Add P-sensor for Boten
Add devicetree and device ID for P-sensor
BUG=b:161217096 BRANCH=NONE TEST=We can get the data from P-sensor if touch the SAR antenna. Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: I8e02c2cf477aa83b3d4c69ce84d48a8ad1a2560f --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/overridetree.cb 2 files changed, 27 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/43478/11
Alec Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43478/10/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43478/10/src/mainboard/google/deded... PS10, Line 45: [PchSerialIoIndexI2C1] = PchSerialIoDisabled,
If you want to enable the pen, please set PchSerialIoIndexI2C1 to PchSerialIoPci.
Done
Gwendal Grignou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
Patch Set 11: Code-Review+1
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
Patch Set 11: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/43478/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/43478/2/src/mainboard/google/dedede... PS2, Line 20: select DRIVERS_I2C_SX9310
Nit: Move it after Line 5 just so that it is sorted in alphabetical order.
Done
https://review.coreboot.org/c/coreboot/+/43478/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43478/2/src/mainboard/google/dedede... PS2, Line 149: device i2c 28 on end
Some nits of the tabs above
Done
Peichao Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
Patch Set 11: Code-Review+1
Peichao Wang has uploaded a new patch set (#12) to the change originally created by Yan Liu. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
mb/google/dedede: Add P-sensor for Boten
Add devicetree and device ID for P-sensor
BUG=b:161217096 BRANCH=NONE TEST=We can get the data from P-sensor if touch the SAR antenna. Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: I8e02c2cf477aa83b3d4c69ce84d48a8ad1a2560f --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/overridetree.cb 2 files changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/43478/12
Peichao Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
Patch Set 12: Code-Review+1
Peichao Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43478/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43478/1//COMMIT_MSG@7 PS1, Line 7: mb/mainboard/dedede
mb/google/dedede
Done
https://review.coreboot.org/c/coreboot/+/43478/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43478/2/src/mainboard/google/dedede... PS2, Line 145: register "hid" = ""sx932x""
Not yet,we already update sx932x driver to vendor. […]
Done
Alec Wang has uploaded a new patch set (#13) to the change originally created by Yan Liu. ( https://review.coreboot.org/c/coreboot/+/43478 )
Change subject: mb/google/dedede: Add P-sensor for Boten ......................................................................
mb/google/dedede: Add P-sensor for Boten
Add devicetree and device ID for P-sensor
BUG=b:161217096 BRANCH=NONE TEST=We can get the data from P-sensor if touch the SAR antenna. Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: I8e02c2cf477aa83b3d4c69ce84d48a8ad1a2560f --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/variants/boten/overridetree.cb 2 files changed, 17 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/43478/13
-
Alec Wang (Code Review) -
Ben Kao (Code Review)
-
Furquan Shaikh (Code Review)
-
Gwendal Grignou (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Marco Chen (Code Review)
-
Paul Menzel (Code Review)
-
Peichao Wang (Code Review)
-
Yan Liu (Code Review)