Attention is currently required from: Bora Guvendik, Anil Kumar K, Hannah Williams, Cliff Huang, Paul Menzel, Angel Pons, Arthur Heymans, Zhixing Ma, Nico Huber, Michał Żygowski, Subrata Banik, Nick Vaccaro, Boris Mittelberg, Elyes Haouas.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70303 )
Change subject: soc/intel/alderlake: Add romstage early graphics support
......................................................................
Patch Set 15:
(3 comments)
File src/soc/intel/alderlake/romstage/graphics.c:
https://review.coreboot.org/c/coreboot/+/70303/comment/b8105559_4f16e769
PS13, Line 3: <arch/cpu.h>
Please include <cpu/cpu. […]
This one is not even needed anymore.
https://review.coreboot.org/c/coreboot/+/70303/comment/a13cee1c_81d64f6b
PS13, Line 4: <arch/mmio.h>
Please include <device/mmio. […]
Done.
https://review.coreboot.org/c/coreboot/+/70303/comment/38f8987d_31b8a622
PS13, Line 14: static void wait_txt_clear(void)
: {
: struct cpuid_result cp = cpuid_ext(1, 0);
:
: /* Check if TXT is supported */
: if (!(cp.ecx & (1 << 6)))
: return;
:
: /* Some TXT public bit */
: if (!(read32((void *)0xfed30010) & 1))
: return;
:
: /* Wait for TXT clear */
: while (!(read8((void *)0xfed40000) & (1 << 7)))
: ;
: }
Thanks Jeremy! […]
We still need a simple read to trigger PCH operation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70303
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I727b28bbe180edc2574e09bf03f1534d6282bdb2
Gerrit-Change-Number: 70303
Gerrit-PatchSet: 15
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Zhixing Ma
zhixing.ma@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Boris Mittelberg
bmbm@google.com
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Zhixing Ma
zhixing.ma@intel.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Wed, 14 Dec 2022 21:52:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Comment-In-Reply-To: Boris Mittelberg
bmbm@google.com
Gerrit-MessageType: comment