Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/32822 )
Change subject: src/{drivers,device,ec}: Remove unused <stdlib.h> ......................................................................
src/{drivers,device,ec}: Remove unused <stdlib.h>
Change-Id: I05422ee4b0aa5c02525ef0b4eccb4dc3ecf871e8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/32822 Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/device/i2c_bus.c M src/device/oprom/realmode/x86.c M src/device/pci_class.c M src/device/pnp_device.c M src/drivers/aspeed/ast2050/ast2050.c M src/drivers/emulation/qemu/bochs.c M src/drivers/emulation/qemu/cirrus.c M src/drivers/i2c/rtd2132/rtd2132.c M src/drivers/intel/fsp2_0/include/fsp/info_header.h M src/drivers/intel/gma/intel_ddi.c M src/drivers/net/ne2k.c M src/drivers/parade/ps8625/ps8625.c M src/drivers/sil/3114/sil_sata.c M src/drivers/smmstore/store.c M src/drivers/uart/uart8250io.c M src/drivers/vpd/vpd.c M src/drivers/vpd/vpd_cbmem.c M src/ec/google/chromeec/ec_lpc.c M src/ec/google/chromeec/vstore.c M src/ec/google/wilco/chip.c 20 files changed, 0 insertions(+), 20 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
diff --git a/src/device/i2c_bus.c b/src/device/i2c_bus.c index 93634d2..5d69efb 100644 --- a/src/device/i2c_bus.c +++ b/src/device/i2c_bus.c @@ -11,7 +11,6 @@ * GNU General Public License for more details. */
-#include <stdlib.h> #include <stdint.h> #include <console/console.h> #include <device/smbus.h> diff --git a/src/device/oprom/realmode/x86.c b/src/device/oprom/realmode/x86.c index 1026ddb..8ba0241 100644 --- a/src/device/oprom/realmode/x86.c +++ b/src/device/oprom/realmode/x86.c @@ -21,7 +21,6 @@ #include <device/pci_ids.h> #include <pc80/i8259.h> #include <pc80/i8254.h> -#include <stdlib.h> #include <string.h> #include <vbe.h>
diff --git a/src/device/pci_class.c b/src/device/pci_class.c index 0aa2f28..e084c77 100644 --- a/src/device/pci_class.c +++ b/src/device/pci_class.c @@ -14,7 +14,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <stdlib.h>
typedef struct { const unsigned char subclass_id; diff --git a/src/device/pnp_device.c b/src/device/pnp_device.c index 1852fc1..c58b375 100644 --- a/src/device/pnp_device.c +++ b/src/device/pnp_device.c @@ -12,7 +12,6 @@ */
#include <console/console.h> -#include <stdlib.h> #include <stdint.h> #include <arch/io.h> #include <device/device.h> diff --git a/src/drivers/aspeed/ast2050/ast2050.c b/src/drivers/aspeed/ast2050/ast2050.c index 67a1a80..8bc7307 100644 --- a/src/drivers/aspeed/ast2050/ast2050.c +++ b/src/drivers/aspeed/ast2050/ast2050.c @@ -11,7 +11,6 @@ * GNU General Public License for more details. */
-#include <stdlib.h> #include <arch/io.h> #include <edid.h> #include <console/console.h> diff --git a/src/drivers/emulation/qemu/bochs.c b/src/drivers/emulation/qemu/bochs.c index f49b72c..d9e4ce1 100644 --- a/src/drivers/emulation/qemu/bochs.c +++ b/src/drivers/emulation/qemu/bochs.c @@ -13,7 +13,6 @@
#include <stdint.h> #include <edid.h> -#include <stdlib.h> #include <arch/io.h> #include <console/console.h> #include <device/device.h> diff --git a/src/drivers/emulation/qemu/cirrus.c b/src/drivers/emulation/qemu/cirrus.c index 43710d9..6b1968c 100644 --- a/src/drivers/emulation/qemu/cirrus.c +++ b/src/drivers/emulation/qemu/cirrus.c @@ -14,7 +14,6 @@
#include <stdint.h> #include <edid.h> -#include <stdlib.h> #include <console/console.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/drivers/i2c/rtd2132/rtd2132.c b/src/drivers/i2c/rtd2132/rtd2132.c index 168f921..22eeaa8 100644 --- a/src/drivers/i2c/rtd2132/rtd2132.c +++ b/src/drivers/i2c/rtd2132/rtd2132.c @@ -11,7 +11,6 @@ * GNU General Public License for more details. */
-#include <stdlib.h> #include <console/console.h> #include <delay.h> #include <device/device.h> diff --git a/src/drivers/intel/fsp2_0/include/fsp/info_header.h b/src/drivers/intel/fsp2_0/include/fsp/info_header.h index d9ca73f..fd09f41 100644 --- a/src/drivers/intel/fsp2_0/include/fsp/info_header.h +++ b/src/drivers/intel/fsp2_0/include/fsp/info_header.h @@ -16,7 +16,6 @@ #define _FSP2_0_INFO_HEADER_H_
#include <stdint.h> -#include <stdlib.h> #include <types.h>
#define FSP_HDR_OFFSET 0x94 diff --git a/src/drivers/intel/gma/intel_ddi.c b/src/drivers/intel/gma/intel_ddi.c index 563f01b..d52b293 100644 --- a/src/drivers/intel/gma/intel_ddi.c +++ b/src/drivers/intel/gma/intel_ddi.c @@ -27,7 +27,6 @@ */
#include <types.h> -#include <stdlib.h> #include <device/device.h> #include <device/pci_def.h> #include <console/console.h> diff --git a/src/drivers/net/ne2k.c b/src/drivers/net/ne2k.c index 35d45ea..b1d72de 100644 --- a/src/drivers/net/ne2k.c +++ b/src/drivers/net/ne2k.c @@ -32,7 +32,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <stdlib.h> #include <ip_checksum.h>
#include "ns8390.h" diff --git a/src/drivers/parade/ps8625/ps8625.c b/src/drivers/parade/ps8625/ps8625.c index c86c4d4..8fd03b8 100644 --- a/src/drivers/parade/ps8625/ps8625.c +++ b/src/drivers/parade/ps8625/ps8625.c @@ -13,7 +13,6 @@
#include <device/i2c_simple.h> #include <stdint.h> -#include <stdlib.h>
#include "ps8625.h"
diff --git a/src/drivers/sil/3114/sil_sata.c b/src/drivers/sil/3114/sil_sata.c index 5fc58c8..c38e642 100644 --- a/src/drivers/sil/3114/sil_sata.c +++ b/src/drivers/sil/3114/sil_sata.c @@ -11,7 +11,6 @@ * GNU General Public License for more details. */
-#include <stdlib.h> #include <console/console.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/drivers/smmstore/store.c b/src/drivers/smmstore/store.c index 23d2af0..e0bfa10 100644 --- a/src/drivers/smmstore/store.c +++ b/src/drivers/smmstore/store.c @@ -18,7 +18,6 @@ #include <commonlib/region.h> #include <console/console.h> #include <smmstore.h> -#include <stdlib.h> #include <types.h>
/* diff --git a/src/drivers/uart/uart8250io.c b/src/drivers/uart/uart8250io.c index 58e0141..1b9194e 100644 --- a/src/drivers/uart/uart8250io.c +++ b/src/drivers/uart/uart8250io.c @@ -11,7 +11,6 @@ * GNU General Public License for more details. */
-#include <stdlib.h> #include <arch/io.h> #include <boot/coreboot_tables.h> #include <console/uart.h> diff --git a/src/drivers/vpd/vpd.c b/src/drivers/vpd/vpd.c index ab77a01..7ed1255 100644 --- a/src/drivers/vpd/vpd.c +++ b/src/drivers/vpd/vpd.c @@ -8,7 +8,6 @@ #include <console/console.h> #include <cbmem.h> #include <fmap.h> -#include <stdlib.h> #include <string.h> #include <timestamp.h>
diff --git a/src/drivers/vpd/vpd_cbmem.c b/src/drivers/vpd/vpd_cbmem.c index 5b68506..a0bb161 100644 --- a/src/drivers/vpd/vpd_cbmem.c +++ b/src/drivers/vpd/vpd_cbmem.c @@ -7,7 +7,6 @@ #include <console/console.h> #include <cbmem.h> #include <fmap.h> -#include <stdlib.h> #include <string.h> #include <timestamp.h>
diff --git a/src/ec/google/chromeec/ec_lpc.c b/src/ec/google/chromeec/ec_lpc.c index 1d7e7ee..6bc4fbd 100644 --- a/src/ec/google/chromeec/ec_lpc.c +++ b/src/ec/google/chromeec/ec_lpc.c @@ -20,7 +20,6 @@ #include <device/pnp.h> #include <ec/google/common/mec.h> #include <stdint.h> -#include <stdlib.h>
#include "chip.h" #include "ec.h" diff --git a/src/ec/google/chromeec/vstore.c b/src/ec/google/chromeec/vstore.c index 28c2603..50e964f 100644 --- a/src/ec/google/chromeec/vstore.c +++ b/src/ec/google/chromeec/vstore.c @@ -15,7 +15,6 @@
#include <stdint.h> #include <string.h> -#include <stdlib.h> #include "ec.h" #include "ec_commands.h"
diff --git a/src/ec/google/wilco/chip.c b/src/ec/google/wilco/chip.c index 09211f8..70e6124 100644 --- a/src/ec/google/wilco/chip.c +++ b/src/ec/google/wilco/chip.c @@ -22,7 +22,6 @@ #include <ec/acpi/ec.h> #include <pc80/keyboard.h> #include <stdint.h> -#include <stdlib.h>
#include "commands.h" #include "ec.h"
-
Kyösti Mälkki (Code Review)