Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Jason Nien, Jérémy Compostella, Martin Roth, Matt DeVillier.
Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79910?usp=email )
Change subject: tree: Set <types.h> chain-include <inttypes.h> ......................................................................
tree: Set <types.h> chain-include <inttypes.h>
Change-Id: I7726e69dfe1d919970359f4f626f69322021a599 Signed-off-by: Elyes Haouas ehaouas@noos.fr --- M src/cpu/x86/smm/tseg_region.c M src/include/types.h M src/lib/coreboot_table.c M src/lib/fw_config.c M src/mainboard/google/zork/variants/baseboard/helpers.c M src/northbridge/intel/i945/raminit.c M src/soc/amd/common/block/smbus/smbus.c M src/soc/amd/common/block/xhci/elog.c M src/soc/intel/common/block/tcss/tcss.c 9 files changed, 6 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/79910/1
diff --git a/src/cpu/x86/smm/tseg_region.c b/src/cpu/x86/smm/tseg_region.c index 413d5fc..18c770f 100644 --- a/src/cpu/x86/smm/tseg_region.c +++ b/src/cpu/x86/smm/tseg_region.c @@ -6,7 +6,6 @@ #include <cpu/x86/smm.h> #include <stage_cache.h> #include <types.h> -#include <inttypes.h>
/* * Subregions within SMM diff --git a/src/include/types.h b/src/include/types.h index ca45717..8ec8695 100644 --- a/src/include/types.h +++ b/src/include/types.h @@ -10,6 +10,7 @@ #include <stdbool.h> #include <stdint.h> #include <stddef.h> +#include <inttypes.h> /* IWYU pragma: end_exports */
/* diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c index 800d2d4..f063b47 100644 --- a/src/lib/coreboot_table.c +++ b/src/lib/coreboot_table.c @@ -19,7 +19,6 @@ #include <cbmem.h> #include <bootmem.h> #include <bootsplash.h> -#include <inttypes.h> #include <spi_flash.h> #include <smmstore.h> #include <types.h> diff --git a/src/lib/fw_config.c b/src/lib/fw_config.c index 268be07..6f35e94 100644 --- a/src/lib/fw_config.c +++ b/src/lib/fw_config.c @@ -7,11 +7,11 @@ #include <device/device.h> #include <ec/google/chromeec/ec.h> #include <fw_config.h> -#include <inttypes.h> #include <lib.h> #include <stdbool.h> #include <stdint.h> #include <drivers/vpd/vpd.h> +#include <types.h>
uint64_t fw_config_get(void) { diff --git a/src/mainboard/google/zork/variants/baseboard/helpers.c b/src/mainboard/google/zork/variants/baseboard/helpers.c index ed98177..9ce7201 100644 --- a/src/mainboard/google/zork/variants/baseboard/helpers.c +++ b/src/mainboard/google/zork/variants/baseboard/helpers.c @@ -1,9 +1,9 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
#include <console/console.h> -#include <inttypes.h> #include <baseboard/variants.h> #include <ec/google/chromeec/ec.h> +#include <types.h>
/* Global definitions for FW_CONFIG values */ enum { diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c index 2613b81..3e9447c 100644 --- a/src/northbridge/intel/i945/raminit.c +++ b/src/northbridge/intel/i945/raminit.c @@ -9,7 +9,6 @@ #include <device/pci_ops.h> #include <device/pci_type.h> #include <device/smbus_host.h> -#include <inttypes.h> #include <lib.h> #include <pc80/mc146818rtc.h> #include <spd.h> diff --git a/src/soc/amd/common/block/smbus/smbus.c b/src/soc/amd/common/block/smbus/smbus.c index 1a97e52..d95bfee 100644 --- a/src/soc/amd/common/block/smbus/smbus.c +++ b/src/soc/amd/common/block/smbus/smbus.c @@ -1,12 +1,12 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <inttypes.h> #include <console/console.h> #include <device/mmio.h> #include <device/smbus_host.h> #include <amdblocks/acpimmio.h> #include <amdblocks/smbus.h> #include <soc/southbridge.h> +#include <types.h>
/* * Between 1-10 seconds, We should never timeout normally diff --git a/src/soc/amd/common/block/xhci/elog.c b/src/soc/amd/common/block/xhci/elog.c index 64a2c48..969918d 100644 --- a/src/soc/amd/common/block/xhci/elog.c +++ b/src/soc/amd/common/block/xhci/elog.c @@ -9,8 +9,7 @@ #include <device/pci_type.h> #include <device/xhci.h> #include <elog.h> - -#include <inttypes.h> +#include <types.h>
#define PORTSC_OFFSET 0x400 #define PORTSC_STRIDE 0x10 diff --git a/src/soc/intel/common/block/tcss/tcss.c b/src/soc/intel/common/block/tcss/tcss.c index 7c58e3a..06ac280 100644 --- a/src/soc/intel/common/block/tcss/tcss.c +++ b/src/soc/intel/common/block/tcss/tcss.c @@ -10,12 +10,12 @@ #include <intelblocks/pmc_ipc.h> #include <intelblocks/systemagent.h> #include <intelblocks/tcss.h> -#include <inttypes.h> #include <lib.h> #include <security/vboot/vboot_common.h> #include <soc/pci_devs.h> #include <soc/pcr_ids.h> #include <soc/tcss.h> +#include <types.h> #include <drivers/intel/pmc_mux/conn/chip.h>
#define BIAS_CTRL_VW_INDEX_SHIFT 16
-
Elyes Haouas (Code Review)